From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67823C352A1 for ; Wed, 7 Dec 2022 08:08:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229452AbiLGIIn (ORCPT ); Wed, 7 Dec 2022 03:08:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229560AbiLGIIk (ORCPT ); Wed, 7 Dec 2022 03:08:40 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AD2222501; Wed, 7 Dec 2022 00:08:39 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 9D706CE1B06; Wed, 7 Dec 2022 08:08:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CAACC433B5; Wed, 7 Dec 2022 08:08:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670400515; bh=dh0NHFxS6FH0MAIpFjCQ0xsK44R9nD77S1vwGB4tbXY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u2Z0XGwzU5rhxZ47IGdJC4cZ5SWxwZd2PAfrFapRuH0ECUlff0pUfQyCPposur7v+ ZkZCSIu8ispQ0Gt6qmlEHBThxzZyqIfBj+q1qqa+fg+vi93Sz72X1c2RkBa2GIp61O RKrtBMKBn643EiWuVW4W4rEa9Z5Fe6cLZKyuQSPlG9RQhhmodr5vP1OAHcpsEV0Wm1 G13PZv4TTkqVcXJjY/MPOCeVICt3C20fnrJjxTuiBHlcLpOROHCt1i44s0TZ1cx/FJ BwqQI0tRqdUkWErUJ0G0AmVuNF5aOjMxFID+QV2v0vU/yFjxR5e3vq8tdOsnAI/Wwh ScGJZMPNlng/A== Date: Wed, 7 Dec 2022 08:08:28 +0000 From: Conor Dooley To: Guo Ren Cc: Palmer Dabbelt , Xianting Tian , mick@ics.forth.gr, corbet@lwn.net, alexandre.ghiti@canonical.com, vgoyal@redhat.com, bhe@redhat.com, Paul Walmsley , Conor Dooley , bagasdotme@gmail.com, dyoung@redhat.com, Palmer Dabbelt , heiko@sntech.de, anup@brainfault.org, aou@eecs.berkeley.edu, hschauhan@nulltrace.org, yixun.lan@gmail.com, kexec@lists.infradead.org, heinrich.schuchardt@canonical.com, linux-doc@vger.kernel.org, crash-utility@redhat.com, linux-kernel@vger.kernel.org, k-hagio-ab@nec.com, linux-riscv@lists.infradead.org Subject: Re: [PATCH V5 0/2] Support VMCOREINFO export for RISCV64 Message-ID: References: <20221026144208.373504-1-xianting.tian@linux.alibaba.com> <167002857934.4256.16584443879212253129.b4-ty@rivosinc.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kTp0eC94p1NhUqFh" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org --kTp0eC94p1NhUqFh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 07, 2022 at 11:34:57AM +0800, Guo Ren wrote: > On Wed, Dec 7, 2022 at 7:05 AM Conor Dooley wrote: > > > > Hey Palmer, Xianting, > > > > On Fri, Dec 02, 2022 at 04:49:39PM -0800, Palmer Dabbelt wrote: > > > On Wed, 26 Oct 2022 22:42:06 +0800, Xianting Tian wrote: > > > > As disscussed in below patch set, the patch of 'describe VMCOREINFO= export in Documentation' > > > > need to update according to Bagas's comments. > > > > https://lore.kernel.org/linux-riscv/22AAF52E-8CC8-4D11-99CB-88DE4D1= 13444@kernel.org/ > > > > > > > > As others patches in above patch set already applied, so this patch= set only contains below two > > > > patches. > > > > > > > > [...] > > > > > > Applied, thanks! > > > > > > [1/2] RISC-V: Add arch_crash_save_vmcoreinfo support > > > https://git.kernel.org/palmer/c/649d6b1019a2 > > > > So this patch seems to be causing issues for the nommu build: > > https://lore.kernel.org/oe-kbuild-all/202212062250.tR0otHcz-lkp@intel.c= om/ > > > > I had a bit of a poke at trying to see if there were some headers we > > could pull in before actually checking the .config only to see: > > # CONFIG_MMU is not set > > > > Do we have to wrap the whole thing in a `#ifdef CONFIG_MMU` to fix > > compilation here? > The problem does not belong to the patch. >=20 > Could I send a fixup patch? like this? That seems like a sane dependancy, but did you build that config? This doesn't fix the problem for me :/ >=20 > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index ef8d66de5f38..d8c07999426c 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -512,6 +512,7 @@ config ARCH_HAS_KEXEC_PURGATORY >=20 > config CRASH_DUMP > bool "Build kdump crash kernel" > + depends on KEXEC > help > Generate crash dump after being started by kexec. This should > be normally only set in special crash dump kernels which are >=20 > > > > Thanks, > > Conor. > > >=20 >=20 > --=20 > Best Regards > Guo Ren --kTp0eC94p1NhUqFh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCY5BJ8gAKCRB4tDGHoIJi 0ubRAPoCBXcQ4wIxwjTftwrdbA4d0c0vUsTpCiuxvofCAdWZkQD9FBTHcyzfFOqY ZAI3YncP+u9hP81Ipg8Mzi7iCHql9gk= =PuCV -----END PGP SIGNATURE----- --kTp0eC94p1NhUqFh--