From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43D2FC54EBD for ; Sun, 8 Jan 2023 23:48:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229693AbjAHXsO (ORCPT ); Sun, 8 Jan 2023 18:48:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233690AbjAHXsO (ORCPT ); Sun, 8 Jan 2023 18:48:14 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19865E0FE; Sun, 8 Jan 2023 15:48:13 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id p1-20020a05600c1d8100b003d8c9b191e0so5365943wms.4; Sun, 08 Jan 2023 15:48:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bvIkcnN7jqI1qIrkfG25yW+dEOQUB74c9FPX0mQZDAY=; b=DoZZQMydak3s2tsQ2JCcyiwFNQoDK/6V9+aWtelBaCufrAtNbJlIdjG2lqYYu/Q3N+ fBROteW7yESOBMCt7luznZ5howIhErsFHD0Q8oU108gS53lLBV7xPuCKaqGj6EhEyh1m yuRZXX3UAeeG5V8jsqiCMjBCsVFbDTY8f5YrSDJGE28SUD+fvviv9BaXGTUSW9bGLPAX TRk5vqT9AAJXeW7PNYLv7xHXpGsZ/EUJxzkin2R0poP4ItXree7+MUJU9FJy54SBvFwz 4vmNVSejgNYOQbGuftNQybJ+ZqTdZQaoWGFP3jyaG9AQ5RmDnoEWIYXEpbXuFATrKx/D ye4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bvIkcnN7jqI1qIrkfG25yW+dEOQUB74c9FPX0mQZDAY=; b=We4oQeFjv3LFB0DFw95l99jJmETifojZH36qqrGcUb3f/bAbxhlh64HY0RHYpQk/lh LhkTQyJXsXjOOLntTlXrBZw191DbAGUQ5Pxt1NllBUQM/QqSgloViIxKmrH5ybBMb73A mH8oapaOZ9D4QZzt7jpFflhTMp8iqT7WnmYjmw6DXc0b1VfYkuBO/IAV0emzyYrKM06x PpEmfek7dqqePkngfPTzoKGWKucPmOjkUYAh8X6XgZ1iu+v9Sp0X5uROIp1mgDhn+7HW HLHprakb/wCWZueNZgrmOueNY8DmQ1O35JbAAF+KZxudFQE5FbxNrvDGe3SMdB2lv+7r EUCA== X-Gm-Message-State: AFqh2kq5cuXp9fyljaw+r2KEm26ZDz4PyR39q5vUub+vHeBLF47QO0jc tgoaCg8PAkAQ4h0k+no5lDY= X-Google-Smtp-Source: AMrXdXstidVps+mowGTsqN9HY4o23vxRSMb1FX3fQeRRwSdGNnEh0w8H9iaPB7kL8iMObseeeEViMA== X-Received: by 2002:a05:600c:3509:b0:3cf:ae53:9193 with SMTP id h9-20020a05600c350900b003cfae539193mr44836977wmq.39.1673221691556; Sun, 08 Jan 2023 15:48:11 -0800 (PST) Received: from gvm01 (net-5-89-66-224.cust.vodafonedsl.it. [5.89.66.224]) by smtp.gmail.com with ESMTPSA id bg23-20020a05600c3c9700b003d1de805de5sm10597727wmb.16.2023.01.08.15.48.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Jan 2023 15:48:10 -0800 (PST) Date: Mon, 9 Jan 2023 00:48:09 +0100 From: Piergiorgio Beruto To: Andrew Lunn Cc: Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Oleksij Rempel , mailhol.vincent@wanadoo.fr, sudheer.mogilappagari@intel.com, sbhatta@marvell.com, linux-doc@vger.kernel.org, wangjie125@huawei.com, corbet@lwn.net, lkp@intel.com, gal@nvidia.com, gustavoars@kernel.org Subject: Re: [PATCH v2 net-next 3/5] drivers/net/phy: add connection between ethtool and phylib for PLCA Message-ID: References: <9a25328bcf2c0d963e34d33ff0968f83755905f4.1673030528.git.piergiorgio.beruto@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Hello Andrew, thank you very much for your review. I have fixed this issue. Piergiorgio On Sat, Jan 07, 2023 at 06:37:52PM +0100, Andrew Lunn wrote: > > + // if not enabling PLCA, skip a few sanity checks > > + if (plca_cfg->enabled <= 0) > > + goto apply_cfg; > > + > > + if (!linkmode_test_bit(ETHTOOL_LINK_MODE_10baseT1S_P2MP_Half_BIT, > > + phydev->advertising)) { > > + ret = -EOPNOTSUPP; > > + NL_SET_ERR_MSG(extack, > > + "Point to Multi-Point mode is not enabled"); > > + } > > + > > + // allow setting node_id concurrently with enabled > > + if (plca_cfg->node_id >= 0) > > + curr_plca_cfg->node_id = plca_cfg->node_id; > > + > > + if (curr_plca_cfg->node_id >= 255) { > > + NL_SET_ERR_MSG(extack, "PLCA node ID is not set"); > > + ret = -EINVAL; > > + goto out_drv; > > + } > > + > > +apply_cfg: > > + ret = phydev->drv->set_plca_cfg(phydev, plca_cfg); > > Goto which don't jump to the end of the function is generally frowned > upon. I suggest you put these sanity checks into a little helper, so > you can avoid the goto. > > With that change make, feel free to add my reviewed-by. > > Andrew