From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D0DDC5479D for ; Tue, 10 Jan 2023 02:33:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230171AbjAJCds (ORCPT ); Mon, 9 Jan 2023 21:33:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230373AbjAJCdn (ORCPT ); Mon, 9 Jan 2023 21:33:43 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14C08140B4 for ; Mon, 9 Jan 2023 18:33:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673317980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l94HaeBEBiFD5ilSjwcw6DDx5RLDQlnkVXrKy/YYH8k=; b=FofUrZIHiIC9zynk+CslZw10H1LUUO1e6aMcC8rxEpEWK/D0TTbL0ukFdfH9sf5ddJXR3R RDys0DA6TB0SZeMDhv0E+GSFxiQYAT6WctpIgSHd4jw8BZIaGZ6+SD0KZcmRaLD+QFcXfj niWIrxjjkuLKaN29RDFU8zVe7b+DCDs= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-142-tXc1h2RJOnCvWpTl6LAxOg-1; Mon, 09 Jan 2023 21:32:55 -0500 X-MC-Unique: tXc1h2RJOnCvWpTl6LAxOg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A42F33804062; Tue, 10 Jan 2023 02:32:54 +0000 (UTC) Received: from localhost (ovpn-12-27.pek2.redhat.com [10.72.12.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CBCFF2166B26; Tue, 10 Jan 2023 02:32:53 +0000 (UTC) Date: Tue, 10 Jan 2023 10:32:49 +0800 From: Baoquan He To: Ricardo Ribalda , akpm@linux-foundation.org Cc: Philipp Rudo , Eric Biederman , "Guilherme G. Piccoli" , Jonathan Corbet , linux-doc@vger.kernel.org, Sergey Senozhatsky , "Joel Fernandes (Google)" , Petr Tesarik , kexec@lists.infradead.org, Bagas Sanjaya , Steven Rostedt , linux-kernel@vger.kernel.org, Ross Zwisler Subject: Re: [PATCH v6 0/3] kexec: Add new parameter to limit the access to kexec Message-ID: References: <20221114-disable-kexec-reset-v6-0-6a8531a09b9a@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221114-disable-kexec-reset-v6-0-6a8531a09b9a@chromium.org> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 01/04/23 at 03:38pm, Ricardo Ribalda wrote: > Add two parameter to specify how many times a kexec kernel can be loaded. > > These parameter allow hardening the system. > > While we are at it, fix a documentation issue and refactor some code. The whole series looks good to me, thx. Acked-by: Baoquan He > > To: Jonathan Corbet > To: Eric Biederman > Cc: linux-doc@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: kexec@lists.infradead.org > Cc: Joel Fernandes (Google) > Cc: Sergey Senozhatsky > Cc: Steven Rostedt > Cc: Ross Zwisler > To: Philipp Rudo > To: Guilherme G. Piccoli > Cc: Bagas Sanjaya > Cc: Petr Tesarik > Cc: Baoquan He > Signed-off-by: Ricardo Ribalda > > --- > Changes in v6: > - Fix kexec type on kexec_file > - Match the length of the table borders to the sections underline (Thanks Bagas!) > - Fix typo on kexec_load_limit_reboot (Thanks Petr!) > - Improve commit message (Thanks Baoquan!) > - Link to v5: https://lore.kernel.org/r/20221114-disable-kexec-reset-v5-0-1bd37caf3c75@chromium.org > > Changes in v5: > - Remove maxlen from ctl_table. Thanks Steven! > - Link to v4: https://lore.kernel.org/r/20221114-disable-kexec-reset-v4-0-ab809c8d988c@chromium.org > > Changes in v4 (Thanks Steven!): > - Uses sysctl instead or module_parameters > - Pass image type instead of boolean to permitted > - Fix typo on flag handling > - Return -EINVAL for values that does not change the current value. > - Link to v3: https://lore.kernel.org/r/20221114-disable-kexec-reset-v3-0-4ef4e929adf6@chromium.org > > Changes in v3: > - s/paramter/parameter/ Thanks Ghilherme! > - s/permited/permitted/ Thanks Joel! > - Link to v2: https://lore.kernel.org/r/20221114-disable-kexec-reset-v2-0-c498313c1bb5@chromium.org > > Changes in v2: > - Instead of kexec_reboot_disabled, add two new counters (Thanks Philipp!) > - Link to v1: https://lore.kernel.org/r/20221114-disable-kexec-reset-v1-0-fb51d20cf871@chromium.org > > --- > Ricardo Ribalda (3): > Documentation: sysctl: Correct kexec_load_disabled > kexec: Factor out kexec_load_permitted > kexec: Introduce sysctl parameters kexec_load_limit_* > > Documentation/admin-guide/sysctl/kernel.rst | 25 +++++++- > include/linux/kexec.h | 3 +- > kernel/kexec.c | 4 +- > kernel/kexec_core.c | 94 ++++++++++++++++++++++++++++- > kernel/kexec_file.c | 11 ++-- > 5 files changed, 127 insertions(+), 10 deletions(-) > --- > base-commit: 479174d402bcf60789106eedc4def3957c060bad > change-id: 20221114-disable-kexec-reset-19b7e117338f > > Best regards, > -- > Ricardo Ribalda >