From: Christoph Hellwig <hch@infradead.org>
To: Fabio Fantoni <fantonifabio@tiscali.it>
Cc: Christoph Hellwig <hch@infradead.org>,
corbet@lwn.net, axboe@kernel.dk, linux-block@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Sergei Shtepa <sergei.shtepa@veeam.com>
Subject: Re: [PATCH v2] documentation: fix Generic Block Device Capability
Date: Mon, 16 Jan 2023 22:05:00 -0800 [thread overview]
Message-ID: <Y8Y6jLdXnnBTps7l@infradead.org> (raw)
In-Reply-To: <62a18c7d-93d9-657e-48fd-1af06d6d1d9e@tiscali.it>
On Mon, Jan 16, 2023 at 07:14:41PM +0100, Fabio Fantoni wrote:
> Il 16/01/2023 18:53, Christoph Hellwig ha scritto:
> > On Tue, Jan 10, 2023 at 02:21:04PM +0100, Fabio Fantoni wrote:
> > > - * ``GENHD_FL_REMOVABLE``: indicates that the block device gives access to
> > > + * ``GENHD_FL_REMOVABLE`` (0x01): indicates that the block device gives access to
> > The numberic values really do not belong into the documentation. They
> > are just implementation details.
> >
> Thanks for reply, if values are not into the documentation see from
> /sys/block/<disk>/capability output what flags are enabled will require look
> to source code of include/linux/blkdev.h and
> Documentation/block/capability.rst will be less useful, or I'm wrong?
Urgg. I think this file is generally just a bad idea. The flags are
kernel internal and not isolated from userspace. It seems nothing broke
with the various renumbering lately, but we need to isolate it from
the implementation details. And if it really should be a user API
we need a text version of it.
next prev parent reply other threads:[~2023-01-17 6:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 13:21 [PATCH v2] documentation: fix Generic Block Device Capability Fabio Fantoni
2023-01-16 17:53 ` Christoph Hellwig
2023-01-16 18:14 ` Fabio Fantoni
2023-01-17 6:05 ` Christoph Hellwig [this message]
2023-01-17 15:51 ` Fabio Fantoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8Y6jLdXnnBTps7l@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=corbet@lwn.net \
--cc=fantonifabio@tiscali.it \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sergei.shtepa@veeam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox