From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D8DEC004D4 for ; Fri, 20 Jan 2023 01:40:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229574AbjATBkW (ORCPT ); Thu, 19 Jan 2023 20:40:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229485AbjATBkV (ORCPT ); Thu, 19 Jan 2023 20:40:21 -0500 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 538109EE23 for ; Thu, 19 Jan 2023 17:40:19 -0800 (PST) Received: by mail-pj1-x102a.google.com with SMTP id d8so4221658pjc.3 for ; Thu, 19 Jan 2023 17:40:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Lg0CzDuQy4V1JV2pIlemk74MHa85PjPJTHngrqfHjrE=; b=ImZO6fhqVqvCqs7rXFaCOuWNTnnC9RvQXYi9jvRLJEucdXDUti7JkfHu8O7Jl0o1GR +2I8c9hfOjkyjtdGDJYnmeqRq+CZCntKqF/JgZKW3QCMWkTkodvRvyA6NehFi/fNR3JR q5vS5fZwKy7YcH0ChMeMVdcGr2HFhMgWJGSw7hGGFEgmghvWJ4WYsqA5bnIfUDAJCoDP FwTqdndfEXhPnjjsPP00SboMIZGbc8abyDGrB7OwQri1BMYBF6e1DCtOrs+y4cyJKnkf g7z3MLrTGb9cTVHMZQkXmHC6qF610iMQCpr0zmjZ3iQ16ASnhWUzl5F9fg94FHRmVKaR DpJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Lg0CzDuQy4V1JV2pIlemk74MHa85PjPJTHngrqfHjrE=; b=3hoSScguPRIr9CMb+wXGN3RH6nlDda2ANcfyw/RKsdSYEmX+PyiMdGYHsaFth4QxSw 2ggZgZA+PVljmNVQ4JAC3x0AimtT6er8Pnft9j6rHO5P7XX/3ZIrB4EiD8sDok3EYoJ2 xs+WGUr4O9c6iIOMgcJ8XFFJfXxkU4lHwlqc6VJGnupPSlHsl+V3OyJURo+wt1OlRQ/J s5MdyeAVrxoolK7GsY0ePn5OzFgFW3JMm+HafAGhdH+tfNyKqE6HA+XPf1ipV7Mc/klw GJRiTMANJptNLGMDsQbpgJaRpXowWTvK5k6gedcpkJ7QmR5ICeczHsl9tlGNksYFz71T 2cog== X-Gm-Message-State: AFqh2kr8iCPrahtZ6sfYnpjLT5fdfoHOsCLK4hpgDVsEi2/3PKejFvwI 26vVaqFFlJkQ9Ky62D8cgFNfTQ== X-Google-Smtp-Source: AMrXdXvcVM2ifx1QliZxHIX+7OmGHQVLmRwBNhn73tk9W4ClFQY0b1V9fyA2FC+YR1J/ddz+yLlbqQ== X-Received: by 2002:a17:902:eb45:b0:189:6624:58c0 with SMTP id i5-20020a170902eb4500b00189662458c0mr10964pli.3.1674178818663; Thu, 19 Jan 2023 17:40:18 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id 35-20020a631563000000b0044ed37dbca8sm21340893pgv.2.2023.01.19.17.40.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 17:40:18 -0800 (PST) Date: Fri, 20 Jan 2023 01:40:13 +0000 From: Sean Christopherson To: Borislav Petkov Cc: Paolo Bonzini , kvm@vger.kernel.org, Kim Phillips , x86@kernel.org, Boris Ostrovsky , Dave Hansen , "H. Peter Anvin" , Ingo Molnar , Joao Martins , Jonathan Corbet , Konrad Rzeszutek Wilk , Thomas Gleixner , David Woodhouse , Greg Kroah-Hartman , Juergen Gross , Peter Zijlstra , Tony Luck , Tom Lendacky , Alexey Kardashevskiy , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 0/7] x86/cpu, kvm: Support AMD Automatic IBRS Message-ID: References: <20230116230159.1511393-1-kim.phillips@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Tue, Jan 17, 2023, Borislav Petkov wrote: > On Mon, Jan 16, 2023 at 05:01:52PM -0600, Kim Phillips wrote: > > > Kim Phillips (7): > > x86/cpu, kvm: Add support for cpuid leaf 80000021/EAX (FeatureExt2Eax) > > x86/cpu, kvm: Add the NO_NESTED_DATA_BP feature > > x86/cpu, kvm: Move the LFENCE_RDTSC / LFENCE always serializing > > feature > > x86/cpu, kvm: Add the Null Selector Clears Base feature > > x86/cpu, kvm: Add the SMM_CTL MSR not present feature > > x86/cpu: Support AMD Automatic IBRS > > x86/cpu, kvm: Propagate the AMD Automatic IBRS feature to the guest > > > > Documentation/admin-guide/hw-vuln/spectre.rst | 6 ++-- > > .../admin-guide/kernel-parameters.txt | 6 ++-- > > arch/x86/include/asm/cpufeature.h | 7 +++-- > > arch/x86/include/asm/cpufeatures.h | 11 +++++-- > > arch/x86/include/asm/disabled-features.h | 3 +- > > arch/x86/include/asm/msr-index.h | 2 ++ > > arch/x86/include/asm/required-features.h | 3 +- > > arch/x86/kernel/cpu/amd.c | 2 +- > > arch/x86/kernel/cpu/bugs.c | 20 ++++++++----- > > arch/x86/kernel/cpu/common.c | 22 +++++++++----- > > arch/x86/kvm/cpuid.c | 30 +++++++------------ > > arch/x86/kvm/reverse_cpuid.h | 1 + > > arch/x86/kvm/svm/svm.c | 3 ++ > > arch/x86/kvm/x86.c | 3 ++ > > 14 files changed, 71 insertions(+), 48 deletions(-) > > KVM folks, > > I'm going to route this through the tip tree, along with the KVM bits. > > Holler if we should do something else to avoid any potential conflicts. Sorry, completely missed this. There will be a minor conflict in KVM's reverse_cpuid, but it's trivial to resolve. I don't anticipate any other conflicts, so taking this through tip does seem like the best option. If possible, a new version to fix the bisection issues in patches 2 and 3 would be nice, but again it's not a big deal. The breakage is very, very minor.