From: Cristian Marussi <cristian.marussi@arm.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Linux Documentation <linux-doc@vger.kernel.org>,
sudeep.holla@arm.com,
Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH] firmware: arm_scmi: Clarify Raw per-channel ABI documentation
Date: Fri, 20 Jan 2023 14:34:39 +0000 [thread overview]
Message-ID: <Y8qmf1cUdZYoukAX@e120937-lin> (raw)
In-Reply-To: <Y8qMclu5Tc3dKCS6@debian.me>
On Fri, Jan 20, 2023 at 07:43:30PM +0700, Bagas Sanjaya wrote:
> [Also Cc: linux-doc list]
>
Sorry for missing the Cc but get_maintainer.pl did not say anything
about this ABI docs patches.
> On Fri, Jan 20, 2023 at 12:23:26PM +0000, Cristian Marussi wrote:
> > diff --git a/Documentation/ABI/testing/debugfs-scmi-raw b/Documentation/ABI/testing/debugfs-scmi-raw
> > index 5468ec08c084..b1c505ed444c 100644
> > --- a/Documentation/ABI/testing/debugfs-scmi-raw
> > +++ b/Documentation/ABI/testing/debugfs-scmi-raw
> > @@ -80,9 +80,13 @@ Description: SCMI Raw synchronous message injection/snooping facility; write
> > Each write to the entry causes one command request to be built
> > and sent while the replies are read back one message at time
> > (receiving an EOF at each message boundary).
> > + Channel identifier <m> matches the SCMI protocol number which
> > + has been associated with this transport channel in the DT
> > + description, with Base protocol number 0x10 being the default
> > + channel for this instance.
>
> s/Base/base/
>
Thought that being an SCMI protocol name definitions would have to be
capitalized.
> > Note that these per-channel entries rooted at <..>/channels
> > exist only if the transport is configured to have more than
> > - one channel.
> > + one default channel.
> > Users: Debugging, any userspace test suite
> >
> > What: /sys/kernel/debug/scmi/<n>/raw/channels/<m>/message_async
> > @@ -103,7 +107,11 @@ Description: SCMI Raw asynchronous message injection/snooping facility; write
> > Each write to the entry causes one command request to be built
> > and sent while the replies are read back one message at time
> > (receiving an EOF at each message boundary).
> > + Channel identifier <m> matches the SCMI protocol number which
> > + has been associated with this transport channel in the DT
> > + description, with Base protocol number 0x10 being the default
> > + channel for this instance.
>
> Same here.
>
> > Note that these per-channel entries rooted at <..>/channels
> > exist only if the transport is configured to have more than
> > - one channel.
> > + one default channel.
> > Users: Debugging, any userspace test suite
>
> Otherwise LGTM.
>
Thanks,
Cristian
prev parent reply other threads:[~2023-01-20 14:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230120122326.1932614-1-cristian.marussi@arm.com>
2023-01-20 12:43 ` [PATCH] firmware: arm_scmi: Clarify Raw per-channel ABI documentation Bagas Sanjaya
2023-01-20 14:34 ` Cristian Marussi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8qmf1cUdZYoukAX@e120937-lin \
--to=cristian.marussi@arm.com \
--cc=bagasdotme@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.holla@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).