* [PATCH] Documentation/Kbuild: Remove references to gcc-plugin.sh
@ 2021-01-22 18:04 Robert Karszniewicz
2021-01-22 19:23 ` Kees Cook
2021-01-23 13:17 ` Masahiro Yamada
0 siblings, 2 replies; 4+ messages in thread
From: Robert Karszniewicz @ 2021-01-22 18:04 UTC (permalink / raw)
To: Kees Cook, Masahiro Yamada, Michal Marek, Jonathan Corbet
Cc: Philipp Rudo, linux-hardening, linux-kbuild, linux-doc,
Robert Karszniewicz, Robert Karszniewicz
gcc-plugin.sh has been removed in commit
1e860048c53e ("gcc-plugins: simplify GCC plugin-dev capability test").
Signed-off-by: Robert Karszniewicz <r.karszniewicz@phytec.de>
---
Documentation/kbuild/gcc-plugins.rst | 6 ------
scripts/dummy-tools/gcc | 15 ---------------
2 files changed, 21 deletions(-)
diff --git a/Documentation/kbuild/gcc-plugins.rst b/Documentation/kbuild/gcc-plugins.rst
index 4b1c10f88e30..63379d0150e3 100644
--- a/Documentation/kbuild/gcc-plugins.rst
+++ b/Documentation/kbuild/gcc-plugins.rst
@@ -47,12 +47,6 @@ Files
This is a compatibility header for GCC plugins.
It should be always included instead of individual gcc headers.
-**$(src)/scripts/gcc-plugin.sh**
-
- This script checks the availability of the included headers in
- gcc-common.h and chooses the proper host compiler to build the plugins
- (gcc-4.7 can be built by either gcc or g++).
-
**$(src)/scripts/gcc-plugins/gcc-generate-gimple-pass.h,
$(src)/scripts/gcc-plugins/gcc-generate-ipa-pass.h,
$(src)/scripts/gcc-plugins/gcc-generate-simple_ipa-pass.h,
diff --git a/scripts/dummy-tools/gcc b/scripts/dummy-tools/gcc
index 33487e99d83e..a484de576e6f 100755
--- a/scripts/dummy-tools/gcc
+++ b/scripts/dummy-tools/gcc
@@ -74,18 +74,3 @@ if arg_contain -S "$@"; then
exit 0
fi
fi
-
-# For scripts/gcc-plugin.sh
-if arg_contain -print-file-name=plugin "$@"; then
- plugin_dir=$(mktemp -d)
-
- sed -n 's/.*#include "\(.*\)"/\1/p' $(dirname $0)/../gcc-plugins/gcc-common.h |
- while read header
- do
- mkdir -p $plugin_dir/include/$(dirname $header)
- touch $plugin_dir/include/$header
- done
-
- echo $plugin_dir
- exit 0
-fi
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Documentation/Kbuild: Remove references to gcc-plugin.sh
2021-01-22 18:04 [PATCH] Documentation/Kbuild: Remove references to gcc-plugin.sh Robert Karszniewicz
@ 2021-01-22 19:23 ` Kees Cook
2021-01-23 13:17 ` Masahiro Yamada
1 sibling, 0 replies; 4+ messages in thread
From: Kees Cook @ 2021-01-22 19:23 UTC (permalink / raw)
To: Robert Karszniewicz
Cc: Masahiro Yamada, Michal Marek, Jonathan Corbet, Philipp Rudo,
linux-hardening, linux-kbuild, linux-doc, Robert Karszniewicz
On Fri, Jan 22, 2021 at 07:04:13PM +0100, Robert Karszniewicz wrote:
> gcc-plugin.sh has been removed in commit
> 1e860048c53e ("gcc-plugins: simplify GCC plugin-dev capability test").
>
> Signed-off-by: Robert Karszniewicz <r.karszniewicz@phytec.de>
Thanks!
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Documentation/Kbuild: Remove references to gcc-plugin.sh
2021-01-22 18:04 [PATCH] Documentation/Kbuild: Remove references to gcc-plugin.sh Robert Karszniewicz
2021-01-22 19:23 ` Kees Cook
@ 2021-01-23 13:17 ` Masahiro Yamada
2021-01-23 16:40 ` Robert Karszniewicz
1 sibling, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2021-01-23 13:17 UTC (permalink / raw)
To: Robert Karszniewicz
Cc: Kees Cook, Michal Marek, Jonathan Corbet, Philipp Rudo,
linux-hardening, Linux Kbuild mailing list,
open list:DOCUMENTATION, Robert Karszniewicz
On Sat, Jan 23, 2021 at 3:19 AM Robert Karszniewicz
<r.karszniewicz@phytec.de> wrote:
>
> gcc-plugin.sh has been removed in commit
> 1e860048c53e ("gcc-plugins: simplify GCC plugin-dev capability test").
>
> Signed-off-by: Robert Karszniewicz <r.karszniewicz@phytec.de>
> ---
> Documentation/kbuild/gcc-plugins.rst | 6 ------
> scripts/dummy-tools/gcc | 15 ---------------
> 2 files changed, 21 deletions(-)
>
> diff --git a/Documentation/kbuild/gcc-plugins.rst b/Documentation/kbuild/gcc-plugins.rst
> index 4b1c10f88e30..63379d0150e3 100644
> --- a/Documentation/kbuild/gcc-plugins.rst
> +++ b/Documentation/kbuild/gcc-plugins.rst
> @@ -47,12 +47,6 @@ Files
> This is a compatibility header for GCC plugins.
> It should be always included instead of individual gcc headers.
>
> -**$(src)/scripts/gcc-plugin.sh**
> -
> - This script checks the availability of the included headers in
> - gcc-common.h and chooses the proper host compiler to build the plugins
> - (gcc-4.7 can be built by either gcc or g++).
> -
> **$(src)/scripts/gcc-plugins/gcc-generate-gimple-pass.h,
> $(src)/scripts/gcc-plugins/gcc-generate-ipa-pass.h,
> $(src)/scripts/gcc-plugins/gcc-generate-simple_ipa-pass.h,
> diff --git a/scripts/dummy-tools/gcc b/scripts/dummy-tools/gcc
> index 33487e99d83e..a484de576e6f 100755
> --- a/scripts/dummy-tools/gcc
> +++ b/scripts/dummy-tools/gcc
> @@ -74,18 +74,3 @@ if arg_contain -S "$@"; then
> exit 0
> fi
> fi
> -
> -# For scripts/gcc-plugin.sh
> -if arg_contain -print-file-name=plugin "$@"; then
> - plugin_dir=$(mktemp -d)
> -
> - sed -n 's/.*#include "\(.*\)"/\1/p' $(dirname $0)/../gcc-plugins/gcc-common.h |
> - while read header
> - do
> - mkdir -p $plugin_dir/include/$(dirname $header)
> - touch $plugin_dir/include/$header
> - done
> -
> - echo $plugin_dir
> - exit 0
> -fi
Well, it is wrong to remove this hunk entirely.
It would break the ability to enable GCC_PLUGINS.
I will simplify this part.
https://lore.kernel.org/patchwork/patch/1369968/
I took the only change to Documentation/kbuild/gcc-plugins.rst
from your patch but this document contains more stale info.
https://lore.kernel.org/patchwork/patch/1370008/
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Documentation/Kbuild: Remove references to gcc-plugin.sh
2021-01-23 13:17 ` Masahiro Yamada
@ 2021-01-23 16:40 ` Robert Karszniewicz
0 siblings, 0 replies; 4+ messages in thread
From: Robert Karszniewicz @ 2021-01-23 16:40 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Robert Karszniewicz, Kees Cook, Michal Marek, Jonathan Corbet,
Philipp Rudo, linux-hardening, Linux Kbuild mailing list,
open list:DOCUMENTATION
On Sat, Jan 23, 2021 at 10:17:59PM +0900, Masahiro Yamada wrote:
> On Sat, Jan 23, 2021 at 3:19 AM Robert Karszniewicz
> <r.karszniewicz@phytec.de> wrote:
> >
> > gcc-plugin.sh has been removed in commit
> > 1e860048c53e ("gcc-plugins: simplify GCC plugin-dev capability test").
> >
> > Signed-off-by: Robert Karszniewicz <r.karszniewicz@phytec.de>
> > ---
> > Documentation/kbuild/gcc-plugins.rst | 6 ------
> > scripts/dummy-tools/gcc | 15 ---------------
> > 2 files changed, 21 deletions(-)
> >
> > [...]
> > diff --git a/scripts/dummy-tools/gcc b/scripts/dummy-tools/gcc
> > index 33487e99d83e..a484de576e6f 100755
> > --- a/scripts/dummy-tools/gcc
> > +++ b/scripts/dummy-tools/gcc
> > @@ -74,18 +74,3 @@ if arg_contain -S "$@"; then
> > exit 0
> > fi
> > fi
> > -
> > -# For scripts/gcc-plugin.sh
> > -if arg_contain -print-file-name=plugin "$@"; then
> > - plugin_dir=$(mktemp -d)
> > -
> > - sed -n 's/.*#include "\(.*\)"/\1/p' $(dirname $0)/../gcc-plugins/gcc-common.h |
> > - while read header
> > - do
> > - mkdir -p $plugin_dir/include/$(dirname $header)
> > - touch $plugin_dir/include/$header
> > - done
> > -
> > - echo $plugin_dir
> > - exit 0
> > -fi
>
>
> Well, it is wrong to remove this hunk entirely.
> It would break the ability to enable GCC_PLUGINS.
>
> I will simplify this part.
> https://lore.kernel.org/patchwork/patch/1369968/
>
>
> I took the only change to Documentation/kbuild/gcc-plugins.rst
> from your patch but this document contains more stale info.
>
> https://lore.kernel.org/patchwork/patch/1370008/
I see, thanks for letting me know,
Robert
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-23 16:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-22 18:04 [PATCH] Documentation/Kbuild: Remove references to gcc-plugin.sh Robert Karszniewicz
2021-01-22 19:23 ` Kees Cook
2021-01-23 13:17 ` Masahiro Yamada
2021-01-23 16:40 ` Robert Karszniewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).