[PATCH v3 0/5] misc: Add Add Synopsys DesignWare xData IP driver

[PATCH v3 0/5] misc: Add Add Synopsys DesignWare xData IP driver

[Gustavo Pimentel]

This patch series adds a new driver called xData-pcie for the Synopsys
DesignWare PCIe prototype.

The driver configures and enables the Synopsys DesignWare PCIe traffic
generator IP inside of prototype Endpoint which will generate upstream
and downstream PCIe traffic. This allows to quickly test the PCIe link
throughput speed and check is the prototype solution has some limitation
or not.

Cc: Derek Kiernan <derek.kiernan@xilinx.com>
Cc: Dragan Cvetic <dragan.cvetic@xilinx.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: linux-pci@vger.kernel.org
Cc: linux-doc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org

Changes:
 V2: Rework driver according to Greg Kroah-Hartman feedback 
 V3: Fixed issues detected while running on 64 bits platforms

Gustavo Pimentel (5):
  misc: Add Synopsys DesignWare xData IP driver
  misc: Add Synopsys DesignWare xData IP driver to Makefile
  misc: Add Synopsys DesignWare xData IP driver to Kconfig
  Documentation: misc-devices: Add Documentation for dw-xdata-pcie
    driver
  MAINTAINERS: Add Synopsys xData IP driver maintainer

 Documentation/misc-devices/dw-xdata-pcie.rst |  40 +++
 MAINTAINERS                                  |   7 +
 drivers/misc/Kconfig                         |  11 +
 drivers/misc/Makefile                        |   1 +
 drivers/misc/dw-xdata-pcie.c                 | 379 +++++++++++++++++++++++++++
 5 files changed, 438 insertions(+)
 create mode 100644 Documentation/misc-devices/dw-xdata-pcie.rst
 create mode 100644 drivers/misc/dw-xdata-pcie.c

-- 
2.7.4

[PATCH v3 4/5] Documentation: misc-devices: Add Documentation for dw-xdata-pcie driver

[Gustavo Pimentel]

Add Documentation for dw-xdata-pcie driver.

Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
---
 Documentation/misc-devices/dw-xdata-pcie.rst | 40 ++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)
 create mode 100644 Documentation/misc-devices/dw-xdata-pcie.rst

diff --git a/Documentation/misc-devices/dw-xdata-pcie.rst b/Documentation/misc-devices/dw-xdata-pcie.rst
new file mode 100644
index 00000000..3af9fad
--- /dev/null
+++ b/Documentation/misc-devices/dw-xdata-pcie.rst
@@ -0,0 +1,40 @@
+.. SPDX-License-Identifier: GPL-2.0
+
+===========================================================================
+Driver for Synopsys DesignWare PCIe traffic generator (also known as xData)
+===========================================================================
+
+This driver should be used as a host-side (Root Complex) driver and Synopsys
+DesignWare prototype that includes this IP.
+
+The "dw-xdata-pcie" driver can be used to enable/disable PCIe traffic
+generator in either direction (mutual exclusion) besides allowing the
+PCIe link performance analysis.
+
+The interaction with this driver is done through the module parameter and
+can be changed in runtime. The driver outputs the requested command state
+information to /var/log/kern.log or dmesg.
+
+Request write TLPs traffic generation - Root Complex to Endpoint direction
+- Command:
+	echo 1 > /sys/kernel/dw-xdata-pcie/write
+
+Get write TLPs traffic link throughput
+- Command:
+        cat /sys/kernel/dw-xdata-pcie/write
+- Output example:
+	204 MB/s
+
+Request read TLPs traffic generation - Endpoint to Root Complex direction:
+- Command:
+	echo 1 > /sys/kernel/dw-xdata-pcie/read
+
+Get read TLPs traffic link throughput
+- Command:
+        cat /sys/kernel/dw-xdata-pcie/read
+- Output example:
+	199 MB/s
+
+Request to stop any current TLP transfer:
+- Command:
+	echo 1 > /sys/kernel/dw-xdata-pcie/stop
-- 
2.7.4

RE: [PATCH v3 0/5] misc: Add Add Synopsys DesignWare xData IP driver

[Gustavo Pimentel]

Just a kindly reminder.

On Thu, Nov 19, 2020 at 9:19:37, Gustavo Pimentel <gustavo@synopsys.com> 
wrote:

> This patch series adds a new driver called xData-pcie for the Synopsys
> DesignWare PCIe prototype.
> 
> The driver configures and enables the Synopsys DesignWare PCIe traffic
> generator IP inside of prototype Endpoint which will generate upstream
> and downstream PCIe traffic. This allows to quickly test the PCIe link
> throughput speed and check is the prototype solution has some limitation
> or not.
> 
> Cc: Derek Kiernan <derek.kiernan@xilinx.com>
> Cc: Dragan Cvetic <dragan.cvetic@xilinx.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: linux-pci@vger.kernel.org
> Cc: linux-doc@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> 
> Changes:
>  V2: Rework driver according to Greg Kroah-Hartman feedback 
>  V3: Fixed issues detected while running on 64 bits platforms
> 
> Gustavo Pimentel (5):
>   misc: Add Synopsys DesignWare xData IP driver
>   misc: Add Synopsys DesignWare xData IP driver to Makefile
>   misc: Add Synopsys DesignWare xData IP driver to Kconfig
>   Documentation: misc-devices: Add Documentation for dw-xdata-pcie
>     driver
>   MAINTAINERS: Add Synopsys xData IP driver maintainer
> 
>  Documentation/misc-devices/dw-xdata-pcie.rst |  40 +++
>  MAINTAINERS                                  |   7 +
>  drivers/misc/Kconfig                         |  11 +
>  drivers/misc/Makefile                        |   1 +
>  drivers/misc/dw-xdata-pcie.c                 | 379 +++++++++++++++++++++++++++
>  5 files changed, 438 insertions(+)
>  create mode 100644 Documentation/misc-devices/dw-xdata-pcie.rst
>  create mode 100644 drivers/misc/dw-xdata-pcie.c
> 
> -- 
> 2.7.4

Re: [PATCH v3 0/5] misc: Add Add Synopsys DesignWare xData IP driver

[Greg Kroah-Hartman]

On Tue, Feb 02, 2021 at 08:51:10AM +0000, Gustavo Pimentel wrote:
> Just a kindly reminder.

reminder of what?

RE: [PATCH v3 0/5] misc: Add Add Synopsys DesignWare xData IP driver

[Gustavo Pimentel]

On Tue, Feb 2, 2021 at 10:11:21, Greg Kroah-Hartman 
<gregkh@linuxfoundation.org> wrote:

> On Tue, Feb 02, 2021 at 08:51:10AM +0000, Gustavo Pimentel wrote:
> > Just a kindly reminder.
> 
> reminder of what?

To review the patch set. I've done the requested modifications, but I 
didn't get any feedback if this patch series is fine or it needs 
something more to have an ACK.

If some feedback was provided, please accept my apologies. My email 
account was having some issues some time ago and I might not have 
received some emails.

-Gustavo

Re: [PATCH v3 0/5] misc: Add Add Synopsys DesignWare xData IP driver

[Greg Kroah-Hartman]

On Tue, Feb 02, 2021 at 10:38:29AM +0000, Gustavo Pimentel wrote:
> On Tue, Feb 2, 2021 at 10:11:21, Greg Kroah-Hartman 
> <gregkh@linuxfoundation.org> wrote:
> 
> > On Tue, Feb 02, 2021 at 08:51:10AM +0000, Gustavo Pimentel wrote:
> > > Just a kindly reminder.
> > 
> > reminder of what?
> 
> To review the patch set. I've done the requested modifications, but I 
> didn't get any feedback if this patch series is fine or it needs 
> something more to have an ACK.

I do not knwo, I don't see anything my my review queue, sorry.

> If some feedback was provided, please accept my apologies. My email 
> account was having some issues some time ago and I might not have 
> received some emails.

Check the archives please, that's what they are there for :)

greg k-h

RE: [PATCH v3 0/5] misc: Add Add Synopsys DesignWare xData IP driver

[Gustavo Pimentel]

On Tue, Feb 2, 2021 at 10:43:3, Greg Kroah-Hartman 
<gregkh@linuxfoundation.org> wrote:

> On Tue, Feb 02, 2021 at 10:38:29AM +0000, Gustavo Pimentel wrote:
> > On Tue, Feb 2, 2021 at 10:11:21, Greg Kroah-Hartman 
> > <gregkh@linuxfoundation.org> wrote:
> > 
> > > On Tue, Feb 02, 2021 at 08:51:10AM +0000, Gustavo Pimentel wrote:
> > > > Just a kindly reminder.
> > > 
> > > reminder of what?
> > 
> > To review the patch set. I've done the requested modifications, but I 
> > didn't get any feedback if this patch series is fine or it needs 
> > something more to have an ACK.
> 
> I do not knwo, I don't see anything my my review queue, sorry.

I've resend the patch series. Let's see if appears now 😊

> 
> > If some feedback was provided, please accept my apologies. My email 
> > account was having some issues some time ago and I might not have 
> > received some emails.
> 
> Check the archives please, that's what they are there for :)

I have just checked, there isn't any feedback besides yours and Arnd 
Bergmann.

Thank you Greg.

-Gustavo

> 
> greg k-h

Re: [PATCH v3 0/5] misc: Add Add Synopsys DesignWare xData IP driver

[Greg Kroah-Hartman]

On Tue, Feb 02, 2021 at 04:58:50PM +0000, Gustavo Pimentel wrote:
> On Tue, Feb 2, 2021 at 10:43:3, Greg Kroah-Hartman 
> <gregkh@linuxfoundation.org> wrote:
> 
> > On Tue, Feb 02, 2021 at 10:38:29AM +0000, Gustavo Pimentel wrote:
> > > On Tue, Feb 2, 2021 at 10:11:21, Greg Kroah-Hartman 
> > > <gregkh@linuxfoundation.org> wrote:
> > > 
> > > > On Tue, Feb 02, 2021 at 08:51:10AM +0000, Gustavo Pimentel wrote:
> > > > > Just a kindly reminder.
> > > > 
> > > > reminder of what?
> > > 
> > > To review the patch set. I've done the requested modifications, but I 
> > > didn't get any feedback if this patch series is fine or it needs 
> > > something more to have an ACK.
> > 
> > I do not knwo, I don't see anything my my review queue, sorry.
> 
> I've resend the patch series. Let's see if appears now 😊
> 
> > 
> > > If some feedback was provided, please accept my apologies. My email 
> > > account was having some issues some time ago and I might not have 
> > > received some emails.
> > 
> > Check the archives please, that's what they are there for :)
> 
> I have just checked, there isn't any feedback besides yours and Arnd 
> Bergmann.

Did you incorporate our review?

greg k-h

RE: [PATCH v3 0/5] misc: Add Add Synopsys DesignWare xData IP driver

[Gustavo Pimentel]

On Tue, Feb 2, 2021 at 17:8:21, Greg Kroah-Hartman 
<gregkh@linuxfoundation.org> wrote:

> On Tue, Feb 02, 2021 at 04:58:50PM +0000, Gustavo Pimentel wrote:
> > On Tue, Feb 2, 2021 at 10:43:3, Greg Kroah-Hartman 
> > <gregkh@linuxfoundation.org> wrote:
> > 
> > > On Tue, Feb 02, 2021 at 10:38:29AM +0000, Gustavo Pimentel wrote:
> > > > On Tue, Feb 2, 2021 at 10:11:21, Greg Kroah-Hartman 
> > > > <gregkh@linuxfoundation.org> wrote:
> > > > 
> > > > > On Tue, Feb 02, 2021 at 08:51:10AM +0000, Gustavo Pimentel wrote:
> > > > > > Just a kindly reminder.
> > > > > 
> > > > > reminder of what?
> > > > 
> > > > To review the patch set. I've done the requested modifications, but I 
> > > > didn't get any feedback if this patch series is fine or it needs 
> > > > something more to have an ACK.
> > > 
> > > I do not knwo, I don't see anything my my review queue, sorry.
> > 
> > I've resend the patch series. Let's see if appears now 😊
> > 
> > > 
> > > > If some feedback was provided, please accept my apologies. My email 
> > > > account was having some issues some time ago and I might not have 
> > > > received some emails.
> > > 
> > > Check the archives please, that's what they are there for :)
> > 
> > I have just checked, there isn't any feedback besides yours and Arnd 
> > Bergmann.
> 
> Did you incorporate our review?

Yes, I did. The driver initially was using the modules parameters, and 
based on your feedback I changed to sysfs using other drivers' 
implementation as a reference. I also the driver structure changed to use 
macros instead of bitfields.

> 
> greg k-h