From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B503C433DB for ; Thu, 25 Feb 2021 00:07:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C495B64F11 for ; Thu, 25 Feb 2021 00:07:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234951AbhBYAHf (ORCPT ); Wed, 24 Feb 2021 19:07:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234831AbhBYAHd (ORCPT ); Wed, 24 Feb 2021 19:07:33 -0500 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE2A6C061756 for ; Wed, 24 Feb 2021 16:06:52 -0800 (PST) Received: by mail-pg1-x535.google.com with SMTP id o63so2608207pgo.6 for ; Wed, 24 Feb 2021 16:06:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=dwsRL0iFuNLsIwlduzLk8A4HpuT+349o+yzvI+GvJGg=; b=FNfLLnAZf2wdLfsTREG5f4CUE90hhdj+9efnR0CcEASFvTBlIxbq2WH8aD66ed0cWP u9dRyt1Oj6/lfDKABYmqQbAGmMmI/X9cRN3qMQgoex1+4N5PBvszos8ZfcL7YE+BQnHc Dh/Dnaa1VnZhDlc8qYhgJFZnCdUpC03FVrogZi77qKJApoq49AGkV+XAN8eOJPhW6uyf Df3zBYK1751kzdlFraymh+st+EgK1j7iViJWlOfxzrePopY3x+EOvXWqZvKzf6XfjChS CLcqOiLshfzlIREJlcF+0l01oRXxU2HSvPTaQejPlLR4yh+2oehsS7SPhi7bE20wq4ax IcIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=dwsRL0iFuNLsIwlduzLk8A4HpuT+349o+yzvI+GvJGg=; b=s0/qJvqU+8E3AN19KI+p2m1M749GgxrxqT5D/G0/PuAmKdse1q2PlxqN3pM/S/HCUt cRXG+j9BalcmiM0WMJqTvepZ8oQ3qzspcP2t1ppezTyznn5Pba+uAtflJmcn1e8jqhdS nKJU+hwgNIVZaK3c/GDofcDZ1IkRVY1l0+IebzjC2ZDKjlzSehRof+Mt8tW1rUmmx98w snQUHWbtpYNSEIxexaMay43jayOTEItlVB+qRYZv7cQM286yF42qXkGpzyNDBRjLyRYX HwlsvGOes9eBjHDxlSS4LRl6qxX2NQR6zuRnJ5knd+lkxN0pKLf94CKB752RpR3/vJUD pgtw== X-Gm-Message-State: AOAM531hZCK88sh/5kf4ocyAG46x9vfbA2xqTxdzz75J4Jk31F6zlC/7 cAiOaBuw6o2YsCp7cG12dQpxAw== X-Google-Smtp-Source: ABdhPJxABfBShq1Krl8qx+eI5WYhSRtbAKRM77ikODQYw8yEC7MAcrpJKJjlocmRf535KdMK+BW8OA== X-Received: by 2002:a63:f202:: with SMTP id v2mr450469pgh.24.1614211610972; Wed, 24 Feb 2021 16:06:50 -0800 (PST) Received: from google.com ([2620:0:1008:10:94bf:1b67:285c:b7ce]) by smtp.gmail.com with ESMTPSA id i7sm3977728pjs.1.2021.02.24.16.06.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 16:06:50 -0800 (PST) Date: Wed, 24 Feb 2021 16:06:44 -0800 From: Vipin Sharma To: Michal =?iso-8859-1?Q?Koutn=FD?= Cc: tj@kernel.org, thomas.lendacky@amd.com, brijesh.singh@amd.com, jon.grimm@amd.com, eric.vantassell@amd.com, pbonzini@redhat.com, hannes@cmpxchg.org, frankja@linux.ibm.com, borntraeger@de.ibm.com, corbet@lwn.net, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, gingell@google.com, rientjes@google.com, dionnaglaze@google.com, kvm@vger.kernel.org, x86@kernel.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC 0/2] cgroup: New misc cgroup controller Message-ID: References: <20210218195549.1696769-1-vipinsh@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Tue, Feb 23, 2021 at 07:24:33PM +0100, Michal Koutný wrote: > Hello. > > On Thu, Feb 18, 2021 at 11:55:47AM -0800, Vipin Sharma wrote: > > This patch is creating a new misc cgroup controller for allocation and > > tracking of resources which are not abstract like other cgroup > > controllers. > Please don't refer to this as "allocation" anywhere, that has a specific > meaning (see Resource Distribution Models in > Documentation/admin-gruide/cgroup-v2.rst). Yeah, it should be "Limits". I will update the text. > > > This controller was initially proposed as encryption_id but after > > the feedbacks, it is now changed to misc cgroup. > > https://lore.kernel.org/lkml/20210108012846.4134815-2-vipinsh@google.com/ > Interesting generalization. I wonder what else could fit under this as > well. (It resembles pids controller on the cover.) > > > Please provide any feedback for this RFC or if it is good for > > merging then I can send a patch for merging. > A new controller is added exposed with v1 attributes. I'm not convinced > it is desirable to change the frozen v1 controllers' API? (And therefore > promote it as well.) This is a very trivial controller. I believe once it becomes public it can be helpful down the line to the v1 users, who cannot use v2 yet, for some simple resource accounting, like us, we have the need for ASIDs accounting in v1 until we move to v2. If the community has strong objection then I can remove v1 support. > > Beware, bikeshedding. The name is very non-descriptive, potentially > suggesting catch-all semantics. It'd deserve a further thought. My idea > would be limit(s) or counter controller. Limit and counter are kind of suggesting the underlying technique for accounting instead of a generic name to denote resource types managed by this controller. One can argue that if top level names are similar to Resource Destribution Model then may be it makes sense to combine resources with similar accounting technique under one controller. I am looking at misc as a controller which is for resources not having proper home in other controllers or not big enough to deserve their own controller. I agree with you coming up with a name which check all boxes of requirements won't be possible. We have discussed name sev cgroup, kvm cgroup, encryption_id cgroup before reaching to an agreement on misc cgroup. I am open to other names if they are better suited for this controller and makes more sense. Thanks Vipin