linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ira Weiny <ira.weiny@intel.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
	Dan Williams <dan.j.williams@intel.com>,
	linux-kernel@vger.kernel.org, Dave Jiang <dave.jiang@intel.com>,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH v2] Documentation/auxiliary_bus: Clarify auxiliary_device creation
Date: Sun, 28 Nov 2021 08:59:19 +0100	[thread overview]
Message-ID: <YaM21w8V46v33VOd@kroah.com> (raw)
In-Reply-To: <20211128053224.GU3538886@iweiny-DESK2.sc.intel.com>

On Sat, Nov 27, 2021 at 09:32:24PM -0800, Ira Weiny wrote:
> On Fri, Nov 26, 2021 at 05:16:54PM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Nov 02, 2021 at 03:53:10PM -0700, ira.weiny@intel.com wrote:
> > > From: Ira Weiny <ira.weiny@intel.com>
> > > 
> > > The documentation for creating an auxiliary device is a 3 step not a 2
> > > step process.  Specifically the requirements of setting the name, id,
> > > dev.release, and dev.parent fields was not clear as a precursor to the '2
> > > step' process documented.
> > > 
> > > Clarify by declaring this a 3 step process starting with setting the
> > > fields of struct auxiliary_device correctly.
> > > 
> > > Also add some sample code and tie the change into the rest of the
> > > documentation.
> > > 
> > > Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> > > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> > > 
> > > ---
> > > Changes from V1:
> > > 	From Jonathan
> > > 		Fix auxiliary spelling
> > > ---
> > >  Documentation/driver-api/auxiliary_bus.rst | 77 +++++++++++++++++-----
> > >  1 file changed, 59 insertions(+), 18 deletions(-)
> > 
> > Can you please resend the whole series, trying to just resend one patch
> > in the middle is horrible for our tools and to try to figure this out.
> 
> Sorry I did not realize this was an issue.  Other maintainers have been ok with
> this because I think B4 works fine with this?
> 
> > 
> > Would you like to have to unwind this?  Please make it simple for
> > maintainers to review and if ok, apply your changes.
> 
> Regardless, I was planning on resending this as part of the c files as you
> requested before.  Did you still want me to make that conversion?

Yes.

> Or I can resend this and make the c conversion as a follow on patch?

That is up to you.


  reply	other threads:[~2021-11-28  8:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-02 21:53 [PATCH 0/3] Improve Auxiliary Device documentation ira.weiny
2021-11-02 21:53 ` [PATCH 1/3] Documentation/auxiliary_bus: Clarify auxiliary_device creation ira.weiny
2021-11-02 22:06   ` Jonathan Corbet
2021-11-02 22:53     ` [PATCH v2] " ira.weiny
2021-11-26 16:16       ` Greg Kroah-Hartman
2021-11-28  5:32         ` Ira Weiny
2021-11-28  7:59           ` Greg Kroah-Hartman [this message]
2021-11-02 21:53 ` [PATCH 2/3] Documentation/auxiliary_bus: Clarify match_name ira.weiny
2021-11-02 21:53 ` [PATCH 3/3] Documentation/auxiliary_bus: Update Auxiliary device lifespan ira.weiny
2021-11-03  7:58 ` [PATCH 0/3] Improve Auxiliary Device documentation Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YaM21w8V46v33VOd@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=corbet@lwn.net \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=ira.weiny@intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).