From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: David Brazdil <dbrazdil@google.com>,
Rob Herring <robh+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Derek Kiernan <derek.kiernan@xilinx.com>,
Dragan Cvetic <dragan.cvetic@xilinx.com>,
Arnd Bergmann <arnd@arndb.de>,
Hans de Goede <hdegoede@redhat.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, Andrew Scull <ascull@google.com>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH v2 2/2] misc: dice: Add driver to forward secrets to userspace
Date: Thu, 9 Dec 2021 21:31:15 +0100 [thread overview]
Message-ID: <YbJnk7elmP4kUZEH@kroah.com> (raw)
In-Reply-To: <20211209193857.GA28088@duo.ucw.cz>
On Thu, Dec 09, 2021 at 08:38:57PM +0100, Pavel Machek wrote:
> Hi!
>
> > > + memzero_explicit(kaddr, dice_rmem->size);
> > > + devm_memunmap(dice_misc.this_device, kaddr);
> >
> > Do you really need to call memzero_explicit()? This isn't "local"
> > memory, if the compiler "optimizes away" a normal call, it would be
> > _VERY_ broken.
>
> For clearing secrets, I believe memzero_explicit is nice
> documentation.
Only if it's really needed please.
next prev parent reply other threads:[~2021-12-09 20:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 15:11 [PATCH v2 0/2] Driver for Open Profile for DICE David Brazdil
2021-12-09 15:11 ` [PATCH v2 1/2] dt-bindings: firmware: Add " David Brazdil
2021-12-09 15:11 ` [PATCH v2 2/2] misc: dice: Add driver to forward secrets to userspace David Brazdil
2021-12-09 15:31 ` Greg Kroah-Hartman
2021-12-09 19:38 ` Pavel Machek
2021-12-09 20:31 ` Greg Kroah-Hartman [this message]
2021-12-10 11:16 ` David Brazdil
2021-12-10 14:39 ` Greg Kroah-Hartman
2021-12-10 15:48 ` David Brazdil
2021-12-10 16:01 ` Greg Kroah-Hartman
2021-12-09 19:48 ` DRM? " Pavel Machek
2021-12-10 12:20 ` David Brazdil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbJnk7elmP4kUZEH@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=ascull@google.com \
--cc=corbet@lwn.net \
--cc=dbrazdil@google.com \
--cc=derek.kiernan@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@xilinx.com \
--cc=hdegoede@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).