From: Alexander Dahl <ada@thorsis.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Florian Eckert <fe@dev.tdt.de>
Subject: Re: [PATCH v1 1/1] docs: process: submitting-patches: Clarify the Reported-by usage
Date: Fri, 28 Jan 2022 10:31:45 +0100 [thread overview]
Message-ID: <YfO37KjTS7B2W2bH@ada.ifak-system.com> (raw)
In-Reply-To: <87o83xrwk9.fsf@meer.lwn.net>
Hello,
Am Thu, Jan 27, 2022 at 09:08:06AM -0700 schrieb Jonathan Corbet:
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
>
> > It's unclear from "Submitting Patches" documentation that Reported-by
> > is not supposed to be used against new features. (It's more clear
> > in the section 5.4 "Patch formatting and changelogs" of the "A guide
> > to the Kernel Development Process", where it suggests that change
> > should fix something existing in the kernel. Clarify the Reported-by
> > usage in the "Submitting Patches".
> >
> > Reported-by: Florian Eckert <fe@dev.tdt.de>
>
> You're sure this added documentation isn't a new feature that shouldn't
> have a Reported-by? :)
>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > Documentation/process/submitting-patches.rst | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
> > index 31ea120ce531..24c1a5565385 100644
> > --- a/Documentation/process/submitting-patches.rst
> > +++ b/Documentation/process/submitting-patches.rst
> > @@ -495,7 +495,8 @@ Using Reported-by:, Tested-by:, Reviewed-by:, Suggested-by: and Fixes:
> > The Reported-by tag gives credit to people who find bugs and report them and it
> > hopefully inspires them to help us again in the future. Please note that if
> > the bug was reported in private, then ask for permission first before using the
> > -Reported-by tag.
> > +Reported-by tag. A new feature can't be reported since there is no code in the
> > +kernel to fix.
>
> How about instead something like "Reported-by is intended for bugs;
> please do not use it to credit feature requests"?
What should be used for feature requests then? Suggested-by? Would it
help to mention it here?
Greets
Alex
next prev parent reply other threads:[~2022-01-28 9:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 15:53 [PATCH v1 1/1] docs: process: submitting-patches: Clarify the Reported-by usage Andy Shevchenko
2022-01-27 16:08 ` Jonathan Corbet
2022-01-27 16:28 ` Andy Shevchenko
2022-01-28 9:31 ` Alexander Dahl [this message]
2022-01-28 13:44 ` Matthew Wilcox
2022-01-31 15:18 ` Johan Hovold
2022-01-31 15:34 ` Andy Shevchenko
2022-01-31 16:47 ` Johan Hovold
2022-01-31 18:16 ` Andy Shevchenko
2022-02-01 8:51 ` Johan Hovold
2022-03-03 9:54 ` Dan Carpenter
2022-03-03 13:27 ` Johan Hovold
2022-03-03 13:51 ` Dan Carpenter
2022-03-03 9:45 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfO37KjTS7B2W2bH@ada.ifak-system.com \
--to=ada@thorsis.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=corbet@lwn.net \
--cc=fe@dev.tdt.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).