From: Andrew Lunn <andrew@lunn.ch>
To: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Cc: netdev@vger.kernel.org, linux-doc@vger.kernel.org,
tobias@waldekranz.com, f.fainelli@gmail.com,
vladimir.oltean@nxp.com, corbet@lwn.net, kuba@kernel.org,
davem@davemloft.net, "Arınç ÜNAL" <arinc.unal@arinc9.com>
Subject: Re: [PATCH net-next] net: dsa: realtek: add compatible strings for RTL8367RB-VB
Date: Tue, 12 Apr 2022 02:18:14 +0200 [thread overview]
Message-ID: <YlTFRqY3pq84Fw1i@lunn.ch> (raw)
In-Reply-To: <20220411210406.21404-1-luizluca@gmail.com>
On Mon, Apr 11, 2022 at 06:04:07PM -0300, Luiz Angelo Daros de Luca wrote:
> RTL8367RB-VB was not mentioned in the compatible table, nor in the
> Kconfig help text.
>
> The driver still detects the variant by itself and ignores which
> compatible string was used to select it. So, any compatible string will
> work for any compatible model.
Meaning the compatible string is pointless, and cannot be trusted. So
yes, you can add it, but don't actually try to use it for anything,
like quirks.
Andrew
next prev parent reply other threads:[~2022-04-12 0:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 21:04 [PATCH net-next] net: dsa: realtek: add compatible strings for RTL8367RB-VB Luiz Angelo Daros de Luca
2022-04-12 0:18 ` Andrew Lunn [this message]
2022-04-12 4:12 ` Luiz Angelo Daros de Luca
2022-04-12 12:43 ` Andrew Lunn
2022-04-12 13:30 ` Alvin Šipraga
2022-04-13 18:29 ` Luiz Angelo Daros de Luca
2022-04-13 18:40 ` Andrew Lunn
2022-04-14 1:40 ` Alvin Šipraga
2022-04-12 10:50 ` Alvin Šipraga
2022-04-13 18:38 ` Luiz Angelo Daros de Luca
2022-04-14 1:45 ` Alvin Šipraga
2022-04-14 2:32 ` Luiz Angelo Daros de Luca
2022-04-14 11:37 ` Alvin Šipraga
2022-04-14 13:48 ` Andrew Lunn
2022-04-15 7:48 ` Luiz Angelo Daros de Luca
2022-04-15 14:35 ` Andrew Lunn
2022-04-16 6:27 ` Luiz Angelo Daros de Luca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlTFRqY3pq84Fw1i@lunn.ch \
--to=andrew@lunn.ch \
--cc=arinc.unal@arinc9.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=luizluca@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tobias@waldekranz.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).