From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14CA6C433F5 for ; Wed, 4 May 2022 08:56:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240562AbiEDJAD (ORCPT ); Wed, 4 May 2022 05:00:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346784AbiEDI7e (ORCPT ); Wed, 4 May 2022 04:59:34 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74B1D286E5 for ; Wed, 4 May 2022 01:53:16 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id g6so1604752ejw.1 for ; Wed, 04 May 2022 01:53:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=FWeYiYf0DMm7V+g21Cbm+9C9Pn1oqo14ZQ670Fj9soM=; b=H3LWFD2SKqhgrKGammVqLPu1+tsxAB77OiaspD7wNyK6giB6LGiCB0egmuFelRz0xd Wwr8iW5bq7rM304cdd3tRii/BntL55bHQGs59Jj+dRjdM5XT8vOzIahu7OZtSg/9zgsA PYg9GxvGp61ZKK8xDG4sWyfqcA89Y++1uLPP0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=FWeYiYf0DMm7V+g21Cbm+9C9Pn1oqo14ZQ670Fj9soM=; b=VvfHza3D5VaKPZb0Gq36PLeHU4sv5zuJUom5wknLXsKFDp3y2mkfuQck3gEl6Itnln bkhvI42ZYDkqFJ0DtnVF4hC82zg97CIZJTOo+UKuPZjTR9GiaSpIEySTaRDYLG2J4CZP gi+XKaNPl7I68mt44Q3GYbJV6SFxqrpJxEv5KbvIjlu2S61AAR8ykcGa8OA6ffg6Q4Ql 0dFQr1/wIw14YiuLQOBstWVe4M2vsBLLvOfu26nzqkzJagwasUKWBNGJK+L3PJPxu18i pwgSvkYwwHEK4fnPNH/u6P/zZ3ON13DNS9uqpSDa0A7pKRZpxdP1PlJwr3m0tQaMQmTg dAeA== X-Gm-Message-State: AOAM532+2f7GhxT5zVpwJJpk1LY37DW0NL8Pxs+qoQ3T9LfYd7MZ2hFH PTSOszpUOJRHZn7K+WEyj0sJEQ== X-Google-Smtp-Source: ABdhPJynePYca4h8hGIO/ma6nS7rL//o7qYPz+d7uodB/VCGwalHggLOksWn/GzUnOuMimdixtbeHg== X-Received: by 2002:a17:907:50a3:b0:6f3:a302:96aa with SMTP id fv35-20020a17090750a300b006f3a30296aamr18975623ejc.2.1651654395002; Wed, 04 May 2022 01:53:15 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id gz21-20020a170907a05500b006f3ef214e3csm5502964ejc.162.2022.05.04.01.53.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 May 2022 01:53:14 -0700 (PDT) Date: Wed, 4 May 2022 10:53:12 +0200 From: Daniel Vetter To: Maxime Ripard Cc: Javier Martinez Canillas , linux-kernel@vger.kernel.org, Thomas Zimmermann , Daniel Vetter , David Airlie , Jonathan Corbet , Maarten Lankhorst , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org Subject: Re: [PATCH] drm/todo: Add entry for using kunit in the subsystem Message-ID: Mail-Followup-To: Maxime Ripard , Javier Martinez Canillas , linux-kernel@vger.kernel.org, Thomas Zimmermann , David Airlie , Jonathan Corbet , Maarten Lankhorst , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org References: <20220504080212.713275-1-javierm@redhat.com> <20220504081030.ky57nenipnif5r2e@houat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220504081030.ky57nenipnif5r2e@houat> X-Operating-System: Linux phenom 5.10.0-8-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Wed, May 04, 2022 at 10:10:30AM +0200, Maxime Ripard wrote: > Hi, > > On Wed, May 04, 2022 at 10:02:12AM +0200, Javier Martinez Canillas wrote: > > The Kernel Unit Testing (KUnit) framework provides a common framework for > > unit tests within the Linux kernel. Having a test suite would allow to > > identify regressions earlier. > > > > Signed-off-by: Javier Martinez Canillas > > --- > > > > Documentation/gpu/todo.rst | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > > index 127e76ee0b2d..10bfb50908d1 100644 > > --- a/Documentation/gpu/todo.rst > > +++ b/Documentation/gpu/todo.rst > > @@ -603,6 +603,20 @@ Level: Advanced > > Better Testing > > ============== > > > > +Add unit tests using the Kernel Unit Testing (KUnit) framework > > +-------------------------------------------------------------- > > + > > +The `KUnit `_ > > +provides a common framework for unit tests within the Linux kernel. Having a > > +test suite would allow to identify regressions earlier. > > + > > +A good candidate for the first unit tests are the format-conversion helpers in > > +``drm_format_helper.c``. > > + > > +Contact: Javier Martinez Canillas > > + > > +Level: Intermediate > > Kunit is fairly easy to grasp if you have some knowledge of other unit > testing frameworks already (pytest, cmocka, etc.) > > Another good candidate would be to convert (some ?) selftests to kunit. > I'm not sure the others, but at least test-drm_cmdline_parser should be > fairly easy to convert. All the drm selftest should be good candidates for conversion to kunit. Either way patch is Acked-by: Daniel Vetter Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch