Re: [PATCH 1/4] dt-bindings: net: add bitfield defines for Ethernet speeds

Re: [PATCH 1/4] dt-bindings: net: add bitfield defines for Ethernet speeds

[Rafał Miłecki]

On 3.05.2022 17:36, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> This allows specifying multiple Ethernet speeds in a single DT uint32
> value.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Ansuel please check if my patchset conflicts in any way with your work.

Andrew suggested to combine both but right now I don't see it as
necessary.

I'd still appreciate your review of my work. Such binding may be
required for some hardware controlled LEDs setup too I guess.

Re: [PATCH 1/4] dt-bindings: net: add bitfield defines for Ethernet speeds

[Andrew Lunn]

On Thu, May 05, 2022 at 07:19:41AM +0200, Rafał Miłecki wrote:
> On 3.05.2022 17:36, Rafał Miłecki wrote:
> > From: Rafał Miłecki <rafal@milecki.pl>
> > 
> > This allows specifying multiple Ethernet speeds in a single DT uint32
> > value.
> > 
> > Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> 
> Ansuel please check if my patchset conflicts in any way with your work.
> 
> Andrew suggested to combine both but right now I don't see it as
> necessary.
> 
> I'd still appreciate your review of my work. Such binding may be
> required for some hardware controlled LEDs setup too I guess.

Please look at the LED binding. It is an LED you are trying to
control, so that is the binding you should be using.  How do you
describe this functionality using that binding. Ansuel code will give
you the framework to actually do the implementation within.

    Andrew

Re: [PATCH 1/4] dt-bindings: net: add bitfield defines for Ethernet speeds

[Rafał Miłecki]

I don't understand anything from below, I'm sorry. Could you clarify,
please?

On 5.05.2022 14:17, Andrew Lunn wrote:
> On Thu, May 05, 2022 at 07:19:41AM +0200, Rafał Miłecki wrote:
>> On 3.05.2022 17:36, Rafał Miłecki wrote:
>>> From: Rafał Miłecki <rafal@milecki.pl>
>>>
>>> This allows specifying multiple Ethernet speeds in a single DT uint32
>>> value.
>>>
>>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>>
>> Ansuel please check if my patchset conflicts in any way with your work.
>>
>> Andrew suggested to combine both but right now I don't see it as
>> necessary.
>>
>> I'd still appreciate your review of my work. Such binding may be
>> required for some hardware controlled LEDs setup too I guess.


 > Please look at the LED binding.

My binding or Ansuel's binding?


 > It is an LED you are trying to control, so that is the binding you should be using.

Well, of course, LED setup requires DT binding.


 > How do you describe this functionality using that binding.

I allow describing trigger source network device by using
"trigger-sources" property referencing network device. That is an
extension or what we already use for describing USB port that are
trigger sources.


 > Ansuel code will give you the framework to actually do the implementation within.

I was planning to base my work on top of Ansuel's one. I'll send proof
on concept meanwhile without asking for it to be applied.

Re: [PATCH 1/4] dt-bindings: net: add bitfield defines for Ethernet speeds

[Andrew Lunn]

> > Please look at the LED binding.
> 
> My binding or Ansuel's binding?

Ansuels binding is using the LED binding.

> I was planning to base my work on top of Ansuel's one. I'll send proof
> on concept meanwhile without asking for it to be applied.

Great. The more testing Ansuel work gets the better.

	Thanks
		Andrew