From: Michal Hocko <mhocko@suse.com>
To: Vaibhav Jain <vaibhav@linux.ibm.com>
Cc: cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Jonathan Corbet <corbet@lwn.net>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
Shakeel Butt <shakeelb@google.com>,
Yosry Ahmed <yosryahmed@google.com>
Subject: Re: [PATCH] memcg: provide reclaim stats via 'memory.reclaim'
Date: Thu, 19 May 2022 13:02:58 +0200 [thread overview]
Message-ID: <YoYj4sLJfGke5IGT@dhcp22.suse.cz> (raw)
In-Reply-To: <20220518223815.809858-1-vaibhav@linux.ibm.com>
On Thu 19-05-22 04:08:15, Vaibhav Jain wrote:
> [1] Provides a way for user-space to trigger proactive reclaim by introducing
> a write-only memcg file 'memory.reclaim'. However reclaim stats like number
> of pages scanned and reclaimed is still not directly available to the
> user-space.
>
> This patch proposes to extend [1] to make the memcg file 'memory.reclaim'
> readable which returns the number of pages scanned / reclaimed during the
> reclaim process from 'struct vmpressure' associated with each memcg. This should
> let user-space asses how successful proactive reclaim triggered from memcg
> 'memory.reclaim' was ?
>
> With the patch following command flow is expected:
>
> # echo "1M" > memory.reclaim
>
> # cat memory.reclaim
> scanned 76
> reclaimed 32
Why cannot you use memory.stat? Sure it would require to iterate over
the reclaimed hierarchy but the information about scanned and reclaimed
pages as well as other potentially useful stats is there.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2022-05-19 11:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 22:38 [PATCH] memcg: provide reclaim stats via 'memory.reclaim' Vaibhav Jain
2022-05-18 22:46 ` Yosry Ahmed
2022-05-19 8:50 ` Vaibhav Jain
2022-05-19 18:22 ` Yosry Ahmed
2022-05-19 5:08 ` Shakeel Butt
2022-05-19 9:41 ` Vaibhav Jain
2022-05-19 7:59 ` Greg Thelen
2022-05-19 9:56 ` Vaibhav Jain
2022-05-19 11:02 ` Michal Hocko [this message]
2022-05-20 5:15 ` Vaibhav Jain
2022-05-20 7:29 ` Michal Hocko
2022-05-23 22:50 ` Yosry Ahmed
2022-05-24 11:45 ` Johannes Weiner
2022-05-24 19:01 ` Yosry Ahmed
2022-05-25 8:59 ` Michal Hocko
2022-05-25 20:31 ` Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoYj4sLJfGke5IGT@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=hannes@cmpxchg.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=shakeelb@google.com \
--cc=tj@kernel.org \
--cc=vaibhav@linux.ibm.com \
--cc=vdavydov.dev@gmail.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).