From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF973C433EF for ; Fri, 3 Jun 2022 15:39:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245331AbiFCPjE (ORCPT ); Fri, 3 Jun 2022 11:39:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239078AbiFCPjE (ORCPT ); Fri, 3 Jun 2022 11:39:04 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B2392B274 for ; Fri, 3 Jun 2022 08:39:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=pOPlBSiQmc9RMgazWprQ7xWrfrQ7quspunXp4spezqc=; b=ZjPlMlrTsl/oRY1AuXM9/QgYPp GYIoqeNQP99Nog4A0Hy+7vUlz24nykUjVNu8l92c1TtrVLCdGN71wnHEH+7VBY4X2hpX+k7fRzlc0 A4wvGOKs5zNGFqtRzSTMZjvtkfG7AOwKbZLWL4LwwCkONt6/QpX+W5a1JhThFBIxenAR/gR1NgB/w Q5asUkcvKvF+05NBoYfkL7pl5MgUBH/4YdxQ4Et2dfBxsJAVrGzaRhE+v4GLbVnF7s5AsgrOcEtJd mCdkZUydUxc3vpY4t5Krzs0+YichIGsLl9Q3gUMIx5Hn6nDZJ3rgqKM8fChB/RwmLBpyGEeYs6X0v xoDoS+Jg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nx9O5-007ymt-6e; Fri, 03 Jun 2022 15:38:57 +0000 Date: Fri, 3 Jun 2022 16:38:57 +0100 From: Matthew Wilcox To: Adam Turner Cc: Jonathan Corbet , "linux-doc@vger.kernel.org" , Konstantin Ryabitsev Subject: Re: Sphinx pre v3 -- removing support Message-ID: References: <877d5xx1xo.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Fri, Jun 03, 2022 at 03:30:29PM +0000, Adam Turner wrote: > > There's a bug I've been meaning to track down & report where _some_ links > > are broken when building with the Sphinx natively installed on my system > > (Debian 4.3.2-1). I haven't bothered because (a) life is short and (b) > > it's not affecting the kernel.org build. If we're going to ask > > kernel.org to move to a newer version of Sphinx, we should make sure > > that the links won't be broken on whatever version we pick. > > > An example: > > void *kmap_local_folio(struct folio *folio, size_t offset)
> > > Other than that being a big pile of html, that around 'folio' > > should be a link to struct folio and not back to the c.kmap_local_folio > > anchor. > > > I appreciate this is not a great bug report, but I find the entire > > build system beyond my comprehension. > > Do you have the reST source behind this rendered HTML? I can then try > and find a minimal reproducer and see if we can fix within Sphinx. Alas, I don't. I don't even know if this is a Sphinx bug or if it's a bug in one of the kernel addons. It's generated by scripts/kernel-doc from: /** * kmap_local_folio - Map a page in this folio for temporary usage * @folio: The folio containing the page. * @offset: The byte offset within the folio which identifies the page. * ... */ static inline void *kmap_local_folio(struct folio *folio, size_t offset); I see an intermediate file in Documentation/output/_sources/vm/highmem.rst.txt but that doesn't include the output from scripts/kernel-doc. This is why I've been reluctant to report it; I lack enough understanding to be useful :-(