linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Adam Turner <aaturnerpython@outlook.com>
Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
	Jonathan Corbet <corbet@lwn.net>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: Re: Sphinx pre v3 -- removing support
Date: Mon, 13 Jun 2022 17:19:57 +0100	[thread overview]
Message-ID: <YqdjrTKV77OycnQt@casper.infradead.org> (raw)
In-Reply-To: <LO3P123MB2681B5638A09A83208095DCDC2AB9@LO3P123MB2681.GBRP123.PROD.OUTLOOK.COM>

On Mon, Jun 13, 2022 at 04:16:12PM +0000, Adam Turner wrote:
> > Can confirm the bug I mentioned is now present on at least
> > https://www.kernel.org/doc/html/latest/core-api/mm-api.html#c.folio_add_wait_queue
> 
> > What should be the link to 'struct folio' is instead a link to
> > folio_add_wait_queue.
> 
> >From a skim of the "view source" link, I think it is probably a problem in the kernel-doc directive, offending lines copied below:
> 
> .. code-block:: restructuredtext
> 
>    Filemap
>    -------
> 
>    .. kernel-doc:: mm/filemap.c
>       :export:
> 
> Happy to take a look on the Sphinx side for any regressions we've introduced, though I don't know anything about the kernel's documentation tooling so can't help from that side.

Jon's pretty sure it's our bug,

https://lore.kernel.org/linux-doc/87tu91ieiw.fsf@meer.lwn.net/

Our tooling is an unholy mess of perl and python, so it may take some
time to track down.

  reply	other threads:[~2022-06-13 19:00 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-03 14:13 Sphinx pre v3 -- removing support Adam Turner
2022-06-03 14:21 ` Jonathan Corbet
2022-06-03 14:30   ` Adam Turner
2022-06-03 21:34     ` Jonathan Corbet
2022-06-03 15:22   ` Matthew Wilcox
2022-06-03 15:30     ` Adam Turner
2022-06-03 15:38       ` Matthew Wilcox
2022-06-03 15:42     ` Konstantin Ryabitsev
2022-06-03 16:00       ` Jonathan Corbet
2022-06-03 16:26         ` Konstantin Ryabitsev
2022-06-03 21:50           ` Jonathan Corbet
2022-06-13 15:40             ` Konstantin Ryabitsev
2022-06-13 16:00               ` Matthew Wilcox
2022-06-13 16:16                 ` Adam Turner
2022-06-13 16:19                   ` Matthew Wilcox [this message]
2022-06-03 22:11     ` Jonathan Corbet
2022-06-03 15:05 ` Akira Yokosawa
2022-06-03 15:27   ` Adam Turner
2022-06-03 15:44     ` Jani Nikula
2022-06-03 15:54       ` Adam Turner
2022-06-03 16:36         ` Akira Yokosawa
2022-06-03 19:05           ` Jani Nikula
2022-06-04  8:13             ` Mauro Carvalho Chehab
2022-07-02 11:23     ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YqdjrTKV77OycnQt@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=aaturnerpython@outlook.com \
    --cc=corbet@lwn.net \
    --cc=konstantin@linuxfoundation.org \
    --cc=linux-doc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).