linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
	pabeni@redhat.com, corbet@lwn.net, linux-doc@vger.kernel.org
Subject: Re: [PATCH net 1/3] docs: netdev: document that patch series length limit
Date: Fri, 1 Jul 2022 09:48:30 +0200	[thread overview]
Message-ID: <Yr6mziKdr/rmuTjt@lunn.ch> (raw)
In-Reply-To: <20220630174607.629408-2-kuba@kernel.org>

On Thu, Jun 30, 2022 at 10:46:05AM -0700, Jakub Kicinski wrote:
> We had been asking people to avoid massive patch series but it does
> not appear in the FAQ.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>  Documentation/process/maintainer-netdev.rst | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/process/maintainer-netdev.rst b/Documentation/process/maintainer-netdev.rst
> index c456b5225d66..862b6508fc22 100644
> --- a/Documentation/process/maintainer-netdev.rst
> +++ b/Documentation/process/maintainer-netdev.rst
> @@ -136,6 +136,14 @@ it to the maintainer to figure out what is the most recent and current
>  version that should be applied. If there is any doubt, the maintainer
>  will reply and ask what should be done.
>  
> +How do I divide my work into patches?
> +-------------------------------------
> +
> +Put yourself in the shoes of the reviewer. Each patch is read separately
> +and therefore should constitute a comprehensible step towards your stated
> +goal. Avoid sending series longer than 15 patches, they clog review queue
> +and increase mailing list traffic when re-posted.
> +

Hi Jakub

I think a key concept is, big patch series takes longer to review, so
needs a bigger junk of time allocated to it, so often gets differed
until late. As a result, it will take longer to merge. A small series
can be reviewed in a short time, so Maintainers just do it, allowing
for quicker merging.

    Andrew

  reply	other threads:[~2022-07-01  7:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-30 17:46 [PATCH net 0/3] docs: netdev: document more of our rules Jakub Kicinski
2022-06-30 17:46 ` [PATCH net 1/3] docs: netdev: document that patch series length limit Jakub Kicinski
2022-07-01  7:48   ` Andrew Lunn [this message]
2022-07-01 16:16     ` Jakub Kicinski
2022-06-30 17:46 ` [PATCH net 2/3] docs: netdev: document reverse xmas tree Jakub Kicinski
2022-06-30 17:46 ` [PATCH net 3/3] docs: netdev: add a cheat sheet for the rules Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yr6mziKdr/rmuTjt@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).