From: Tejun Heo <tj@kernel.org>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: Waiman Long <longman@redhat.com>,
Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <guro@fb.com>, Phil Auld <pauld@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Frederic Weisbecker <frederic@kernel.org>,
Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH v11 7/8] cgroup/cpuset: Update description of cpuset.cpus.partition in cgroup-v2.rst
Date: Tue, 28 Jun 2022 04:10:29 +0900 [thread overview]
Message-ID: <YroApRMPV/6zO5I8@mtj.duckdns.org> (raw)
In-Reply-To: <20220614115345.GA6771@blackbody.suse.cz>
Hello,
On Tue, Jun 14, 2022 at 01:53:45PM +0200, Michal Koutný wrote:
> On Mon, Jun 13, 2022 at 08:00:56AM -1000, Tejun Heo <tj@kernel.org> wrote:
> > Yeah, I don't know why this part is different from any other errors that the
> > parent can make.
>
> It's different because a write to parent's cpuset.cpus is independent of
> whether cpuset.cpus of its children are exclusive or not.
> In an extreme case the children may be non-exclusive
>
> parent cpuset.cpus=0-3 // valid partition
> `- child_1 cpuset.cpus=0-1 // invalid partition
> `- child_2 cpuset.cpus=1-2 // invalid partition
>
> but the parent can still be a valid partition (thanks to cpu no. 3 in
> the example above).
>
> Do I miss anything?
What I'm trying to say is that cpuset.cpus of child_1 and child_2 are
owned by the parent, so a feature which blocks siblings from
intersecting each other doesn't make whole lot of sense because all
those files are under the control of the parent who would have the
power to enable or disable the restrition anyway.
The partition mode file is owned by the parent too, right? So, all
these are to be configured by the same entity and the errors can be
reported the same way, no?
Thanks.
--
tejun
next prev parent reply other threads:[~2022-06-27 19:10 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 15:34 [PATCH v11 0/8] cgroup/cpuset: cpu partition code enhancements Waiman Long
2022-05-10 15:34 ` [PATCH v11 1/8] cgroup/cpuset: Add top_cpuset check in update_tasks_cpumask() Waiman Long
2022-05-10 15:34 ` [PATCH v11 2/8] cgroup/cpuset: Miscellaneous cleanups & add helper functions Waiman Long
2022-05-10 15:34 ` [PATCH v11 3/8] cgroup/cpuset: Allow no-task partition to have empty cpuset.cpus.effective Waiman Long
2022-06-12 17:40 ` Tejun Heo
2022-06-12 17:41 ` Tejun Heo
2022-06-13 2:53 ` Waiman Long
2022-06-13 2:55 ` Tejun Heo
2022-06-13 3:04 ` Waiman Long
2022-06-13 14:02 ` Michal Koutný
2022-06-13 16:47 ` Waiman Long
2022-06-13 17:23 ` Tejun Heo
2022-06-13 2:50 ` Waiman Long
2022-05-10 15:34 ` [PATCH v11 4/8] cgroup/cpuset: Relax constraints to partition & cpus changes Waiman Long
2022-05-10 15:34 ` [PATCH v11 5/8] cgroup/cpuset: Add a new isolated cpus.partition type Waiman Long
2022-05-10 15:34 ` [PATCH v11 6/8] cgroup/cpuset: Show invalid partition reason string Waiman Long
2022-05-10 15:34 ` [PATCH v11 7/8] cgroup/cpuset: Update description of cpuset.cpus.partition in cgroup-v2.rst Waiman Long
2022-06-12 17:49 ` Tejun Heo
2022-06-13 3:02 ` Waiman Long
2022-06-13 3:12 ` Tejun Heo
2022-06-13 13:18 ` Waiman Long
2022-06-13 17:06 ` Waiman Long
2022-06-13 14:24 ` Michal Koutný
2022-06-13 17:28 ` Tejun Heo
2022-06-13 17:55 ` Michal Koutný
2022-06-13 18:00 ` Tejun Heo
2022-06-14 11:53 ` Michal Koutný
2022-06-27 19:10 ` Tejun Heo [this message]
2022-06-30 14:32 ` Michal Koutný
2022-06-30 22:53 ` Tejun Heo
2022-05-10 15:34 ` [PATCH v11 8/8] kselftest/cgroup: Add cpuset v2 partition root state test Waiman Long
2022-05-21 10:24 ` Muhammad Usama Anjum
2022-05-22 2:40 ` Waiman Long
2022-05-20 16:00 ` [PATCH v11 0/8] cgroup/cpuset: cpu partition code enhancements Sebastian Andrzej Siewior
2022-05-20 16:46 ` Waiman Long
2022-05-24 16:48 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YroApRMPV/6zO5I8@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=frederic@kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=juri.lelli@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=mkoutny@suse.com \
--cc=mtosatti@redhat.com \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).