* [PATCH] Documentation: ext4: correct the document about superblock
@ 2022-08-14 9:00 JunChao Sun
2022-08-15 9:21 ` Bagas Sanjaya
0 siblings, 1 reply; 6+ messages in thread
From: JunChao Sun @ 2022-08-14 9:00 UTC (permalink / raw)
To: linux-ext4, linux-doc; +Cc: tytso, corbet, JunChao Sun
Correct some questions like this:
s_lastcheck_hi field should be upper 8 bits of the
s_lastcheck field, rather than itself.
Signed-off-by: JunChao Sun <sunjunchao2870@gmail.com>
---
Documentation/filesystems/ext4/super.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/filesystems/ext4/super.rst b/Documentation/filesystems/ext4/super.rst
index 268888522e35..0152888cac29 100644
--- a/Documentation/filesystems/ext4/super.rst
+++ b/Documentation/filesystems/ext4/super.rst
@@ -456,15 +456,15 @@ The ext4 superblock is laid out as follows in
* - 0x277
- __u8
- s_lastcheck_hi
- - Upper 8 bits of the s_lastcheck_hi field.
+ - Upper 8 bits of the s_lastcheck field.
* - 0x278
- __u8
- s_first_error_time_hi
- - Upper 8 bits of the s_first_error_time_hi field.
+ - Upper 8 bits of the s_first_error_time field.
* - 0x279
- __u8
- s_last_error_time_hi
- - Upper 8 bits of the s_last_error_time_hi field.
+ - Upper 8 bits of the s_last_error_time field.
* - 0x27A
- __u8
- s_pad[2]
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Documentation: ext4: correct the document about superblock
2022-08-14 9:00 [PATCH] Documentation: ext4: correct the document about superblock JunChao Sun
@ 2022-08-15 9:21 ` Bagas Sanjaya
2022-08-15 12:37 ` JunChao Sun
0 siblings, 1 reply; 6+ messages in thread
From: Bagas Sanjaya @ 2022-08-15 9:21 UTC (permalink / raw)
To: JunChao Sun; +Cc: linux-ext4, linux-doc, tytso, corbet
[-- Attachment #1: Type: text/plain, Size: 1488 bytes --]
On Sun, Aug 14, 2022 at 02:00:16AM -0700, JunChao Sun wrote:
> Correct some questions like this:
> s_lastcheck_hi field should be upper 8 bits of the
> s_lastcheck field, rather than itself.
>
> diff --git a/Documentation/filesystems/ext4/super.rst b/Documentation/filesystems/ext4/super.rst
> index 268888522e35..0152888cac29 100644
> --- a/Documentation/filesystems/ext4/super.rst
> +++ b/Documentation/filesystems/ext4/super.rst
> @@ -456,15 +456,15 @@ The ext4 superblock is laid out as follows in
> * - 0x277
> - __u8
> - s_lastcheck_hi
> - - Upper 8 bits of the s_lastcheck_hi field.
> + - Upper 8 bits of the s_lastcheck field.
> * - 0x278
> - __u8
> - s_first_error_time_hi
> - - Upper 8 bits of the s_first_error_time_hi field.
> + - Upper 8 bits of the s_first_error_time field.
> * - 0x279
> - __u8
> - s_last_error_time_hi
> - - Upper 8 bits of the s_last_error_time_hi field.
> + - Upper 8 bits of the s_last_error_time field.
> * - 0x27A
> - __u8
> - s_pad[2]
The diff looks OK, but the description should be:
"The description of s_lastcheck_hi, s_first_error_time_hi, and
s_last_error_time_hi fields refer to themselves, while these means
referring to upper 8 bits (byte) of corresponding fields (s_lastcheck,
s_first_error_time, and s_last_error_time). Correct the mistake."
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Documentation: ext4: correct the document about superblock
2022-08-15 9:21 ` Bagas Sanjaya
@ 2022-08-15 12:37 ` JunChao Sun
0 siblings, 0 replies; 6+ messages in thread
From: JunChao Sun @ 2022-08-15 12:37 UTC (permalink / raw)
To: Bagas Sanjaya; +Cc: linux-ext4, linux-doc, tytso, corbet
Thanks for your suggestions, I will send patchv2.
On Mon, Aug 15, 2022 at 5:21 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
> On Sun, Aug 14, 2022 at 02:00:16AM -0700, JunChao Sun wrote:
> > Correct some questions like this:
> > s_lastcheck_hi field should be upper 8 bits of the
> > s_lastcheck field, rather than itself.
> >
> > diff --git a/Documentation/filesystems/ext4/super.rst b/Documentation/filesystems/ext4/super.rst
> > index 268888522e35..0152888cac29 100644
> > --- a/Documentation/filesystems/ext4/super.rst
> > +++ b/Documentation/filesystems/ext4/super.rst
> > @@ -456,15 +456,15 @@ The ext4 superblock is laid out as follows in
> > * - 0x277
> > - __u8
> > - s_lastcheck_hi
> > - - Upper 8 bits of the s_lastcheck_hi field.
> > + - Upper 8 bits of the s_lastcheck field.
> > * - 0x278
> > - __u8
> > - s_first_error_time_hi
> > - - Upper 8 bits of the s_first_error_time_hi field.
> > + - Upper 8 bits of the s_first_error_time field.
> > * - 0x279
> > - __u8
> > - s_last_error_time_hi
> > - - Upper 8 bits of the s_last_error_time_hi field.
> > + - Upper 8 bits of the s_last_error_time field.
> > * - 0x27A
> > - __u8
> > - s_pad[2]
>
> The diff looks OK, but the description should be:
> "The description of s_lastcheck_hi, s_first_error_time_hi, and
> s_last_error_time_hi fields refer to themselves, while these means
> referring to upper 8 bits (byte) of corresponding fields (s_lastcheck,
> s_first_error_time, and s_last_error_time). Correct the mistake."
>
> Thanks.
>
> --
> An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] Documentation: ext4: correct the document about superblock
@ 2022-08-15 12:52 JunChao Sun
2022-08-15 14:24 ` Darrick J. Wong
2022-08-29 16:26 ` Jonathan Corbet
0 siblings, 2 replies; 6+ messages in thread
From: JunChao Sun @ 2022-08-15 12:52 UTC (permalink / raw)
To: linux-ext4, linux-doc; +Cc: tytso, corbet, bagasdotme, JunChao Sun
The description of s_lastcheck_hi, s_first_error_time_hi, and
s_last_error_time_hi fields refer to themselves, while these means
referring to upper 8 bits (byte) of corresponding fields (s_lastcheck,
s_first_error_time, and s_last_error_time). Correct the mistake.
Signed-off-by: JunChao Sun <sunjunchao2870@gmail.com>
---
Documentation/filesystems/ext4/super.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/filesystems/ext4/super.rst b/Documentation/filesystems/ext4/super.rst
index 268888522e35..0152888cac29 100644
--- a/Documentation/filesystems/ext4/super.rst
+++ b/Documentation/filesystems/ext4/super.rst
@@ -456,15 +456,15 @@ The ext4 superblock is laid out as follows in
* - 0x277
- __u8
- s_lastcheck_hi
- - Upper 8 bits of the s_lastcheck_hi field.
+ - Upper 8 bits of the s_lastcheck field.
* - 0x278
- __u8
- s_first_error_time_hi
- - Upper 8 bits of the s_first_error_time_hi field.
+ - Upper 8 bits of the s_first_error_time field.
* - 0x279
- __u8
- s_last_error_time_hi
- - Upper 8 bits of the s_last_error_time_hi field.
+ - Upper 8 bits of the s_last_error_time field.
* - 0x27A
- __u8
- s_pad[2]
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Documentation: ext4: correct the document about superblock
2022-08-15 12:52 JunChao Sun
@ 2022-08-15 14:24 ` Darrick J. Wong
2022-08-29 16:26 ` Jonathan Corbet
1 sibling, 0 replies; 6+ messages in thread
From: Darrick J. Wong @ 2022-08-15 14:24 UTC (permalink / raw)
To: JunChao Sun; +Cc: linux-ext4, linux-doc, tytso, corbet, bagasdotme
On Mon, Aug 15, 2022 at 05:52:33AM -0700, JunChao Sun wrote:
> The description of s_lastcheck_hi, s_first_error_time_hi, and
> s_last_error_time_hi fields refer to themselves, while these means
> referring to upper 8 bits (byte) of corresponding fields (s_lastcheck,
> s_first_error_time, and s_last_error_time). Correct the mistake.
>
> Signed-off-by: JunChao Sun <sunjunchao2870@gmail.com>
Looks ok,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> Documentation/filesystems/ext4/super.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/filesystems/ext4/super.rst b/Documentation/filesystems/ext4/super.rst
> index 268888522e35..0152888cac29 100644
> --- a/Documentation/filesystems/ext4/super.rst
> +++ b/Documentation/filesystems/ext4/super.rst
> @@ -456,15 +456,15 @@ The ext4 superblock is laid out as follows in
> * - 0x277
> - __u8
> - s_lastcheck_hi
> - - Upper 8 bits of the s_lastcheck_hi field.
> + - Upper 8 bits of the s_lastcheck field.
> * - 0x278
> - __u8
> - s_first_error_time_hi
> - - Upper 8 bits of the s_first_error_time_hi field.
> + - Upper 8 bits of the s_first_error_time field.
> * - 0x279
> - __u8
> - s_last_error_time_hi
> - - Upper 8 bits of the s_last_error_time_hi field.
> + - Upper 8 bits of the s_last_error_time field.
> * - 0x27A
> - __u8
> - s_pad[2]
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Documentation: ext4: correct the document about superblock
2022-08-15 12:52 JunChao Sun
2022-08-15 14:24 ` Darrick J. Wong
@ 2022-08-29 16:26 ` Jonathan Corbet
1 sibling, 0 replies; 6+ messages in thread
From: Jonathan Corbet @ 2022-08-29 16:26 UTC (permalink / raw)
To: JunChao Sun, linux-ext4, linux-doc; +Cc: tytso, bagasdotme, JunChao Sun
JunChao Sun <sunjunchao2870@gmail.com> writes:
> The description of s_lastcheck_hi, s_first_error_time_hi, and
> s_last_error_time_hi fields refer to themselves, while these means
> referring to upper 8 bits (byte) of corresponding fields (s_lastcheck,
> s_first_error_time, and s_last_error_time). Correct the mistake.
>
> Signed-off-by: JunChao Sun <sunjunchao2870@gmail.com>
> ---
> Documentation/filesystems/ext4/super.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/filesystems/ext4/super.rst b/Documentation/filesystems/ext4/super.rst
> index 268888522e35..0152888cac29 100644
> --- a/Documentation/filesystems/ext4/super.rst
> +++ b/Documentation/filesystems/ext4/super.rst
> @@ -456,15 +456,15 @@ The ext4 superblock is laid out as follows in
> * - 0x277
> - __u8
> - s_lastcheck_hi
> - - Upper 8 bits of the s_lastcheck_hi field.
> + - Upper 8 bits of the s_lastcheck field.
> * - 0x278
> - __u8
> - s_first_error_time_hi
> - - Upper 8 bits of the s_first_error_time_hi field.
> + - Upper 8 bits of the s_first_error_time field.
> * - 0x279
> - __u8
> - s_last_error_time_hi
> - - Upper 8 bits of the s_last_error_time_hi field.
> + - Upper 8 bits of the s_last_error_time field.
> * - 0x27A
> - __u8
Applied to the docs tree, thanks.
jon
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-08-29 16:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-14 9:00 [PATCH] Documentation: ext4: correct the document about superblock JunChao Sun
2022-08-15 9:21 ` Bagas Sanjaya
2022-08-15 12:37 ` JunChao Sun
-- strict thread matches above, loose matches on Subject: below --
2022-08-15 12:52 JunChao Sun
2022-08-15 14:24 ` Darrick J. Wong
2022-08-29 16:26 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).