From: "Darrick J. Wong" <djwong@kernel.org>
To: JunChao Sun <sunjunchao2870@gmail.com>
Cc: linux-ext4@vger.kernel.org, linux-doc@vger.kernel.org,
tytso@mit.edu, corbet@lwn.net, bagasdotme@gmail.com
Subject: Re: [PATCH] Documentation: ext4: correct the document about superblock
Date: Mon, 15 Aug 2022 07:24:09 -0700 [thread overview]
Message-ID: <YvpXCXAsX+697d9x@magnolia> (raw)
In-Reply-To: <20220815125233.2040-1-sunjunchao2870@gmail.com>
On Mon, Aug 15, 2022 at 05:52:33AM -0700, JunChao Sun wrote:
> The description of s_lastcheck_hi, s_first_error_time_hi, and
> s_last_error_time_hi fields refer to themselves, while these means
> referring to upper 8 bits (byte) of corresponding fields (s_lastcheck,
> s_first_error_time, and s_last_error_time). Correct the mistake.
>
> Signed-off-by: JunChao Sun <sunjunchao2870@gmail.com>
Looks ok,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> Documentation/filesystems/ext4/super.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/filesystems/ext4/super.rst b/Documentation/filesystems/ext4/super.rst
> index 268888522e35..0152888cac29 100644
> --- a/Documentation/filesystems/ext4/super.rst
> +++ b/Documentation/filesystems/ext4/super.rst
> @@ -456,15 +456,15 @@ The ext4 superblock is laid out as follows in
> * - 0x277
> - __u8
> - s_lastcheck_hi
> - - Upper 8 bits of the s_lastcheck_hi field.
> + - Upper 8 bits of the s_lastcheck field.
> * - 0x278
> - __u8
> - s_first_error_time_hi
> - - Upper 8 bits of the s_first_error_time_hi field.
> + - Upper 8 bits of the s_first_error_time field.
> * - 0x279
> - __u8
> - s_last_error_time_hi
> - - Upper 8 bits of the s_last_error_time_hi field.
> + - Upper 8 bits of the s_last_error_time field.
> * - 0x27A
> - __u8
> - s_pad[2]
> --
> 2.17.1
>
next prev parent reply other threads:[~2022-08-15 14:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 12:52 [PATCH] Documentation: ext4: correct the document about superblock JunChao Sun
2022-08-15 14:24 ` Darrick J. Wong [this message]
2022-08-29 16:26 ` Jonathan Corbet
-- strict thread matches above, loose matches on Subject: below --
2022-08-14 9:00 JunChao Sun
2022-08-15 9:21 ` Bagas Sanjaya
2022-08-15 12:37 ` JunChao Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvpXCXAsX+697d9x@magnolia \
--to=djwong@kernel.org \
--cc=bagasdotme@gmail.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=sunjunchao2870@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox