From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE601ECAA24 for ; Thu, 25 Aug 2022 17:17:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241200AbiHYRRm (ORCPT ); Thu, 25 Aug 2022 13:17:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239976AbiHYRRm (ORCPT ); Thu, 25 Aug 2022 13:17:42 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27390BC80C for ; Thu, 25 Aug 2022 10:17:38 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id t5so26948594edc.11 for ; Thu, 25 Aug 2022 10:17:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=jwOz4iT2BQeb7Z52GoBXCVE165vQ/PaiB7E4MX3VOzg=; b=2g15XhRTJVHl3pGrBt7KYB9tODJZNPuo0RKK7aO0xcfwNYoiDa5gNnl9QhBZgRTZH1 wzpGaPDTqYX9h4jpDuvgylUNoOT5Lch3EvX7BL7CkVbuyhm4hktsWJUFfLe8tib4v0Gq 7Mjh3VgV21lcVMlZx06acL/VUPi6ODi2kr4hsmTpzEfwuJdhGtRa+uoNv7nXEudFJyIa iA890Pl9xzrBCOFHHrzOlOLMm3xlPiAqK2MFwaQKkmjwrpdkyiGN38v19lF6PONeoSXg guMjW7r9YLJwuo6i6gLS8hBFDFsrS2G7IU8PFhcG5seKK+gz7LlbLeq6E7UcbagEEWsK LpUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=jwOz4iT2BQeb7Z52GoBXCVE165vQ/PaiB7E4MX3VOzg=; b=1tiD6MGPXS1/GX/BZTX9yRo4vA83Yw6fKrn9Obra6W6B3rXxWf/wNiG5eldu4BIMt/ YhsXHD8C1ntwpuNYUUceP6ZDksbsQjPOB71rsdprexBkpKBCtQ1bGs8tVUrlz1LyQ9VF /r3ti7QKrtIkeTEJl2c/+ly1lgAVDb/g5yQrVPqjmUwAjKwwsS8EZZbb/jM70MA5Mt6b l6/mRZiOMS3Cr2A3WbyVNt0U+pycQOSOWl0lzyh1NpIu6ss3ZGrwqKEV/apXbNB4U5Z9 O+C5CU1K3M21ZkLcFI9euokqNwsP88mDLxefI1f3iiGQqqQAi85gj4yslvY2LSCNjf8T q2XQ== X-Gm-Message-State: ACgBeo1nZ4cU3QSV7+Qh3JSwXCo8AR7vtFMHLkJG7pi9ZBza1IgiVmhl 3ABA1M6fuE7MbEYVRnUiaMj5sCx71kzhmjkPR+w= X-Google-Smtp-Source: AA6agR5P/9xkfx1YPi51kqhMj3rOmY2Bq5S6/Ff26hkK5BgmClbpFYwX6S711CBeYPyYjb/pWEL+Jg== X-Received: by 2002:aa7:c316:0:b0:447:b517:919e with SMTP id l22-20020aa7c316000000b00447b517919emr3251864edq.175.1661447856379; Thu, 25 Aug 2022 10:17:36 -0700 (PDT) Received: from localhost ([2a02:8070:6389:a4c0:2ca9:6d59:782b:fff3]) by smtp.gmail.com with ESMTPSA id h3-20020a056402094300b00445e037345csm22904edz.14.2022.08.25.10.17.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 10:17:36 -0700 (PDT) Date: Thu, 25 Aug 2022 13:17:35 -0400 From: Johannes Weiner To: Chengming Zhou Cc: tj@kernel.org, mkoutny@suse.com, surenb@google.com, mingo@redhat.com, peterz@infradead.org, gregkh@linuxfoundation.org, corbet@lwn.net, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, songmuchun@bytedance.com Subject: Re: [PATCH v4 07/10] sched/psi: add PSI_IRQ to track IRQ/SOFTIRQ pressure Message-ID: References: <20220825164111.29534-1-zhouchengming@bytedance.com> <20220825164111.29534-8-zhouchengming@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220825164111.29534-8-zhouchengming@bytedance.com> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Fri, Aug 26, 2022 at 12:41:08AM +0800, Chengming Zhou wrote: > Now PSI already tracked workload pressure stall information for > CPU, memory and IO. Apart from these, IRQ/SOFTIRQ could have > obvious impact on some workload productivity, such as web service > workload. > > When CONFIG_IRQ_TIME_ACCOUNTING, we can get IRQ/SOFTIRQ delta time > from update_rq_clock_task(), in which we can record that delta > to CPU curr task's cgroups as PSI_IRQ_FULL status. > > Note we don't use PSI_IRQ_SOME since IRQ/SOFTIRQ always happen in > the current task on the CPU, make nothing productive could run > even if it were runnable, so we only use PSI_IRQ_FULL. > > Signed-off-by: Chengming Zhou Acked-by: Johannes Weiner