linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Yixuan Cao <caoyixuan2019@email.szu.edu.cn>,
	akpm@linux-foundation.org, yejiajian2018@email.szu.edu.cn,
	skhan@linuxfoundation.org, akiyks@gmail.com, rppt@kernel.org,
	zhangyinan2019@email.szu.edu.cn, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Documentation/mm/page_owner.rst: update experimental data
Date: Fri, 26 Aug 2022 09:30:46 +0700	[thread overview]
Message-ID: <YwgwVsKYLUq0kbMo@debian.me> (raw)
In-Reply-To: <87ilmgyz34.fsf@meer.lwn.net>

[-- Attachment #1: Type: text/plain, Size: 1732 bytes --]

On Thu, Aug 25, 2022 at 12:09:35PM -0600, Jonathan Corbet wrote:
> >  - Without page owner::
> >  
> >     text    data     bss     dec     hex filename
> > -   48392   2333     644   51369    c8a9 mm/page_alloc.o
> > +   58581   3166     652   62399    f3bf mm/page_alloc.o
> >  
> >  - With page owner::
> >  
> >     text    data     bss     dec     hex filename
> > -   48800   2445     644   51889    cab1 mm/page_alloc.o
> > -   6662     108      29    6799    1a8f mm/page_owner.o
> > -   1025       8       8    1041     411 mm/page_ext.o
> > +   59085   3294     652   63031    f637 mm/page_alloc.o
> > +   7464     125      28    7617    1dc1 mm/page_owner.o
> > +   1396      32       8    1436     59c mm/page_ext.o
> >  
> > -Although, roughly, 8 KB code is added in total, page_alloc.o increase by
> > -520 bytes and less than half of it is in hotpath. Building the kernel with
> > +Although, roughly, 9 KB code is added in total, page_alloc.o increase by
> > +632 bytes and less than half of it is in hotpath. Building the kernel with
> >  page owner and turning it on if needed would be great option to debug
> >  kernel memory problem.
> 
> This seems like a fine patch...but I do have to wonder if it really
> makes sense to maintain this information, which will surely be subject
> to frequent change.  Perhaps the whole thing is better replaced with a
> line saying that enabling page owner adds ~9KB?
> 

The size figure above is from size(1) from binutils, for which the
command is run (maybe) against vmlinux.

So I would like to say "Enabling page owner increases vmlinux size by
several kilobytes."

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2022-08-26  2:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-25 17:29 [PATCH] Documentation/mm/page_owner.rst: update experimental data Yixuan Cao
2022-08-25 18:09 ` Jonathan Corbet
2022-08-26  2:30   ` Bagas Sanjaya [this message]
2022-08-26  4:16     ` Mike Rapoport
2022-10-05  9:10       ` [PATCH v2] Documentation/mm/page_owner.rst: delete frequently changing " Yixuan Cao
2022-10-05  9:32         ` Bagas Sanjaya
2022-10-05 11:38           ` [PATCH v3] " Yixuan Cao
2022-10-05 14:55           ` [PATCH v4] " Yixuan Cao
2022-10-06  1:46             ` Bagas Sanjaya
2022-10-06  4:05               ` [PATCH v5] " Yixuan Cao
2022-10-10 18:54             ` [PATCH v4] " Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YwgwVsKYLUq0kbMo@debian.me \
    --to=bagasdotme@gmail.com \
    --cc=akiyks@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=caoyixuan2019@email.szu.edu.cn \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rppt@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=yejiajian2018@email.szu.edu.cn \
    --cc=zhangyinan2019@email.szu.edu.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).