Linux Documentation
 help / color / mirror / Atom feed
From: Wu XiangCheng <wu.xiangcheng@linux.dev>
To: Zhao Liu <zhao1.liu@linux.intel.com>
Cc: Alex Shi <alexs@kernel.org>, Yanteng Si <siyanteng@loongson.cn>,
	Jonathan Corbet <corbet@lwn.net>, Wu XiangCheng <bobwxc@email.cn>,
	Mike Rapoport <rppt@kernel.org>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ira Weiny <ira.weiny@intel.com>,
	"Fabio M . De Francesco" <fmdefrancesco@gmail.com>,
	Zhenyu Wang <zhenyu.z.wang@intel.com>,
	Zhao Liu <zhao1.liu@intel.com>
Subject: Re: [PATCH] Documentation/zh_CN: add latest kmap_local_page translation
Date: Fri, 2 Sep 2022 18:41:38 +0800	[thread overview]
Message-ID: <YxHd4tjI+OxhALWC@bobwxc.mipc> (raw)
In-Reply-To: <20220902081304.2259706-1-zhao1.liu@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]

Hi Liu,

1. It is better to give this patch a more meaningful name, like:
	update something to 6.0-rc2
   "latest" is too ambiguous.

2022-09-02 (五) 16:13:04 +0800 Zhao Liu 曰:
> From: Zhao Liu <zhao1.liu@intel.com>
> 
> Translate the lastest description of kmap_local_page into Chinese.
> 
> The translation is based on these commits:
> 
> commit 516ea046ec555 ("Documentation/mm: don't kmap*() pages which
> can't come from HIGHMEM")
> 
> commit 6b3afe2eeec27 ("Documentation/mm: avoid invalid use of
> addresses from kmap_local_page()")
> 
> commit 84b86f6054c42 ("Documentation/mm: rrefer kmap_local_page()
> and avoid kmap()")
> 
> commit a9e9c93966afd ("Documentation/mm: add details about
> kmap_local_page() and preemption")
> 

2. Just list the latest commit, that's enough.

> Suggested-by: Ira Weiny <ira.weiny@intel.com>
> Suggested-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>

Please remember above two next time ;)

Anyway,

Reviewed-by: Wu XiangCheng <bobwxc@email.cn>

> ---
> Suggested by credits.
>         Ira: Referred to his task document.
>         Fabio: Referred to his work on the original English document.
> 
> ---
>  .../translations/zh_CN/mm/highmem.rst         | 20 ++++++++++++++++---
>  1 file changed, 17 insertions(+), 3 deletions(-)
> 

Thanks,

-- 
Wu XiangCheng	0x32684A40BCA7AEA7


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  parent reply	other threads:[~2022-09-02 10:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-02  8:13 [PATCH] Documentation/zh_CN: add latest kmap_local_page translation Zhao Liu
2022-09-02  8:27 ` Alex Shi
2022-09-02 10:41 ` Wu XiangCheng [this message]
2022-09-03  7:10 ` YanTeng Si

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YxHd4tjI+OxhALWC@bobwxc.mipc \
    --to=wu.xiangcheng@linux.dev \
    --cc=alexs@kernel.org \
    --cc=bobwxc@email.cn \
    --cc=corbet@lwn.net \
    --cc=fmdefrancesco@gmail.com \
    --cc=ira.weiny@intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rppt@kernel.org \
    --cc=siyanteng@loongson.cn \
    --cc=zhao1.liu@intel.com \
    --cc=zhao1.liu@linux.intel.com \
    --cc=zhenyu.z.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox