From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3510CC4332F for ; Fri, 30 Sep 2022 05:10:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230257AbiI3FKl (ORCPT ); Fri, 30 Sep 2022 01:10:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229713AbiI3FKk (ORCPT ); Fri, 30 Sep 2022 01:10:40 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EC6CE9058; Thu, 29 Sep 2022 22:10:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664514639; x=1696050639; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=jaVg7DcNakCTHSKXrsLVNn/gQgHAGjnRUrdm5AclUcc=; b=PTqxsy+JwBk8150sPgR031qgstGIcsqQcxWrVfYHL+OvjSZrKycmTu3D Yai1DcR2u6F/mP3iyO3Of6rYHMSQHD20wCbiwMdcEwKSyk7muQUevHfNz R2HEGdLf8KbFEp6UoRMjAc9ZxbhFUtK7AYnjH8vuZRGixSMk+6oe//7eW M7tJgSYy1FpzH7Xc4U1FpoCgonvGpMF1noAvdwJLsuGhFsDUBmdavLAfM r7HDVzwQRiOurazm/y+A9RuPEL2ZflJnQV4u8WLu9FBzZ0RQgY861bzfl X6FYcOZLCJnhTfo5pB4jFikk0qs+wGY/LuuIh92RmhlDKmxuqlRAdykqh A==; X-IronPort-AV: E=McAfee;i="6500,9779,10485"; a="302078960" X-IronPort-AV: E=Sophos;i="5.93,357,1654585200"; d="scan'208";a="302078960" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2022 22:10:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10485"; a="726719693" X-IronPort-AV: E=Sophos;i="5.93,357,1654585200"; d="scan'208";a="726719693" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.165]) by fmsmga002.fm.intel.com with ESMTP; 29 Sep 2022 22:10:33 -0700 Date: Fri, 30 Sep 2022 13:01:44 +0800 From: Xu Yilun To: Tom Rix Cc: matthew.gerlach@linux.intel.com, hao.wu@intel.com, russell.h.weight@intel.com, basheer.ahmed.muddebihal@intel.com, mdf@kernel.org, linux-fpga@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, tianfei.zhang@intel.com, corbet@lwn.net, gregkh@linuxfoundation.org, linux-serial@vger.kernel.org, jirislaby@kernel.org, geert+renesas@glider.be, andriy.shevchenko@linux.intel.com, niklas.soderlund+renesas@ragnatech.se, phil.edworthy@renesas.com, macro@orcam.me.uk, johan@kernel.org, lukas@wunner.de, Basheer Ahmed Muddebihal Subject: Re: [PATCH v2 2/6] fpga: dfl: Move the DFH definitions Message-ID: References: <20220923121745.129167-1-matthew.gerlach@linux.intel.com> <20220923121745.129167-3-matthew.gerlach@linux.intel.com> <36342784-34c3-6a08-7cd4-eb185b61061a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <36342784-34c3-6a08-7cd4-eb185b61061a@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 2022-09-24 at 06:00:19 -0700, Tom Rix wrote: > > On 9/23/22 5:17 AM, matthew.gerlach@linux.intel.com wrote: > > From: Basheer Ahmed Muddebihal > > > > Moving the DFH register offset and register definitions from > > drivers/fpga/dfl.h to include/linux/dfl.h. These definitions > > need to be accessed by dfl drivers that are outside of > > drivers/fpga. > > This comment does not match what is done. > > A move, a change in names and the introduction new defines. > > I am not sure if moving these #defines is the best approach, the later use > of the in the uart with FIELD_GET's i think should be wrapped as functions > and these functions exported rather than the #defines. I agree, to play with all domains across kernel, we'd better not expose too much bus specific details. Thanks, Yilun