[PATCH v3 0/2] hwmon: (asus-ec-sensors) add TUF GAMING X670E PLUS

[PATCH v3 0/2] hwmon: (asus-ec-sensors) add TUF GAMING X670E PLUS

[Li XingYang]

this is my mainboard:
dmidecode | grep -A3 "Base Board"
Base Board Information
        Manufacturer: ASUSTeK COMPUTER INC.
        Product Name: TUF GAMING X670E-PLUS
        Version: Rev 1.xx

i use the version of BIOS:
TUF-GAMING-X670E-PLUS-ASUS-3042

asus-ec-sensors show when use this patch:
sensors 'asusec-*'
asusec-isa-0000
Adapter: ISA adapter
CPU_Opt:      914 RPM
CPU:          +39.0°C
CPU Package:  +48.0°C
Motherboard:  +31.0°C
VRM:          +46.0°C
Water_In:     +35.0°C
Water_Out:    +33.0°C

Signed-off-by: Li XingYang <yanhuoguifan@gmail.com>

-- 
Changes in v3:
- Separate AMD 600's support for fanCPuOPT into a separate PATCH
- Sort TUF GAMING X670E PLUS in alphabetical order
- Link to v2: https://lore.kernel.org/linux-hwmon/20241130133837.24454-1-yanhuoguifan@gmail.com/T/#t

Changes in v2:
- Keep the sorting of TUF GAMING X670E PLUS consistent between the source file and RST files
- Link to v1: https://lore.kernel.org/linux-hwmon/20241130133837.24454-1-yanhuoguifan@gmail.com/T/#t
-- 

Li XingYang (2):
  hwmon: (asus-ec-sensors) AMD 600 motherboard add support for fan cpu
    opt
  hwmon: (asus-ec-sensors) add TUF GAMING X670E PLUS

 Documentation/hwmon/asus_ec_sensors.rst |  1 +
 drivers/hwmon/asus-ec-sensors.c         | 13 +++++++++++++
 2 files changed, 14 insertions(+)

-- 
Best regards,
-- 
Li XingYang <yanhuoguifan@gmail.com>

-- 
2.47.1

[PATCH v3 1/2] hwmon: (asus-ec-sensors) AMD 600 motherboard add support for fan cpu opt

[Li XingYang]

Refer to the LibreHardwareMonitor project, LibreHardwareMonitorLib/
Hardware/Motherboard/Lpc/EC/EmbeddedController.cs file,
fan cpu opt is support by amd600 EC.
the registers are described:
BoardFamily.Amd600, new Dictionary<ECSensor, EmbeddedControllerSource>
{
{ ECSensor.FanCPUOpt,  new EmbeddedControllerSource
("CPU Optional Fan", SensorType.Fan, 0x00b0, 2) },
}

now add the FanCPUOpt support for amd600

Signed-off-by: Li XingYang <yanhuoguifan@gmail.com>
---
 drivers/hwmon/asus-ec-sensors.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
index 9555366aeaf0..381bf117104f 100644
--- a/drivers/hwmon/asus-ec-sensors.c
+++ b/drivers/hwmon/asus-ec-sensors.c
@@ -250,6 +250,8 @@ static const struct ec_sensor_info sensors_family_amd_600[] = {
 		EC_SENSOR("Water_In", hwmon_temp, 1, 0x01, 0x00),
 	[ec_sensor_temp_water_out] =
 		EC_SENSOR("Water_Out", hwmon_temp, 1, 0x01, 0x01),
+	[ec_sensor_fan_cpu_opt] =
+		EC_SENSOR("CPU_Opt", hwmon_fan, 2, 0x00, 0xb0),
 };
 
 static const struct ec_sensor_info sensors_family_intel_300[] = {
-- 
2.47.1

[PATCH v3 2/2] hwmon: (asus-ec-sensors) add TUF GAMING X670E PLUS

[Li XingYang]

add asus-ec-sensors support on the mainboard TUF GAMING X670E PLUS

Signed-off-by: Li XingYang <yanhuoguifan@gmail.com>
---
 Documentation/hwmon/asus_ec_sensors.rst |  1 +
 drivers/hwmon/asus-ec-sensors.c         | 11 +++++++++++
 2 files changed, 12 insertions(+)

diff --git a/Documentation/hwmon/asus_ec_sensors.rst b/Documentation/hwmon/asus_ec_sensors.rst
index ca38922f4ec5..739636cf7994 100644
--- a/Documentation/hwmon/asus_ec_sensors.rst
+++ b/Documentation/hwmon/asus_ec_sensors.rst
@@ -29,6 +29,7 @@ Supported boards:
  * ROG STRIX Z690-A GAMING WIFI D4
  * ROG ZENITH II EXTREME
  * ROG ZENITH II EXTREME ALPHA
+ * TUF GAMING X670E PLUS
 
 Authors:
     - Eugene Shalygin <eugene.shalygin@gmail.com>
diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
index 381bf117104f..43e54dc513da 100644
--- a/drivers/hwmon/asus-ec-sensors.c
+++ b/drivers/hwmon/asus-ec-sensors.c
@@ -479,6 +479,15 @@ static const struct ec_board_info board_info_zenith_ii_extreme = {
 	.family = family_amd_500_series,
 };
 
+static const struct ec_board_info board_info_tuf_gaming_x670e_plus = {
+	.sensors = SENSOR_TEMP_CPU | SENSOR_TEMP_CPU_PACKAGE |
+		SENSOR_TEMP_MB | SENSOR_TEMP_VRM |
+		SENSOR_TEMP_WATER_IN | SENSOR_TEMP_WATER_OUT |
+		SENSOR_FAN_CPU_OPT,
+	.mutex_path = ACPI_GLOBAL_LOCK_PSEUDO_PATH,
+	.family = family_amd_600_series,
+};
+
 #define DMI_EXACT_MATCH_ASUS_BOARD_NAME(name, board_info)                      \
 	{                                                                      \
 		.matches = {                                                   \
@@ -540,6 +549,8 @@ static const struct dmi_system_id dmi_table[] = {
 					&board_info_zenith_ii_extreme),
 	DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG ZENITH II EXTREME ALPHA",
 					&board_info_zenith_ii_extreme),
+	DMI_EXACT_MATCH_ASUS_BOARD_NAME("TUF GAMING X670E-PLUS",
+					&board_info_tuf_gaming_x670e_plus),
 	{},
 };
 
-- 
2.47.1

Re: [PATCH v3 2/2] hwmon: (asus-ec-sensors) add TUF GAMING X670E PLUS

[Li XingYang]

On Sun, Dec 01, 2024 at 11:47:45AM +0800, Li XingYang wrote:

Hi Eugene:

Could you review the new verson patch in free time?

thanks,
XingYang
> add asus-ec-sensors support on the mainboard TUF GAMING X670E PLUS
> 
> Signed-off-by: Li XingYang <yanhuoguifan@gmail.com>
> ---
>  Documentation/hwmon/asus_ec_sensors.rst |  1 +
>  drivers/hwmon/asus-ec-sensors.c         | 11 +++++++++++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/Documentation/hwmon/asus_ec_sensors.rst b/Documentation/hwmon/asus_ec_sensors.rst
> index ca38922f4ec5..739636cf7994 100644
> --- a/Documentation/hwmon/asus_ec_sensors.rst
> +++ b/Documentation/hwmon/asus_ec_sensors.rst
> @@ -29,6 +29,7 @@ Supported boards:
>   * ROG STRIX Z690-A GAMING WIFI D4
>   * ROG ZENITH II EXTREME
>   * ROG ZENITH II EXTREME ALPHA
> + * TUF GAMING X670E PLUS
>  
>  Authors:
>      - Eugene Shalygin <eugene.shalygin@gmail.com>
> diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
> index 381bf117104f..43e54dc513da 100644
> --- a/drivers/hwmon/asus-ec-sensors.c
> +++ b/drivers/hwmon/asus-ec-sensors.c
> @@ -479,6 +479,15 @@ static const struct ec_board_info board_info_zenith_ii_extreme = {
>  	.family = family_amd_500_series,
>  };
>  
> +static const struct ec_board_info board_info_tuf_gaming_x670e_plus = {
> +	.sensors = SENSOR_TEMP_CPU | SENSOR_TEMP_CPU_PACKAGE |
> +		SENSOR_TEMP_MB | SENSOR_TEMP_VRM |
> +		SENSOR_TEMP_WATER_IN | SENSOR_TEMP_WATER_OUT |
> +		SENSOR_FAN_CPU_OPT,
> +	.mutex_path = ACPI_GLOBAL_LOCK_PSEUDO_PATH,
> +	.family = family_amd_600_series,
> +};
> +
>  #define DMI_EXACT_MATCH_ASUS_BOARD_NAME(name, board_info)                      \
>  	{                                                                      \
>  		.matches = {                                                   \
> @@ -540,6 +549,8 @@ static const struct dmi_system_id dmi_table[] = {
>  					&board_info_zenith_ii_extreme),
>  	DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG ZENITH II EXTREME ALPHA",
>  					&board_info_zenith_ii_extreme),
> +	DMI_EXACT_MATCH_ASUS_BOARD_NAME("TUF GAMING X670E-PLUS",
> +					&board_info_tuf_gaming_x670e_plus),
>  	{},
>  };
>  
> -- 
> 2.47.1
> 

Re: [PATCH v3 2/2] hwmon: (asus-ec-sensors) add TUF GAMING X670E PLUS

[Eugene Shalygin]

Hi,

Sorry for the late reply. This patch is OK with me.

Best regards,
Eugene

On Sun, 1 Dec 2024 at 04:48, Li XingYang <yanhuoguifan@gmail.com> wrote:
>
> add asus-ec-sensors support on the mainboard TUF GAMING X670E PLUS
>
> Signed-off-by: Li XingYang <yanhuoguifan@gmail.com>
> ---
>  Documentation/hwmon/asus_ec_sensors.rst |  1 +
>  drivers/hwmon/asus-ec-sensors.c         | 11 +++++++++++
>  2 files changed, 12 insertions(+)
>
> diff --git a/Documentation/hwmon/asus_ec_sensors.rst b/Documentation/hwmon/asus_ec_sensors.rst
> index ca38922f4ec5..739636cf7994 100644
> --- a/Documentation/hwmon/asus_ec_sensors.rst
> +++ b/Documentation/hwmon/asus_ec_sensors.rst
> @@ -29,6 +29,7 @@ Supported boards:
>   * ROG STRIX Z690-A GAMING WIFI D4
>   * ROG ZENITH II EXTREME
>   * ROG ZENITH II EXTREME ALPHA
> + * TUF GAMING X670E PLUS
>
>  Authors:
>      - Eugene Shalygin <eugene.shalygin@gmail.com>
> diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
> index 381bf117104f..43e54dc513da 100644
> --- a/drivers/hwmon/asus-ec-sensors.c
> +++ b/drivers/hwmon/asus-ec-sensors.c
> @@ -479,6 +479,15 @@ static const struct ec_board_info board_info_zenith_ii_extreme = {
>         .family = family_amd_500_series,
>  };
>
> +static const struct ec_board_info board_info_tuf_gaming_x670e_plus = {
> +       .sensors = SENSOR_TEMP_CPU | SENSOR_TEMP_CPU_PACKAGE |
> +               SENSOR_TEMP_MB | SENSOR_TEMP_VRM |
> +               SENSOR_TEMP_WATER_IN | SENSOR_TEMP_WATER_OUT |
> +               SENSOR_FAN_CPU_OPT,
> +       .mutex_path = ACPI_GLOBAL_LOCK_PSEUDO_PATH,
> +       .family = family_amd_600_series,
> +};
> +
>  #define DMI_EXACT_MATCH_ASUS_BOARD_NAME(name, board_info)                      \
>         {                                                                      \
>                 .matches = {                                                   \
> @@ -540,6 +549,8 @@ static const struct dmi_system_id dmi_table[] = {
>                                         &board_info_zenith_ii_extreme),
>         DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG ZENITH II EXTREME ALPHA",
>                                         &board_info_zenith_ii_extreme),
> +       DMI_EXACT_MATCH_ASUS_BOARD_NAME("TUF GAMING X670E-PLUS",
> +                                       &board_info_tuf_gaming_x670e_plus),
>         {},
>  };
>
> --
> 2.47.1
>

Re: [PATCH v3 1/2] hwmon: (asus-ec-sensors) AMD 600 motherboard add support for fan cpu opt

[Eugene Shalygin]

LGTM.

Best Regards,
Eugene

On Sun, 1 Dec 2024 at 04:48, Li XingYang <yanhuoguifan@gmail.com> wrote:
>
> Refer to the LibreHardwareMonitor project, LibreHardwareMonitorLib/
> Hardware/Motherboard/Lpc/EC/EmbeddedController.cs file,
> fan cpu opt is support by amd600 EC.
> the registers are described:
> BoardFamily.Amd600, new Dictionary<ECSensor, EmbeddedControllerSource>
> {
> { ECSensor.FanCPUOpt,  new EmbeddedControllerSource
> ("CPU Optional Fan", SensorType.Fan, 0x00b0, 2) },
> }
>
> now add the FanCPUOpt support for amd600
>
> Signed-off-by: Li XingYang <yanhuoguifan@gmail.com>
> ---
>  drivers/hwmon/asus-ec-sensors.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
> index 9555366aeaf0..381bf117104f 100644
> --- a/drivers/hwmon/asus-ec-sensors.c
> +++ b/drivers/hwmon/asus-ec-sensors.c
> @@ -250,6 +250,8 @@ static const struct ec_sensor_info sensors_family_amd_600[] = {
>                 EC_SENSOR("Water_In", hwmon_temp, 1, 0x01, 0x00),
>         [ec_sensor_temp_water_out] =
>                 EC_SENSOR("Water_Out", hwmon_temp, 1, 0x01, 0x01),
> +       [ec_sensor_fan_cpu_opt] =
> +               EC_SENSOR("CPU_Opt", hwmon_fan, 2, 0x00, 0xb0),
>  };
>
>  static const struct ec_sensor_info sensors_family_intel_300[] = {
> --
> 2.47.1
>

Re: [PATCH v3 2/2] hwmon: (asus-ec-sensors) add TUF GAMING X670E PLUS

[Guenter Roeck]

On 12/4/24 03:31, Eugene Shalygin wrote:
> Hi,
> 
> Sorry for the late reply. This patch is OK with me.
> 

A Reviewed-by: tag would have been helpful.

Guenter

> Best regards,
> Eugene
> 
> On Sun, 1 Dec 2024 at 04:48, Li XingYang <yanhuoguifan@gmail.com> wrote:
>>
>> add asus-ec-sensors support on the mainboard TUF GAMING X670E PLUS
>>
>> Signed-off-by: Li XingYang <yanhuoguifan@gmail.com>
>> ---
>>   Documentation/hwmon/asus_ec_sensors.rst |  1 +
>>   drivers/hwmon/asus-ec-sensors.c         | 11 +++++++++++
>>   2 files changed, 12 insertions(+)
>>
>> diff --git a/Documentation/hwmon/asus_ec_sensors.rst b/Documentation/hwmon/asus_ec_sensors.rst
>> index ca38922f4ec5..739636cf7994 100644
>> --- a/Documentation/hwmon/asus_ec_sensors.rst
>> +++ b/Documentation/hwmon/asus_ec_sensors.rst
>> @@ -29,6 +29,7 @@ Supported boards:
>>    * ROG STRIX Z690-A GAMING WIFI D4
>>    * ROG ZENITH II EXTREME
>>    * ROG ZENITH II EXTREME ALPHA
>> + * TUF GAMING X670E PLUS
>>
>>   Authors:
>>       - Eugene Shalygin <eugene.shalygin@gmail.com>
>> diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
>> index 381bf117104f..43e54dc513da 100644
>> --- a/drivers/hwmon/asus-ec-sensors.c
>> +++ b/drivers/hwmon/asus-ec-sensors.c
>> @@ -479,6 +479,15 @@ static const struct ec_board_info board_info_zenith_ii_extreme = {
>>          .family = family_amd_500_series,
>>   };
>>
>> +static const struct ec_board_info board_info_tuf_gaming_x670e_plus = {
>> +       .sensors = SENSOR_TEMP_CPU | SENSOR_TEMP_CPU_PACKAGE |
>> +               SENSOR_TEMP_MB | SENSOR_TEMP_VRM |
>> +               SENSOR_TEMP_WATER_IN | SENSOR_TEMP_WATER_OUT |
>> +               SENSOR_FAN_CPU_OPT,
>> +       .mutex_path = ACPI_GLOBAL_LOCK_PSEUDO_PATH,
>> +       .family = family_amd_600_series,
>> +};
>> +
>>   #define DMI_EXACT_MATCH_ASUS_BOARD_NAME(name, board_info)                      \
>>          {                                                                      \
>>                  .matches = {                                                   \
>> @@ -540,6 +549,8 @@ static const struct dmi_system_id dmi_table[] = {
>>                                          &board_info_zenith_ii_extreme),
>>          DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG ZENITH II EXTREME ALPHA",
>>                                          &board_info_zenith_ii_extreme),
>> +       DMI_EXACT_MATCH_ASUS_BOARD_NAME("TUF GAMING X670E-PLUS",
>> +                                       &board_info_tuf_gaming_x670e_plus),
>>          {},
>>   };
>>
>> --
>> 2.47.1
>>
> 

Re: [PATCH v3 1/2] hwmon: (asus-ec-sensors) AMD 600 motherboard add support for fan cpu opt

[Guenter Roeck]

On Sun, Dec 01, 2024 at 11:47:44AM +0800, Li XingYang wrote:
> Refer to the LibreHardwareMonitor project, LibreHardwareMonitorLib/
> Hardware/Motherboard/Lpc/EC/EmbeddedController.cs file,
> fan cpu opt is support by amd600 EC.
> the registers are described:
> BoardFamily.Amd600, new Dictionary<ECSensor, EmbeddedControllerSource>
> {
> { ECSensor.FanCPUOpt,  new EmbeddedControllerSource
> ("CPU Optional Fan", SensorType.Fan, 0x00b0, 2) },
> }
> 
> now add the FanCPUOpt support for amd600
> 
> Signed-off-by: Li XingYang <yanhuoguifan@gmail.com>

Applied.

Thanks,
Guenter

Re: [PATCH v3 2/2] hwmon: (asus-ec-sensors) add TUF GAMING X670E PLUS

[Guenter Roeck]

On Sun, Dec 01, 2024 at 11:47:45AM +0800, Li XingYang wrote:
> add asus-ec-sensors support on the mainboard TUF GAMING X670E PLUS
> 
> Signed-off-by: Li XingYang <yanhuoguifan@gmail.com>

Applied.

Thanks,
Guenter