From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Jonathan Corbet <corbet@lwn.net>, Cloud Hsu <cloudhsu@google.com>,
Chris Koch <chrisko@google.com>
Subject: Re: [PATCH v1 1/1] x86/Documentation: Update algo in init_size description of boot protocol
Date: Mon, 25 Nov 2024 12:50:41 +0200 [thread overview]
Message-ID: <Z0RWgYk24V-Fewlr@smile.fi.intel.com> (raw)
In-Reply-To: <Z0RVgdhYu17lINZz@smile.fi.intel.com>
On Mon, Nov 25, 2024 at 12:46:25PM +0200, Andy Shevchenko wrote:
> On Mon, Nov 25, 2024 at 09:45:36AM +0100, Ingo Molnar wrote:
> > * Randy Dunlap <rdunlap@infradead.org> wrote:
> > > On 11/25/24 12:31 AM, Andy Shevchenko wrote:
...
> > > > - if (relocatable_kernel)
> > > > - runtime_start = align_up(load_address, kernel_alignment)
> > > > - else
> > > > - runtime_start = pref_address
> > > > + if ( relocatable_kernel ) {
> > > > + if ( load_address < pref_address )
> > >
> > > What's up with the extra spaces around ( and ) ... and inconsistent with
> > > the lines below?
>
> I can remove them. This file has a lot of inconsistencies it seems...
>
> > Also, even pseudocode should follow the kernel's coding style and use
> > tabs in particular - which it already does in (some...) other places of
> > this document, such as the 'Sample Boot Configuration' chapter.
>
> The problem is that reStructuredText syntax requires that indentation.
> I may follow the rules after the rST requirements, though.
v2 has just been sent:
https://lore.kernel.org/r/20241125105005.1616154-1-andriy.shevchenko@linux.intel.com
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-11-25 10:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 8:31 [PATCH v1 1/1] x86/Documentation: Update algo in init_size description of boot protocol Andy Shevchenko
2024-11-25 8:38 ` Randy Dunlap
2024-11-25 8:45 ` Ingo Molnar
2024-11-25 10:46 ` Andy Shevchenko
2024-11-25 10:50 ` Andy Shevchenko [this message]
2024-11-25 20:43 ` Ingo Molnar
2024-11-25 20:55 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0RWgYk24V-Fewlr@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=chrisko@google.com \
--cc=cloudhsu@google.com \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).