From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2DEDF1FCFCB; Thu, 19 Dec 2024 11:58:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734609488; cv=none; b=AQPtuun+kJQvZQ08eUAr4VFqyiGAWjWYkfmHI4N96pJb2YhTVYfYjJAgc3BqYyJE4j1IMAFRb+o8UGirFQPrIrddRDW9KBo8FQwJt+lSmfpkAsW51LwHyG1YM6Gq43W50jJawHJiJEVy1Bplh4Tw+fOsW65r3btstiL+jt2j5sc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734609488; c=relaxed/simple; bh=9QyEbko00vRNEvfAa8AOjeJA/QUr06UTEbZ8U/z9g1g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=S0GMaaUHxArS1Fi5q+Epz/C5iitmIAMkKrXHirzlUdo77noJWoHPTMNFDxMFqj8jb7QLE9cCjhns5owHUSdToB195Jr6gfrtbAeZsDtKa3Q7IWtTj+B0O6Ba7hlvBFLfopmNYiP5DA0wMySp3hYlu2Pe+YAALatnSjK75y97U4w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1B3C31480; Thu, 19 Dec 2024 03:58:33 -0800 (PST) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 073D83F720; Thu, 19 Dec 2024 03:57:59 -0800 (PST) Date: Thu, 19 Dec 2024 12:57:07 +0100 From: Beata Michalska To: Viresh Kumar Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, ionela.voinescu@arm.com, sudeep.holla@arm.com, will@kernel.org, catalin.marinas@arm.com, rafael@kernel.org, sumitg@nvidia.com, yang@os.amperecomputing.com, vanshikonda@os.amperecomputing.com, lihuisong@huawei.com, zhanjie9@hisilicon.com, Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Phil Auld , x86@kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v8 1/4] cpufreq: Introduce an optional cpuinfo_avg_freq sysfs entry Message-ID: References: <20241206135600.4083965-1-beata.michalska@arm.com> <20241206135600.4083965-2-beata.michalska@arm.com> <20241212065100.sjb7lrlmksbm2hdk@vireshk-i7> <20241217042726.isllh5bulpnwql7i@vireshk-i7> <20241218041127.khdwo3hzmywcwuh5@vireshk-i7> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241218041127.khdwo3hzmywcwuh5@vireshk-i7> On Wed, Dec 18, 2024 at 09:41:27AM +0530, Viresh Kumar wrote: > On 17-12-24, 21:10, Beata Michalska wrote: > > On Tue, Dec 17, 2024 at 09:57:26AM +0530, Viresh Kumar wrote: > > > On 16-12-24, 23:15, Beata Michalska wrote: > > > > My bad as I must have misinterpreted that message. Although I am not entirely > > > > sure why this might be unacceptable as it is not such uncommon approach to use > > > > signed int space to cover both: expected positive value as well as potential > > > > error code case failure. > > > > > > This part is fine. The problem is with handling frequency here. Signed int can > > > capture up to 2 GHz of freq, where as unsigned int can capture up to 4 GHz and > > > so we would really like to keep it at 4 GHz.. > > Right, though the arch_freq_get_on_cpu operates on kHz values. > > Hmm.. Missed that. > > If you still want to keep it, make that change in a separate patch and > the new sysfs entry in a different one, so related people can easily > review. > Will do. Thank you for your feedback. Much appreciated. --- BR Beata > -- > viresh