* [PATCH] Documentation: Remove the outdated prompt under cgroup_disable option in kernel-parameters.txt
@ 2024-12-13 9:52 Jianhui Zhou
2025-01-09 19:44 ` Jonathan Corbet
0 siblings, 1 reply; 3+ messages in thread
From: Jianhui Zhou @ 2024-12-13 9:52 UTC (permalink / raw)
To: corbet, akpm, paulmck, jonaszhou
Cc: thuth, rostedt, david, victor, andrii, xiongwei.song, linux-doc,
linux-kernel, Jianhui Zhou
Disabling options other than memory is currently
supported according to the cgroup_disable function.
So it can be removed.
Signed-off-by: Jianhui Zhou <jianhuizz@qq.com>
---
Documentation/admin-guide/kernel-parameters.txt | 3 ---
1 file changed, 3 deletions(-)
diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index 3872bc6ec49d..3c562653016f 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -609,9 +609,6 @@
- if foo is an optional feature then the feature is
disabled and corresponding cgroup files are not
created
- {Currently only "memory" controller deal with this and
- cut the overhead, others just disable the usage. So
- only cgroup_disable=memory is actually worthy}
Specifying "pressure" disables per-cgroup pressure
stall information accounting feature
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Documentation: Remove the outdated prompt under cgroup_disable option in kernel-parameters.txt
2024-12-13 9:52 [PATCH] Documentation: Remove the outdated prompt under cgroup_disable option in kernel-parameters.txt Jianhui Zhou
@ 2025-01-09 19:44 ` Jonathan Corbet
2025-01-09 20:22 ` Tejun Heo
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Corbet @ 2025-01-09 19:44 UTC (permalink / raw)
To: Jianhui Zhou, akpm, paulmck, jonaszhou
Cc: thuth, rostedt, david, victor, andrii, xiongwei.song, linux-doc,
linux-kernel, Jianhui Zhou, Tejun Heo
It would have been good to include the cgroup maintainer here; adding
Tejun.
Looking at the code, it's far from clear to me that the other cgroups
pay attention to this parameter. Can somebody convince me that this
change is correct?
Thanks,
jon
Jianhui Zhou <jianhuizz@qq.com> writes:
> Disabling options other than memory is currently
> supported according to the cgroup_disable function.
> So it can be removed.
>
> Signed-off-by: Jianhui Zhou <jianhuizz@qq.com>
> ---
> Documentation/admin-guide/kernel-parameters.txt | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 3872bc6ec49d..3c562653016f 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -609,9 +609,6 @@
> - if foo is an optional feature then the feature is
> disabled and corresponding cgroup files are not
> created
> - {Currently only "memory" controller deal with this and
> - cut the overhead, others just disable the usage. So
> - only cgroup_disable=memory is actually worthy}
> Specifying "pressure" disables per-cgroup pressure
> stall information accounting feature
>
> --
> 2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Documentation: Remove the outdated prompt under cgroup_disable option in kernel-parameters.txt
2025-01-09 19:44 ` Jonathan Corbet
@ 2025-01-09 20:22 ` Tejun Heo
0 siblings, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2025-01-09 20:22 UTC (permalink / raw)
To: Jonathan Corbet
Cc: Jianhui Zhou, akpm, paulmck, jonaszhou, thuth, rostedt, david,
victor, andrii, xiongwei.song, linux-doc, linux-kernel
Hello,
On Thu, Jan 09, 2025 at 12:44:15PM -0700, Jonathan Corbet wrote:
> It would have been good to include the cgroup maintainer here; adding
> Tejun.
>
> Looking at the code, it's far from clear to me that the other cgroups
> pay attention to this parameter. Can somebody convince me that this
> change is correct?
I don't think the patch is correct. The extra comment does still hold.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-01-09 20:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-13 9:52 [PATCH] Documentation: Remove the outdated prompt under cgroup_disable option in kernel-parameters.txt Jianhui Zhou
2025-01-09 19:44 ` Jonathan Corbet
2025-01-09 20:22 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).