From: Carlos Llamas <cmllamas@google.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Li Li <dualli@chromium.org>,
dualli@google.com, corbet@lwn.net, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, donald.hunter@gmail.com,
gregkh@linuxfoundation.org, arve@android.com, tkjos@android.com,
maco@android.com, joel@joelfernandes.org, brauner@kernel.org,
surenb@google.com, arnd@arndb.de, masahiroy@kernel.org,
bagasdotme@gmail.com, horms@kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
netdev@vger.kernel.org, hridya@google.com, smoreland@google.com,
kernel-team@android.com
Subject: Re: [PATCH v11 2/2] binder: report txn errors via generic netlink
Date: Thu, 9 Jan 2025 23:19:40 +0000 [thread overview]
Message-ID: <Z4BZjHjfanPi5h9W@google.com> (raw)
In-Reply-To: <20250109121300.2fc13a94@kernel.org>
On Thu, Jan 09, 2025 at 12:13:00PM -0800, Jakub Kicinski wrote:
> On Thu, 9 Jan 2025 11:48:24 -0800 Li Li wrote:
> > Cleaning up in the NETLINK_URELEASE notifier is better since we
> > register the process with the netlink socket. I'll change the code
> > accordingly.
>
> Hm. Thought I already told you this. Maybe I'm mixing up submissions.
>
> Please the unbind callback or possibly the sock priv infra
> (genl_sk_priv_get, sock_priv_destroy etc).
Sorry, it was me that suggested NETLINK_URELEASE. BTW, I did try those
genl_family callbacks first but I couldn't get them to work right away
so I moved on. I'll have a closer look now to figure out what I did
wrong. Thanks for the suggestion Jakub!
--
Carlos Llamas
next prev parent reply other threads:[~2025-01-09 23:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 20:37 [PATCH v11 0/2] binder: report txn errors via generic netlink Li Li
2024-12-18 20:37 ` [PATCH v11 1/2] binderfs: add new binder devices to binder_devices Li Li
2024-12-18 20:37 ` [PATCH v11 2/2] binder: report txn errors via generic netlink Li Li
2025-01-07 21:29 ` Carlos Llamas
2025-01-07 21:41 ` Carlos Llamas
2025-01-08 0:00 ` Li Li
2025-01-08 19:07 ` Carlos Llamas
2025-01-08 19:56 ` Li Li
2025-01-08 21:59 ` Carlos Llamas
2025-01-09 18:51 ` Carlos Llamas
2025-01-09 19:30 ` Carlos Llamas
2025-01-09 19:48 ` Li Li
2025-01-09 20:13 ` Jakub Kicinski
2025-01-09 23:19 ` Carlos Llamas [this message]
2025-01-10 0:18 ` Jakub Kicinski
2025-01-14 6:01 ` Li Li
2025-01-14 18:32 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4BZjHjfanPi5h9W@google.com \
--to=cmllamas@google.com \
--cc=arnd@arndb.de \
--cc=arve@android.com \
--cc=bagasdotme@gmail.com \
--cc=brauner@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dualli@chromium.org \
--cc=dualli@google.com \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=horms@kernel.org \
--cc=hridya@google.com \
--cc=joel@joelfernandes.org \
--cc=kernel-team@android.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=masahiroy@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=smoreland@google.com \
--cc=surenb@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).