From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0846918A6DF for ; Thu, 9 Jan 2025 23:19:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736464787; cv=none; b=pRcsRFhPEUmG1zs2mWEtZl1T28cXuvaqefWs3BKusNYtmLrsD+kmy6STwdVoa1eCTXaPodF8yF/r+GoE68l7lm9QNVrk8WIwFSPzzDuxIuzinik0HAtvHYhrZSiMDGdzrL5gM/4c8WXL04/pSj4eKyl2QXqWLEPRlsRtQ1BLQHk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736464787; c=relaxed/simple; bh=KouWdL/Ro/NawNsOGgzco7I92kyaGlxbjwySe1i5cIE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KgZ2CyvBPUzjIqZYuvlTw3j4T49m7Vvd9UNMCjMK4+0VI6yehZx6R54e4B4I00clRlZ4c+ddZThBlssV6U2xWXIMPu/XpMO5jRBNUYhWXWQqRWX8OpxqOCyga6M0SZTEmNLiCK+AkZf/BAfqfCtzgIq8c0zqjfsEtwjG8n+Myhw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=zVX55/Im; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="zVX55/Im" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-215740b7fb8so52975ad.0 for ; Thu, 09 Jan 2025 15:19:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736464785; x=1737069585; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=q1PkYbGFJEdslOfFcxj83YTAVMXcuo1qR/Rn78KGBhI=; b=zVX55/ImohmYEwJm3HqOAF3Vjbykyi08PyhWU91FxS+sgijpUp/PWTCSZ9wVwGHEQ1 bp+sieJXFWVJu21PBiK3+5/I+duw1CV0GVCO5XRFKphuNDS5APzP5BPPqRDi6QIEOsJ7 EbLJh3PAN2l8ICfsNIt3eJzd5SGN2ZEY3LZJejH01pclt58iu1hRBwrX1dmxvctaELNw qUocRtUUQNV9NIwJ6BGTMLAg0ayIQ7jihWUtVbM91I0d+Fbnm6gmV+AIjfb3Kb5NI7Gk fS44KifUoaRREBakxQtoeMSYml+9Q9UW+nbbaQ5dkVAgsw7K6PHRUkfh9mlVRL5jKPAb XcMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736464785; x=1737069585; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=q1PkYbGFJEdslOfFcxj83YTAVMXcuo1qR/Rn78KGBhI=; b=g/w4mnox7GM5xiY4fPPpGnOAFljDpVfTLKdXutuKHQdLhsVIkPv3i9dp4i5farAodm tLid9xkINN8iv+lo2nVfTHYifYHYk8rTx2o9zkcWf/HMDPL3jGQ32Y+QgK53uD2yLSld 2Z03uPXf7UMXFAXtmoU6lbtfMqBLuH7cwjr+0KF/pkLuS9q30fh14KyMNLIYI1n/+qgi D2iZBNqhVzqIoYd8ktigjRN3wSPdl/grY4UXxBCfXvWSkmlkGDD4jRcwbCqXB9FrsAFN nk2OwQn43/L7e6uEPSWdOXh3PVA15Q3N83Uazxjk0F+TTZEaf0alJqaOs6R5w5lizdCX sijw== X-Forwarded-Encrypted: i=1; AJvYcCVexry6jULva5gzmOVrSZVI0hUQTOb03phafhNv+0D+m0VL2I7Efvk3NRqL6uyI6sW53n33A6ZLkog=@vger.kernel.org X-Gm-Message-State: AOJu0YwcIjWWqi9Lv84nOveCxPbGz4ZWQbcBI0YRe3RmVDhM31IR7rqp ImszC3mrF2pTozFQlkPfqshwbPnqBssITMkNh+40qVHfV1yOaUu/qIe1B08g2A== X-Gm-Gg: ASbGncvfcgBsf/MrPi3bogeL1hwGd+d+AWnpN09gLxVRlPfFuv4cAF6O/cDTnlK6GGd GTOh7j2z2kf4IGXW+kbAJcQvDOBhdizCNj0O9TBG5V4+ZSyv2SgoRym+n0OuWi1OBkFXwBh5a9c IBzvtuF2iUfBPk/lq90sWHa33dPjQe+aZcAkAj05GHBlZxiN8hAhPwPy5BuzfF7MKafDXf6H5Zm TK3dR5tuZrH5nPJYzAxeSp9hN6M7Nl4vlDwXSt6ka6G/xZeDcA4SYVoU/A5seoTEn+BzJPjiF0M 7x/in2Q8WsNMdW1Bqfs= X-Google-Smtp-Source: AGHT+IEHNg3KQNkDJkk+KVCtgbVcnKqUUPICpFgI9fFO1Xu457d4ai2cWyh2ei9TOQgrYG3Htub00Q== X-Received: by 2002:a17:903:4284:b0:217:8109:e85 with SMTP id d9443c01a7336-21aa338c570mr342445ad.13.1736464785230; Thu, 09 Jan 2025 15:19:45 -0800 (PST) Received: from google.com (57.145.233.35.bc.googleusercontent.com. [35.233.145.57]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f54a26ad41sm4599210a91.1.2025.01.09.15.19.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jan 2025 15:19:44 -0800 (PST) Date: Thu, 9 Jan 2025 23:19:40 +0000 From: Carlos Llamas To: Jakub Kicinski Cc: Li Li , dualli@google.com, corbet@lwn.net, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, donald.hunter@gmail.com, gregkh@linuxfoundation.org, arve@android.com, tkjos@android.com, maco@android.com, joel@joelfernandes.org, brauner@kernel.org, surenb@google.com, arnd@arndb.de, masahiroy@kernel.org, bagasdotme@gmail.com, horms@kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, netdev@vger.kernel.org, hridya@google.com, smoreland@google.com, kernel-team@android.com Subject: Re: [PATCH v11 2/2] binder: report txn errors via generic netlink Message-ID: References: <20241218203740.4081865-1-dualli@chromium.org> <20241218203740.4081865-3-dualli@chromium.org> <20250109121300.2fc13a94@kernel.org> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250109121300.2fc13a94@kernel.org> On Thu, Jan 09, 2025 at 12:13:00PM -0800, Jakub Kicinski wrote: > On Thu, 9 Jan 2025 11:48:24 -0800 Li Li wrote: > > Cleaning up in the NETLINK_URELEASE notifier is better since we > > register the process with the netlink socket. I'll change the code > > accordingly. > > Hm. Thought I already told you this. Maybe I'm mixing up submissions. > > Please the unbind callback or possibly the sock priv infra > (genl_sk_priv_get, sock_priv_destroy etc). Sorry, it was me that suggested NETLINK_URELEASE. BTW, I did try those genl_family callbacks first but I couldn't get them to work right away so I moved on. I'll have a closer look now to figure out what I did wrong. Thanks for the suggestion Jakub! -- Carlos Llamas