From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6A321FDE15; Mon, 27 Jan 2025 10:48:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.200 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737974917; cv=none; b=O3E1BjWNrZU74Dz8WeqUZx+sG2Y6tJvGnSUHq58WJu5F2csOluiL4xgE0XpH1laHThArsYsXR/WrbHQVvAe0S24bIG+zqkh+50ET6d4BoUhe3j3O4t6EM/QLrodGDS1ZKQnEVxtwzUOpIwiYAbR0hbdM2t03xlIBkVIxXxPf8Nc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737974917; c=relaxed/simple; bh=gu+OcbLGVvf1dfHH/7ye3s4n2z3k77nc2myZiXE9DtA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ha2X98L9J22NkgjhuhgrTKb4zVSl25wGtDGPgoMNfs7yz2dTHQmKwftZY33egEaCikccI/Ts8ecltS08dcBTqW/pXMs8UepkbwXfHlNk+9dtU0NSZtC6S0I2WX1wwmwyBRx331o9ImAeAEbgg5VBTSi+Ky9gDyDk7ih5zTgd2pk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=ODwDe+ZC; arc=none smtp.client-ip=217.70.183.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="ODwDe+ZC" Received: by mail.gandi.net (Postfix) with ESMTPSA id C430C2000A; Mon, 27 Jan 2025 10:48:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1737974907; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=16Z4jSz8wfLo+04tmP/UOzeDIejcTqVQyH3UF14AFGo=; b=ODwDe+ZCtqIB1E51+TpbvEuaH8BndqDBT1ItNBYeAMUq++lzJKw7iA97a7ZFIw9Z+hNnmj zX2eciYO70HPV8FxI8nUAkwBIOPWnzgs/zvD2P8paW+g0mHKg53qvl5r6jcZPikKvhLise k0+p75ebhi+oQkeXEryvFG6sZ+bjiEsH2987J7cW6fQ/cp7gOSSOWV5xHoMb7OvJL4s3/h dojbVMGl9mMjUK/FrYE952CB8oNMa9sHv1dlM/NwK46zf2ktU4ElnvClshZ5yHQmInxxa7 /MeaORBBKoHXL8wztSI5D36aVASN2DxzMnMsPkG8+6Pi9KR2pF4RohKyFr9CyA== Date: Mon, 27 Jan 2025 11:48:23 +0100 From: Louis Chauvet To: Maxime Ripard Cc: Rodrigo Siqueira , Melissa Wen , =?iso-8859-1?Q?Ma=EDra?= Canal , Haneen Mohammed , Maarten Lankhorst , Thomas Zimmermann , David Airlie , rdunlap@infradead.org, arthurgrillo@riseup.net, Jonathan Corbet , pekka.paalanen@haloniitty.fi, Simona Vetter , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, jeremie.dautheribes@bootlin.com, miquel.raynal@bootlin.com, thomas.petazzoni@bootlin.com, seanpaul@google.com, marcheu@google.com, nicolejadeyee@google.com, linux-doc@vger.kernel.org, Pekka Paalanen Subject: Re: [PATCH v16 5/7] drm/vkms: Create KUnit tests for YUV conversions Message-ID: Mail-Followup-To: Maxime Ripard , Rodrigo Siqueira , Melissa Wen , =?iso-8859-1?Q?Ma=EDra?= Canal , Haneen Mohammed , Maarten Lankhorst , Thomas Zimmermann , David Airlie , rdunlap@infradead.org, arthurgrillo@riseup.net, Jonathan Corbet , pekka.paalanen@haloniitty.fi, Simona Vetter , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, jeremie.dautheribes@bootlin.com, miquel.raynal@bootlin.com, thomas.petazzoni@bootlin.com, seanpaul@google.com, marcheu@google.com, nicolejadeyee@google.com, linux-doc@vger.kernel.org, Pekka Paalanen References: <20250121-yuv-v16-0-a61f95a99432@bootlin.com> <20250121-yuv-v16-5-a61f95a99432@bootlin.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-GND-Sasl: louis.chauvet@bootlin.com On 26/01/25 - 18:06, Maxime Ripard wrote: > On Tue, Jan 21, 2025 at 11:48:06AM +0100, Louis Chauvet wrote: > > +static struct yuv_u8_to_argb_u16_case yuv_u8_to_argb_u16_cases[] = { > > + /* > > + * colour.RGB_to_YCbCr(, > > + * K=colour.WEIGHTS_YCBCR["ITU-R BT.601"], > > + * in_bits = 16, > > + * in_legal = False, > > + * in_int = True, > > + * out_bits = 8, > > + * out_legal = False, > > + * out_int = True) > > + * > > + * Test cases for conversion between YUV BT601 full range and RGB > > + * using the ITU-R BT.601 weights. > > + */ > > What are the input and output formats? > > Ditto for all the other tests. There is no really "input" and "output" format, they are reference values for conversion, you should be able to use it in both direction. They are generated by RGB_to_YCbCr (RGB input, YUV output) just because it was easier to create the colors from RGB values. If you think we should specify what is was used as input and output to generate those values, I can modify the comment to: Tests cases for color conversion generated by converting RGB values to YUV BT601 full range using the ITU-R BT.601 weights. Beside that modification, did you notice anything else on the series that require more work before adding your Ack-by/Reviewed-by on the other patches? Thanks, Louis Chauvet > Maxime