From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2060.outbound.protection.outlook.com [40.107.94.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AF1D26AA94; Tue, 18 Feb 2025 18:16:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.94.60 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739902565; cv=fail; b=iQGMn0XCkuRXxgLq/LeQ+5QVseMzZRI++TgiYDYZRyZrp0H21b9pBojRR8aTf2vDUT+d+E/ICLuCjrDjjqD8p+zDPnSbOyCtGi0kBAjH+JkTY8StTbvzTSP4W6S0+Wpp1adaqnmAEJviScBgZHLhWlXCV8Fc+sIbefi6gdBcdH4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739902565; c=relaxed/simple; bh=6889+D0lBdIOYmQk1A0YOavniIZK9kfBMlDWJxx9qQo=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nybkLWU3pt3zi3uma3n1IyPn9CAe6Lk5w6JscLGde0jjVR2ZouKSjh5Sz6DvbElf2Dr9+eW65FNS3/5mBBvFPWRLfdoJ0kvv0Ne5w6pN6ePplQfT20gtqAaM1rbOfebdxwVMtkMhhN4YrvOZ/+yUP9XxJP+XkpFMtuZy3zykGvE= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=kIKxAc4Y; arc=fail smtp.client-ip=40.107.94.60 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="kIKxAc4Y" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=r843ml5ZucLIAzfE9H0ExUkxlF6CjahsirL4HOVGHo0saUtA9SY/5kW+spVd2abJizt3tJ0IkJQznnsPmHt8EO1xr8D2bf/eLNLhnlYrvrlxuTZJjfJ29zyLBnk9i1swWnPheA1LlWkehRdgVtNZoa8rHpLw0CF97aD6/KLX274loWk1q8m2Oe8hxulymZNWfAYSkA1lUOEtssyf2Oqy9Rblrk8YVGPf2lCw7+jEDaU+W2lB+2mNQYIID8hskayJRr9lTNDXXP2QF5SF9uBP8N2Cp8CkKzQ2ynWDvjOpYD69cl/ax4yWf3XqjS1LWte1G3W1F09MIVaa/OivwSc+3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mWt9mIg+n96/VxLcOQeCpsNSiVm1sJbQx2LjwUcqGes=; b=VP1nhYWICkYH/Rx6Fr8YPHeFED8kfqMbYjhr6793rTJiVhCgu7EdqAT1YT/YsXXoF5KIpWJbeno/CIu07Cf7AtVjT6r+Loqd1XAcBe9PC68nBTUezbxmgHZziqYRz3Sh6GYjisWj8225nQln4/Taf0gnFjVccGFUtnHXcrLbjEw6jnUocEKsq0nUPzCVZYUXcUpXSInHgpQs1axcxhA+lIBXWQQWB5Z75e/Rl9e/rEXZQHf1ia3Hq6JEoRee478XBXz9NH8pJlWgi2wDVa4ptvcOIzUss4yAG3UPlMumaU/vAF3W+4p5F+VPe49C2zWwwajLhn+T82SsHAQu6XLAXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mWt9mIg+n96/VxLcOQeCpsNSiVm1sJbQx2LjwUcqGes=; b=kIKxAc4YfaacR58wMl27nFTxqplkGMrsi93P3pbHHs4TaD9osBArsPkjkGGCGKxc4BR+Mz8riLGIAVlVCbVFKFhMtxDEYUVdkM6ei5UQDzI9+tyv9jMJQaVpf2kLI2WniAzy7ifGPm/2MOAEOL9vPW90YYRgwmZfG5zHtj2gxH3DVHZ3DHmPWqWJtyqQUVVrwmB+ZUCzXiFBGpfFpNUw76kIo+5SVlUUwbX3Tm7G3xYY4RWMIhIMFrGDvd6PVDmEbeUcFGTaBESKMQGlJ6jrrbjxAiEqRfbtzvh0NOdYc2Cd+uVfzoc2ViwV0p56V3vOnLhdUni+IryW9fvo7lMI3A== Received: from DM6PR17CA0013.namprd17.prod.outlook.com (2603:10b6:5:1b3::26) by CY8PR12MB8267.namprd12.prod.outlook.com (2603:10b6:930:7c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.18; Tue, 18 Feb 2025 18:16:01 +0000 Received: from DS2PEPF00003439.namprd02.prod.outlook.com (2603:10b6:5:1b3:cafe::66) by DM6PR17CA0013.outlook.office365.com (2603:10b6:5:1b3::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8445.19 via Frontend Transport; Tue, 18 Feb 2025 18:16:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by DS2PEPF00003439.mail.protection.outlook.com (10.167.18.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.11 via Frontend Transport; Tue, 18 Feb 2025 18:16:01 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 18 Feb 2025 10:15:48 -0800 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 18 Feb 2025 10:15:47 -0800 Received: from nvidia.com (10.127.8.13) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14 via Frontend Transport; Tue, 18 Feb 2025 10:15:46 -0800 Date: Tue, 18 Feb 2025 10:15:45 -0800 From: Nicolin Chen To: Jason Gunthorpe CC: , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v6 05/14] iommufd: Add IOMMUFD_OBJ_VEVENTQ and IOMMUFD_CMD_VEVENTQ_ALLOC Message-ID: References: <2fb8d9c7b01ad36b42849283cd33d931f11092cb.1737754129.git.nicolinc@nvidia.com> <20250218152959.GB4099685@nvidia.com> <20250218180805.GI4099685@nvidia.com> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20250218180805.GI4099685@nvidia.com> X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF00003439:EE_|CY8PR12MB8267:EE_ X-MS-Office365-Filtering-Correlation-Id: 1de284d1-3547-4957-fcd0-08dd50484d08 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|82310400026|376014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?D9kv7cerdKC8lGz2MkuAKUnIl6l5E5zOvMkzN0xvbvMyiqSKI6k2ddOiXlpQ?= =?us-ascii?Q?XvWniNCJFR7q2F6qxfmwhnvpp+mqZQIFja5AoUr6WdwysImk229lSLrr2lWc?= =?us-ascii?Q?blCtu9vCQx7S0JfLrbtwDfHJw9oA0/LiejfA1HJcxp1GUyD5QmmCJYugxsEx?= =?us-ascii?Q?2S1hDXyVOp05kChzO6OGW8w9d5Y3Fxo7SNczXaYKftkn384rZFtS6yKqJzV9?= =?us-ascii?Q?DpX2Ln+ciR/sYVLDp5Iyv27wwA2o7lIIclyrHfm6lus4fzeKWU1rIfBsHsYW?= =?us-ascii?Q?EzJM/vivEyCQDaF2H7LX0g50Ej8tkqQC1sss60N2q9crceF/CbD9Avxwd6yw?= =?us-ascii?Q?O4HTt1oBMbk6TT9E9z96X40ZOv+5ltdDmX+wwzx5WTbTR5OCcai06QtTJGpb?= =?us-ascii?Q?ME4IciM+/CS6PAnuSU5VRZP9zyt+HeDBFbsaRl4qMhpX+YGAxmeWKdXrR9Wk?= =?us-ascii?Q?Mr745HU/MH/6KjLG4O0hc6kzGNyes16po0WlPhLC8BtjRg+d4MamzfMzz7io?= =?us-ascii?Q?lrbZJMY1Imv3p0hLP/5rVuQIa7y43Azote4W1PREk7HtZtNl66Ik/X1vx0bE?= =?us-ascii?Q?nTCRBXGe1PyUYiI5bIognmxnaM6Y4eOt9CzroM7+Pi+nCVwn8AlwjnP2jPyB?= =?us-ascii?Q?3patrI4Xas7/cnwi8KzfxDcDcJmMhjPWWaqhHLA9hAkAEycCYWSVkdziG2pE?= =?us-ascii?Q?MJ/yqR7X8hB0oaqsM68tEs25ivsxJeT64hwUuccxbMgaNSIz8X9i/EXgFy99?= =?us-ascii?Q?tUaQbUf96frgoz0WqOuybdO7JLLvygTaH4OywvREgrmxS5CK3yTKMdtjijMI?= =?us-ascii?Q?M+RwzCnKfPy0jF5j/l/Ucs2G5ZtXy286F9q2SDb6erlwjDjpyK4UOmsihYbQ?= =?us-ascii?Q?ve2KPqJ0p0NsXpNGXaAVA/WQ8YGCDbFJLtjbTXRVm8UAiWer8XMznvxP07z8?= =?us-ascii?Q?5QtlJreWk9gTyJkueTqN+l3cwCu0KyIwBuTdEzn3aTDUvhVMoLTYxxiuzjnV?= =?us-ascii?Q?rDaSCAsk/EGYuN8mv5HT7PD2xMaSmxljgfaNSakX9wgDLfIrtLMyJRolK6Ch?= =?us-ascii?Q?JtnGLPpsmhBTBjBjXmRNd1ghF1PaWLoabZj56pHHE+UMYnL013qp/bMSV22W?= =?us-ascii?Q?bfsgyC9VvBawrwV1JCUTGpRT3V3kFET4rgzTySigo0SGHa5np59sJt6sCY8X?= =?us-ascii?Q?UEXFn5xJS+5XRhzr8fz/RPXyfx1m3+g39AVlotxypHAnu0jAp+VM5JK+cbl0?= =?us-ascii?Q?1MeOsKFaZm5QUUp+ko276lsCz1im4ZASIajvIaRGIVwWSOp0mc/IdKFxdyHr?= =?us-ascii?Q?blJ8WFf0jWT8XAs9/9di5d2WtP4sWSgjD5nEbx7wfU/gD15qgkH7S3zPZuQ+?= =?us-ascii?Q?OuO095CMvVJSIRxLVA0KGcBAmum7MyzRXakwXVnlj+s32DsAs9M06R+gbF93?= =?us-ascii?Q?YU1SvOKF2njLJCgyHGt3MccrPdHzvmsqcIWHKsemsjAnv+n6EMBygZITUmyc?= =?us-ascii?Q?OQNyBU1e6hsx/e0=3D?= X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(7416014)(82310400026)(376014)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2025 18:16:01.5217 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1de284d1-3547-4957-fcd0-08dd50484d08 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF00003439.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8267 On Tue, Feb 18, 2025 at 02:08:05PM -0400, Jason Gunthorpe wrote: > On Tue, Feb 18, 2025 at 09:47:50AM -0800, Nicolin Chen wrote: > > > > +int iommufd_veventq_alloc(struct iommufd_ucmd *ucmd) > > > > +{ > > > > + struct iommu_veventq_alloc *cmd = ucmd->cmd; > > > > + struct iommufd_veventq *veventq; > > > > + struct iommufd_viommu *viommu; > > > > + int fdno; > > > > + int rc; > > > > + > > > > + if (cmd->flags || cmd->type == IOMMU_VEVENTQ_TYPE_DEFAULT) > > > > + return -EOPNOTSUPP; > > > > + if (!cmd->veventq_depth) > > > > + return -EINVAL; > > > > > > Check __reserved for 0 too > > > > Kevin is suggesting a 32-bit flag field, so I think we can drop > > the __reserved in that case. > > Those are different structs? Oops. Right. I will check the __reserved. Thanks Nicolin