From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: Kory Maincent <kory.maincent@bootlin.com>,
Andrew Lunn <andrew@lunn.ch>,
Oleksij Rempel <o.rempel@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
Donald Hunter <donald.hunter@gmail.com>,
Rob Herring <robh@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Simon Horman <horms@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
Kyle Swenson <kyle.swenson@est.tech>,
Dent Project <dentproject@linuxfoundation.org>,
kernel@pengutronix.de, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v5 09/12] net: pse-pd: pd692x0: Add support for controller and manager power supplies
Date: Mon, 24 Feb 2025 12:49:19 +0000 [thread overview]
Message-ID: <Z7xqz-Z5UhqBQXnc@shell.armlinux.org.uk> (raw)
In-Reply-To: <20250224134222.358b28d8@fedora>
On Mon, Feb 24, 2025 at 01:42:22PM +0100, Maxime Chevallier wrote:
> On Tue, 18 Feb 2025 17:19:13 +0100
> Kory Maincent <kory.maincent@bootlin.com> wrote:
> > diff --git a/drivers/net/pse-pd/pd692x0.c b/drivers/net/pse-pd/pd692x0.c
> > index 44ded2aa6fca..c9fa60b314ce 100644
> > --- a/drivers/net/pse-pd/pd692x0.c
> > +++ b/drivers/net/pse-pd/pd692x0.c
> > @@ -976,8 +976,10 @@ pd692x0_register_managers_regulator(struct pd692x0_priv *priv,
> > reg_name_len = strlen(dev_name(dev)) + 23;
> >
> > for (i = 0; i < nmanagers; i++) {
> > + static const char * const regulators[] = { "vaux5", "vaux3p3" };
>
> Looks like the 'static' is not needed here :)
Have you checked the compiler output before saying that?
I've seen plenty of instances where "static" should be there but isn't,
leading to the compiler generating inline code to create the
array/struct on the stack.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-02-24 12:49 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 16:19 [PATCH net-next v5 00/12] Add support for PSE budget evaluation strategy Kory Maincent
2025-02-18 16:19 ` [PATCH net-next v5 01/12] net: ethtool: Add support for ethnl_info_init_ntf helper function Kory Maincent
2025-02-18 16:19 ` [PATCH net-next v5 02/12] net: pse-pd: Add support for reporting events Kory Maincent
2025-02-21 0:42 ` Jakub Kicinski
2025-02-24 12:33 ` Kory Maincent
2025-02-24 21:47 ` Jakub Kicinski
2025-02-21 8:50 ` Oleksij Rempel
2025-02-24 11:02 ` Kory Maincent
2025-02-24 18:19 ` Kory Maincent
2025-02-18 16:19 ` [PATCH net-next v5 03/12] net: pse-pd: tps23881: Add support for PSE events and interrupts Kory Maincent
2025-02-18 16:19 ` [PATCH net-next v5 04/12] net: pse-pd: Add support for PSE power domains Kory Maincent
2025-02-21 0:43 ` Jakub Kicinski
2025-02-18 16:19 ` [PATCH net-next v5 05/12] net: ethtool: Add support for new power domains index description Kory Maincent
2025-02-18 16:19 ` [PATCH net-next v5 06/12] net: pse-pd: Add support for budget evaluation strategies Kory Maincent
2025-02-21 0:51 ` Jakub Kicinski
2025-02-24 13:10 ` Kory Maincent
2025-02-24 21:45 ` Jakub Kicinski
2025-02-25 9:25 ` Kory Maincent
2025-02-26 1:47 ` Jakub Kicinski
2025-02-26 5:59 ` Oleksij Rempel
2025-02-26 6:06 ` Oleksij Rempel
2025-02-27 2:42 ` Jakub Kicinski
2025-02-27 7:40 ` Oleksij Rempel
2025-02-27 14:57 ` Kory Maincent
2025-02-27 16:40 ` Oleksij Rempel
2025-02-27 18:26 ` Kory Maincent
2025-03-01 13:00 ` Oleksij Rempel
2025-03-03 13:40 ` Kory Maincent
2025-03-04 1:12 ` Jakub Kicinski
2025-02-18 16:19 ` [PATCH net-next v5 07/12] net: ethtool: Add PSE new budget evaluation strategy support feature Kory Maincent
2025-02-21 13:49 ` Oleksij Rempel
2025-02-24 13:13 ` Kory Maincent
2025-02-18 16:19 ` [PATCH net-next v5 08/12] net: pse-pd: pd692x0: Add support for PSE PI priority feature Kory Maincent
2025-02-18 16:19 ` [PATCH net-next v5 09/12] net: pse-pd: pd692x0: Add support for controller and manager power supplies Kory Maincent
2025-02-24 12:42 ` Maxime Chevallier
2025-02-24 12:49 ` Russell King (Oracle) [this message]
2025-02-24 13:17 ` Maxime Chevallier
2025-02-18 16:19 ` [PATCH net-next v5 10/12] dt-bindings: net: pse-pd: microchip,pd692x0: Add manager regulator supply Kory Maincent
2025-02-19 7:41 ` Krzysztof Kozlowski
2025-02-18 16:19 ` [PATCH net-next v5 11/12] net: pse-pd: tps23881: Add support for static port priority feature Kory Maincent
2025-02-18 16:19 ` [PATCH net-next v5 12/12] dt-bindings: net: pse-pd: ti,tps23881: Add interrupt description Kory Maincent
2025-02-19 7:41 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7xqz-Z5UhqBQXnc@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dentproject@linuxfoundation.org \
--cc=devicetree@vger.kernel.org \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kernel@pengutronix.de \
--cc=kory.maincent@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=kyle.swenson@est.tech \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).