From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 901D2C77B7F for ; Thu, 27 Apr 2023 09:28:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243068AbjD0J2P (ORCPT ); Thu, 27 Apr 2023 05:28:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243325AbjD0J2L (ORCPT ); Thu, 27 Apr 2023 05:28:11 -0400 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 259372119 for ; Thu, 27 Apr 2023 02:28:10 -0700 (PDT) Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-63b78b344d5so6507830b3a.1 for ; Thu, 27 Apr 2023 02:28:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1682587689; x=1685179689; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=oSffrdiQPNNJd53oPjULTxIDSQd1IqHIbkRxrZQ6UwM=; b=F/zn3ER6A0Q+l5tyEH+ooDZjeuYDIzMGhQDb6TqHt3Pb0O13tyjs1VtHpjpkprGKJC /mPpOvw/3pTNKBWqGKjLEVbRI8RPP/Nj4drvC53IPKkG8ev41zKBirpKVNnXLxoMRB9x N4I9/LmdwNqmjEa/08JGK62+GkonSU/kkzu5F27X4ZH/dgGROBpCwQoovtDi+cmjaLnV 0O/ST5MVcjhE++RIXI7y4d72DSrmQ4rmb5Ov98XBD3CXVd3UeFqtsk9EM2XuwNkG4PIv PSU/aDUj4zfNd4+hekg0hoGs4VGEhyFLpSNCfFtMQ79ep9TBZYA2xxQFsfX7PCOlSdyn O8aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682587689; x=1685179689; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oSffrdiQPNNJd53oPjULTxIDSQd1IqHIbkRxrZQ6UwM=; b=XCrByt5uq5tieps+tWSGpdOza331DLrCz/NP4Af4a+8SLB4s9TSky4w8UVcu1WBe09 P2aiGq+xz3mBAbLZso2LQx8YIeGcGlWnnwPnk/Lcyex3HHRmAbt138Hl4jkehJXVp2VX ZFioUIqc7JS4FEHg0B7ni2FMQ5NhAHJKIJ0qhG927Rz2j0rPtgNwql4EDrrsyH3jaD1V ggYLCG4OFdCzeJaACVke+60oEyayCN/xo3AYHtvPVARMY3lzgUh3MIsbrE2q1SFyFmFs LrCRbzHk7jDb6DmDQw1qEfEKfOo4A4Rw8XP+EginF/uStAvSgyrALYFnZY3uU6d/3sJq nE4g== X-Gm-Message-State: AC+VfDylW/slwE8Kwk6XiB18uMWE7h8RLbSFDROBP9ccDHmxu+grI1QG ysxhSUXt+Lp+vHrssDt4gHKQIg== X-Google-Smtp-Source: ACHHUZ4lU97uublnhxGqgaRZ1mTY/dMxrK9u9MjTcCIsw/70eIIiihIHGNCIkmhyS4LK+caoU6p1+w== X-Received: by 2002:a05:6a00:1515:b0:640:e12a:3a20 with SMTP id q21-20020a056a00151500b00640e12a3a20mr1786945pfu.1.1682587689567; Thu, 27 Apr 2023 02:28:09 -0700 (PDT) Received: from sunil-laptop ([2409:4071:6e90:4e5:b276:2557:8da6:6c7e]) by smtp.gmail.com with ESMTPSA id u10-20020a62d44a000000b00637ca3eada8sm12756319pfl.6.2023.04.27.02.28.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Apr 2023 02:28:09 -0700 (PDT) Date: Thu, 27 Apr 2023 14:57:57 +0530 From: Sunil V L To: =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-acpi@vger.kernel.org, linux-crypto@vger.kernel.org, platform-driver-x86@vger.kernel.org, llvm@lists.linux.dev, Jonathan Corbet , Paul Walmsley , Palmer Dabbelt , Albert Ou , Len Brown , Daniel Lezcano , Thomas Gleixner , Weili Qian , Zhou Wang , Herbert Xu , Marc Zyngier , Maximilian Luz , Hans de Goede , Mark Gross , Nathan Chancellor , Nick Desaulniers , Tom Rix , "Rafael J . Wysocki" , "David S . Miller" , "Rafael J . Wysocki" Subject: Re: [PATCH V4 05/23] ACPI: OSL: Make should_use_kmap() 0 for RISC-V Message-ID: References: <20230404182037.863533-1-sunilvl@ventanamicro.com> <20230404182037.863533-6-sunilvl@ventanamicro.com> <87a5yua8vb.fsf@all.your.base.are.belong.to.us> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87a5yua8vb.fsf@all.your.base.are.belong.to.us> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Hi Bjorn, On Wed, Apr 26, 2023 at 06:47:20PM +0200, Björn Töpel wrote: > Sunil V L writes: > > > Without this, if the tables are larger than 4K, > > acpi_map() will fail. > > > > Signed-off-by: Sunil V L > > Acked-by: Rafael J. Wysocki > > --- > > drivers/acpi/osl.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c > > index 3269a888fb7a..f725813d0cce 100644 > > --- a/drivers/acpi/osl.c > > +++ b/drivers/acpi/osl.c > > @@ -276,7 +276,7 @@ acpi_map_lookup_virt(void __iomem *virt, acpi_size size) > > return NULL; > > } > > > > -#if defined(CONFIG_IA64) || defined(CONFIG_ARM64) > > +#if defined(CONFIG_IA64) || defined(CONFIG_ARM64) || defined(CONFIG_RISCV) > > /* ioremap will take care of cache attributes */ > > #define should_use_kmap(pfn) 0 > > An observation, which can be addressed later; The acpi_os_ioremap() > (called when the config above is enabled for RV), does not have an arch > specific implementation for RISC-V. The generic one calls > ioremap_cached(), which on RISC-V defaults to ioremap() -- caching > disabled/_PAGE_IO. > > That is probably not what we want, but rather something similar that > arm64 does. > Actually, for RISC-V acpi_os_ioremap() is currently a wrapper around memremap(). Sure, this can be enhanced in future if required. Thanks, Sunil