From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DE46C7EE22 for ; Fri, 5 May 2023 13:15:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232412AbjEENP1 (ORCPT ); Fri, 5 May 2023 09:15:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232386AbjEENPY (ORCPT ); Fri, 5 May 2023 09:15:24 -0400 Received: from m228-4.mailgun.net (m228-4.mailgun.net [159.135.228.4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DD5A1E9BF for ; Fri, 5 May 2023 06:15:20 -0700 (PDT) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=equiv.tech; q=dns/txt; s=mx; t=1683292520; x=1683299720; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Subject: Cc: To: To: From: From: Date: Sender: Sender; bh=WDYF6zI6A8OgkexxWkY88lLpFyBLDctri05ND1Dd0Zc=; b=fXtkMs064kya+6RpMb5Rst1QCs6BuPvpidmKVW0At3pFf/nDn0L21SbJbhssNVPX7aGUHXQMZOKxfqsPwnFSkeJGFU1w68OAsdL6p6Mj8wBXyHLgRDDk070jTTmFfBdhxRv9XRgrLFl0YRog5cPH5QWsbY9HLLhrSm7Qi7SbnC2l1ZvIEOZel/jJxwTN0EMohY5lCCNItjtxI8o2UEwir9j+0VaD/BOKSPPqJ0BVBff/WjTpk9m1tBAtULZ1FxZ0LFUu12TSn2LPh3KCXwsvDFCdhPiqtzPW3mdpT0K2nOV+FZuKf7tbR1DXegT78cQGamMAd6VO2FgH5DUnoE1Rng== X-Mailgun-Sending-Ip: 159.135.228.4 X-Mailgun-Sid: WyIxNjU3YyIsImxpbnV4LWRvY0B2Z2VyLmtlcm5lbC5vcmciLCI5M2Q1YWIiXQ== Received: from mail.equiv.tech (equiv.tech [142.93.28.83]) by 897f46a039a2 with SMTP id 645501688290b6a11e251401 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 05 May 2023 13:15:19 GMT Sender: james@equiv.tech Date: Fri, 5 May 2023 06:15:19 -0700 From: James Seo To: Guenter Roeck Cc: James Seo , Jean Delvare , Jonathan Corbet , linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC 02/11] hwmon: (core) Rename last parameter of devm_hwmon_register_with_info() Message-ID: References: <20230504075752.1320967-1-james@equiv.tech> <20230504075752.1320967-3-james@equiv.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Thu, May 04, 2023 at 08:29:57AM -0700, Guenter Roeck wrote: > Please please please no such changes. I don't want to have to deal with > patch wars just because people believe variables should have other names. > > Such changes add zero value unless one counts wasted review time as a "value". > > Guenter > Hello, Of course arbitrarily changing variable names is pointless. But this patch fulfills the intent of 848ba0a2f20dc121a3ef5272a24641d2bd963d8b, which makes this change for devm_hwmon_device_register_with_info() in hwmon-kernel-api.txt and in hwmon.h - but not in hwmon.c. The same commit makes the same change for hwmon_device_register_with_info() in all three files, so it obviously should have been in tree already. The other reason for this patch is that for the purpose of generating function documentation from kerneldocs, it is not feasible to call this parameter "extra_groups" in the kerneldoc and still call it "groups" in the function itself. Doing so results in the lines "const struct attribute_group **groups / undescribed" and no mention of "extra_groups" in the generated document. Leaving things as is, so that [devm_]hwmon_device_register_with_info() have different names for this parameter, is potentially confusing and more noticeable to to the eye than I would like once rendered. Is this good enough to proceed? And as a subsystem maintainer, is there anything else, specifically or in general, that you would like to see addressed? James