From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F329AC7EE2E for ; Sun, 11 Jun 2023 10:01:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229583AbjFKKBX (ORCPT ); Sun, 11 Jun 2023 06:01:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231254AbjFKKBT (ORCPT ); Sun, 11 Jun 2023 06:01:19 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8987919BB for ; Sun, 11 Jun 2023 03:01:16 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-5169f920a9dso6904177a12.0 for ; Sun, 11 Jun 2023 03:01:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1686477675; x=1689069675; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=U7HN0f6TOWWkr11pJT0tfFyGZ1Me6eKxGL1ZqHz5p/E=; b=CK+40rDIEO4qBWIjslHU71w2FzcpmL66yJ2ffo8QNiGyJVgjt2njdUY13r8vlWLyRh bFzF3aspyFifeybgeAm5JsTbvM0Y0U+htlNyMhY4rZdso0DpijNINO8CzRHkG4h6vTm2 qDNewH1UtM2COGT2JZr0R53kucC4xe+Scno8vkuo9GrhvTpVhzxcRtNBK/Aq+CslaRWL 6hGnkuO6xqG3ciKigTB9qYkhGVxQ+wJ/f/yVK+VC1tnSVF3wpmP3pZLfGG23kH9vlrXt mefPq9PTmMZ08D7NdNkgeJfPZ4BFv+VTpfc09VRr8QF7C3rGqDJ7tFv5INdS55jkARsQ vZYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686477675; x=1689069675; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=U7HN0f6TOWWkr11pJT0tfFyGZ1Me6eKxGL1ZqHz5p/E=; b=THcmvCXFf7zOAUsKuG+afoKvc1gHT8nnuaJ+WYzqO8trkGseC7VuF0SWnYxejSjB3r 5JggPSyavKE8YiYaAxQsmMiv4QLU8NwXsK7YdIPH1P4MXLGe9lisqSxqaxzXBztrl36a PRbZwO4YGYCS5JxHevOszNHS7AHtdUKpjcWki8by9iYA4C46E1wFwJU1yGMM/y1rcSX5 rFEPuMMo70Ft+mIUMlwdiscgt7v1KggkOG32hgck2pWa7PXevPcqB+sNbqxn/kM0yJqw oOkc577uqfeZNX4zfAWK4tRnd7epreWDQru+ydH1Ieb2pzQUbVdUZCk3pKfrPmpqYxD9 cgQg== X-Gm-Message-State: AC+VfDx0FMIa3AxhfiTgx3UfSxVxyEUgUpBgFKjpmKKI2yYILE9JZakn qYCzp7AmNlF/MU3nMQPYQkSdKA== X-Google-Smtp-Source: ACHHUZ5gWuO7BIceLcmBKNYkMGao9xFPw4XyyBHtMY8YchWoEkZuudgzgArbFrxLghboz06yhmTvFA== X-Received: by 2002:a05:6402:520a:b0:516:a1d5:846f with SMTP id s10-20020a056402520a00b00516a1d5846fmr3286182edd.1.1686477674815; Sun, 11 Jun 2023 03:01:14 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id c7-20020aa7df07000000b00514b854c399sm3744198edy.84.2023.06.11.03.01.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jun 2023 03:01:13 -0700 (PDT) Date: Sun, 11 Jun 2023 12:01:12 +0200 From: Jiri Pirko To: Arkadiusz Kubalewski Cc: kuba@kernel.org, vadfed@meta.com, jonathan.lemon@gmail.com, pabeni@redhat.com, corbet@lwn.net, davem@davemloft.net, edumazet@google.com, vadfed@fb.com, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, saeedm@nvidia.com, leon@kernel.org, richardcochran@gmail.com, sj@kernel.org, javierm@redhat.com, ricardo.canuelo@collabora.com, mst@redhat.com, tzimmermann@suse.de, michal.michalik@intel.com, gregkh@linuxfoundation.org, jacek.lawrynowicz@linux.intel.com, airlied@redhat.com, ogabbay@kernel.org, arnd@arndb.de, nipun.gupta@amd.com, axboe@kernel.dk, linux@zary.sk, masahiroy@kernel.org, benjamin.tissoires@redhat.com, geert+renesas@glider.be, milena.olech@intel.com, kuniyu@amazon.com, liuhangbin@gmail.com, hkallweit1@gmail.com, andy.ren@getcruise.com, razor@blackwall.org, idosch@nvidia.com, lucien.xin@gmail.com, nicolas.dichtel@6wind.com, phil@nwl.cc, claudiajkang@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-arm-kernel@lists.infradead.org, poros@redhat.com, mschmidt@redhat.com, linux-clk@vger.kernel.org, vadim.fedorenko@linux.dev Subject: Re: [RFC PATCH v8 03/10] dpll: core: Add DPLL framework base functions Message-ID: References: <20230609121853.3607724-1-arkadiusz.kubalewski@intel.com> <20230609121853.3607724-4-arkadiusz.kubalewski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230609121853.3607724-4-arkadiusz.kubalewski@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Fri, Jun 09, 2023 at 02:18:46PM CEST, arkadiusz.kubalewski@intel.com wrote: >From: Vadim Fedorenko [...] >+ * dpll_xa_ref_dpll_first - find first record of given xarray >+ * @xa_refs: xarray >+ * >+ * Context: shall be called under a lock (dpll_lock) >+ * Return: first element on given xaaray typo: xarray >+ */ >+struct dpll_pin_ref *dpll_xa_ref_dpll_first(struct xarray *xa_refs) [...] >+/** >+ * dpll_device_get - find existing or create new dpll device >+ * @clock_id: clock_id of creator >+ * @device_idx: idx given by device driver >+ * @module: reference to registering module >+ * >+ * Get existing object of a dpll device, unique for given arguments. >+ * Create new if doesn't exist yet. >+ * >+ * Context: Acquires a lock (dpll_lock) >+ * Return: >+ * * valid dpll_device struct pointer if succeeded >+ * * ERR_PTR(-ENOMEM) - failed memory allocation Yeah, that is kind of obvious, isn't? Really, drop this pointless coments. >+ * * ERR_PTR(X) - failed allocation on dpll's xa >+ */ >+struct dpll_device * >+dpll_device_get(u64 clock_id, u32 device_idx, struct module *module) [...] >+/** >+ * dpll_pin_register - register the dpll pin in the subsystem >+ * @dpll: pointer to a dpll >+ * @pin: pointer to a dpll pin >+ * @ops: ops for a dpll pin ops >+ * @priv: pointer to private information of owner >+ * >+ * Context: Acquires a lock (dpll_lock) >+ * Return: >+ * * 0 on success >+ * * -EINVAL - missing pin ops >+ * * -ENOMEM - failed to allocate memory Does not make sense to assign one errno to one specific error. Avoid tables like this. >+ */ >+int >+dpll_pin_register(struct dpll_device *dpll, struct dpll_pin *pin, >+ const struct dpll_pin_ops *ops, void *priv) >+{ >+ int ret; >+ >+ mutex_lock(&dpll_lock); >+ if (WARN_ON(!(dpll->module == pin->module && >+ dpll->clock_id == pin->clock_id))) >+ ret = -EFAULT; -EINVAL; >+ else >+ ret = __dpll_pin_register(dpll, pin, ops, priv); >+ mutex_unlock(&dpll_lock); >+ >+ return ret; >+} [...]