* [PATCH] Documentation: virt: correct location of haltpoll module params
@ 2023-06-10 5:43 Randy Dunlap
2023-06-12 1:33 ` Bagas Sanjaya
2023-06-12 14:24 ` Marcelo Tosatti
0 siblings, 2 replies; 4+ messages in thread
From: Randy Dunlap @ 2023-06-10 5:43 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Marcelo Tosatti, Rafael J. Wysocki, Jonathan Corbet,
linux-doc
Module parameters are located in sysfs, not debugfs, so correct the
statement.
Fixes: 2cffe9f6b96f ("cpuidle: add haltpoll governor")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org
---
Documentation/virt/guest-halt-polling.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -- a/Documentation/virt/guest-halt-polling.rst b/Documentation/virt/guest-halt-polling.rst
--- a/Documentation/virt/guest-halt-polling.rst
+++ b/Documentation/virt/guest-halt-polling.rst
@@ -72,7 +72,7 @@ high once achieves global guest_halt_pol
Default: Y
-The module parameters can be set from the debugfs files in::
+The module parameters can be set from the sysfs files in::
/sys/module/haltpoll/parameters/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Documentation: virt: correct location of haltpoll module params
2023-06-10 5:43 [PATCH] Documentation: virt: correct location of haltpoll module params Randy Dunlap
@ 2023-06-12 1:33 ` Bagas Sanjaya
2023-06-12 14:24 ` Marcelo Tosatti
1 sibling, 0 replies; 4+ messages in thread
From: Bagas Sanjaya @ 2023-06-12 1:33 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Marcelo Tosatti, Rafael J. Wysocki, Jonathan Corbet, linux-doc
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
On Fri, Jun 09, 2023 at 10:43:02PM -0700, Randy Dunlap wrote:
> diff -- a/Documentation/virt/guest-halt-polling.rst b/Documentation/virt/guest-halt-polling.rst
> --- a/Documentation/virt/guest-halt-polling.rst
> +++ b/Documentation/virt/guest-halt-polling.rst
> @@ -72,7 +72,7 @@ high once achieves global guest_halt_pol
>
> Default: Y
>
> -The module parameters can be set from the debugfs files in::
> +The module parameters can be set from the sysfs files in::
>
> /sys/module/haltpoll/parameters/
>
LGTM, thanks!
Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Documentation: virt: correct location of haltpoll module params
2023-06-10 5:43 [PATCH] Documentation: virt: correct location of haltpoll module params Randy Dunlap
2023-06-12 1:33 ` Bagas Sanjaya
@ 2023-06-12 14:24 ` Marcelo Tosatti
2023-06-16 14:18 ` Jonathan Corbet
1 sibling, 1 reply; 4+ messages in thread
From: Marcelo Tosatti @ 2023-06-12 14:24 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel, Rafael J. Wysocki, Jonathan Corbet, linux-doc
On Fri, Jun 09, 2023 at 10:43:02PM -0700, Randy Dunlap wrote:
> Module parameters are located in sysfs, not debugfs, so correct the
> statement.
>
> Fixes: 2cffe9f6b96f ("cpuidle: add haltpoll governor")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Marcelo Tosatti <mtosatti@redhat.com>
> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: linux-doc@vger.kernel.org
> ---
> Documentation/virt/guest-halt-polling.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -- a/Documentation/virt/guest-halt-polling.rst b/Documentation/virt/guest-halt-polling.rst
> --- a/Documentation/virt/guest-halt-polling.rst
> +++ b/Documentation/virt/guest-halt-polling.rst
> @@ -72,7 +72,7 @@ high once achieves global guest_halt_pol
>
> Default: Y
>
> -The module parameters can be set from the debugfs files in::
> +The module parameters can be set from the sysfs files in::
>
> /sys/module/haltpoll/parameters/
>
>
>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Documentation: virt: correct location of haltpoll module params
2023-06-12 14:24 ` Marcelo Tosatti
@ 2023-06-16 14:18 ` Jonathan Corbet
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Corbet @ 2023-06-16 14:18 UTC (permalink / raw)
To: Marcelo Tosatti, Randy Dunlap; +Cc: linux-kernel, Rafael J. Wysocki, linux-doc
Marcelo Tosatti <mtosatti@redhat.com> writes:
> On Fri, Jun 09, 2023 at 10:43:02PM -0700, Randy Dunlap wrote:
>> Module parameters are located in sysfs, not debugfs, so correct the
>> statement.
>>
>> Fixes: 2cffe9f6b96f ("cpuidle: add haltpoll governor")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Marcelo Tosatti <mtosatti@redhat.com>
>> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
>> Cc: Jonathan Corbet <corbet@lwn.net>
>> Cc: linux-doc@vger.kernel.org
>> ---
>> Documentation/virt/guest-halt-polling.rst | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff -- a/Documentation/virt/guest-halt-polling.rst b/Documentation/virt/guest-halt-polling.rst
>> --- a/Documentation/virt/guest-halt-polling.rst
>> +++ b/Documentation/virt/guest-halt-polling.rst
>> @@ -72,7 +72,7 @@ high once achieves global guest_halt_pol
>>
>> Default: Y
>>
>> -The module parameters can be set from the debugfs files in::
>> +The module parameters can be set from the sysfs files in::
>>
>> /sys/module/haltpoll/parameters/
>>
>>
>>
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
I'm not sure why you're offering a signoff for Randy's patch...?
In any case, I've taken this as an ack and applied it.
Thanks,
jon
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-16 14:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-10 5:43 [PATCH] Documentation: virt: correct location of haltpoll module params Randy Dunlap
2023-06-12 1:33 ` Bagas Sanjaya
2023-06-12 14:24 ` Marcelo Tosatti
2023-06-16 14:18 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).