From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E312EB64DD for ; Thu, 29 Jun 2023 06:14:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231169AbjF2GOd (ORCPT ); Thu, 29 Jun 2023 02:14:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230476AbjF2GOb (ORCPT ); Thu, 29 Jun 2023 02:14:31 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CCC12693 for ; Wed, 28 Jun 2023 23:14:29 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-314172bb818so317625f8f.1 for ; Wed, 28 Jun 2023 23:14:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1688019267; x=1690611267; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BxPmChzKXR1dj/ko+9tzcHvICaNxDCij9PscVU1CwGY=; b=g4spu/YTypGbdobXCPpsNMEE7fZgSTh6dwO8ck/RlyJzKG32ec8qbcH4voInoYNI6o nG6/zJ1n82WItH1lu3qQCRFI8uw3L8ph8dhnODO74Jobt9mAAC6aVPmcAOEeHa3CijaY GQ0EQQTgLWtAzMyQV8sZkz9pP1Q5sB+jGzX0IRtVzmIH7vRZDqd7kAqk/QYf3QTa8aEJ QSuo/h0rl0fcrDEeomgjT4HhlbHIS1Bzm651nwZXtQyAM08WdVMOLO0uppwo8McOoT1j 8CGh366oXSh0q2wYy6HTFoOLtXKgeVtSm3qpnqhqbheagjwO+/UJVS4tnevaSr7XLabv Rrig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688019267; x=1690611267; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BxPmChzKXR1dj/ko+9tzcHvICaNxDCij9PscVU1CwGY=; b=Sn0oaQ452k80ZoKKnszO4HZhiW4kc6EiLQXWV+sKceGHQYgLR9tBSqu6CmQhn9kVrd c2zvFGOI6GsBrx2sbClS9helry9vKfNzhVPmbfPx4fFZarPMmdatQ90VLeDcWiB9jFow MCJ71gqAj0tlZL4DQDXfKW5DH4WnlWqjuXieeiPiXhbJB4pOPw0yW0VvgRoKhx4wBVk4 WDBFt6o0kAz5dgVgcM5tOquxtcX1bJvmOjRoKWNXmQskTzFZ0iwLTqnLpddggt9xnntP Pj+Rf1Tlo/SA447oxwNH//axEtO7jo+sMZ9dE2jbIvMuGxNHl5FCtaHvibH8MU2ZV4d+ U0xQ== X-Gm-Message-State: AC+VfDzk+AGlLZ2DtQGWXD0d2uhmIY5wLusJmckNHKiUpxJN+QoC7RxN 4jQ5MOqlA0S3oePIUv8cACINnw== X-Google-Smtp-Source: ACHHUZ7KKCQek3b9yJkpoCmAdgzst9lXvnl9IF1wrn2teksRP3fkGVdr25X0T5kABFTNqxM9KgVooQ== X-Received: by 2002:a05:6000:181:b0:30f:d218:584a with SMTP id p1-20020a056000018100b0030fd218584amr32939868wrx.23.1688019267545; Wed, 28 Jun 2023 23:14:27 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id b7-20020a5d45c7000000b003141a3c4353sm460558wrs.30.2023.06.28.23.14.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jun 2023 23:14:26 -0700 (PDT) Date: Thu, 29 Jun 2023 08:14:25 +0200 From: Jiri Pirko To: "Kubalewski, Arkadiusz" Cc: "kuba@kernel.org" , "vadfed@meta.com" , "jonathan.lemon@gmail.com" , "pabeni@redhat.com" , "corbet@lwn.net" , "davem@davemloft.net" , "edumazet@google.com" , "vadfed@fb.com" , "Brandeburg, Jesse" , "Nguyen, Anthony L" , "M, Saeed" , "leon@kernel.org" , "richardcochran@gmail.com" , "sj@kernel.org" , "javierm@redhat.com" , "ricardo.canuelo@collabora.com" , "mst@redhat.com" , "tzimmermann@suse.de" , "Michalik, Michal" , "gregkh@linuxfoundation.org" , "jacek.lawrynowicz@linux.intel.com" , "airlied@redhat.com" , "ogabbay@kernel.org" , "arnd@arndb.de" , "nipun.gupta@amd.com" , "axboe@kernel.dk" , "linux@zary.sk" , "masahiroy@kernel.org" , "benjamin.tissoires@redhat.com" , "geert+renesas@glider.be" , "Olech, Milena" , "kuniyu@amazon.com" , "liuhangbin@gmail.com" , "hkallweit1@gmail.com" , "andy.ren@getcruise.com" , "razor@blackwall.org" , "idosch@nvidia.com" , "lucien.xin@gmail.com" , "nicolas.dichtel@6wind.com" , "phil@nwl.cc" , "claudiajkang@gmail.com" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" , "linux-rdma@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , poros , mschmidt , "linux-clk@vger.kernel.org" , "vadim.fedorenko@linux.dev" Subject: Re: [RFC PATCH v8 08/10] ice: implement dpll interface to control cgu Message-ID: References: <20230609121853.3607724-1-arkadiusz.kubalewski@intel.com> <20230609121853.3607724-9-arkadiusz.kubalewski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Wed, Jun 21, 2023 at 02:29:59PM CEST, jiri@resnulli.us wrote: >Mon, Jun 19, 2023 at 10:34:12PM CEST, arkadiusz.kubalewski@intel.com wrote: >>>From: Jiri Pirko >>>Sent: Saturday, June 10, 2023 6:37 PM >>> >>>Fri, Jun 09, 2023 at 02:18:51PM CEST, arkadiusz.kubalewski@intel.com wrote: >>> >>>[...] >>> >>> >>>>+static int ice_dpll_mode_get(const struct dpll_device *dpll, void *priv, >>>>+ enum dpll_mode *mode, >>>>+ struct netlink_ext_ack *extack) >>>>+{ >>>>+ *mode = DPLL_MODE_AUTOMATIC; >>> >>>I don't understand how the automatic mode could work with SyncE. The >>>There is one pin exposed for one netdev. The SyncE daemon should select >>>exacly one pin. How do you achieve that? >>>Is is by setting DPLL_PIN_STATE_SELECTABLE on the pin-netdev you want to >>>select and DPLL_PIN_STATE_DISCONNECTED on the rest? >>> >>> >>>[...] >> >>AUTOMATIC mode autoselects highest priority valid signal. >>As you have pointed out, for SyncE selection, the user must be able to manually >>select a pin state to enable recovery of signal from particular port. >> >>In "ice" case there are 2 pins for network PHY clock signal recovery, and both >>are parent pins (MUX-type). There are also 4 pins assigned to netdevs (one per >>port). Thus passing a signal from PHY to the pin is done through the MUX-pin, >>by selecting proper state on pin-parent pair (where parent pins is highest prio >>pin on dpll). > >Could you show me some examples please? Arkadiusz, could you please reply to this? Thanks! > > >> >>Thank you! >>Arkadiusz