From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54981EB64DC for ; Wed, 28 Jun 2023 13:10:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231379AbjF1NKA (ORCPT ); Wed, 28 Jun 2023 09:10:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231536AbjF1NJ4 (ORCPT ); Wed, 28 Jun 2023 09:09:56 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 648952121 for ; Wed, 28 Jun 2023 06:09:54 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-51d9890f368so4056809a12.2 for ; Wed, 28 Jun 2023 06:09:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1687957793; x=1690549793; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=k76YrPTzyyjATZAkPWsngOApRdksnz4938tVnCuwxy0=; b=ScgYnUQe6P6kGA/N6ZPo3yO417tWRwpx3GvemyrdtyZVRiMKBb3mX7VI2GC9diLcMu CBglKEUKyw7sx2XjP/XbJOD3iNnN+N9GWxQ1mlTSXafAi8ZUGZ1eDbHmnkr5clkYOrjz 8GDQoZ2Tp1PraxZ/pmeSyq/QVCRc/QRFE5TFbBS9xF88g2abpug24dt9lgXFX5GM+yij RiioISv2/N2ZwCj6vMlrza/ubjNUMvoHHzw+bfeT37sBUEtzdgN4KJIymYZ3Ku4VDzhk Mj4zVAxzoFL1AljyNcajNKEfjlIxauzw/vVgq7tTHszhYZyGB1ntaUvlngn31dONZgTd zmEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687957793; x=1690549793; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=k76YrPTzyyjATZAkPWsngOApRdksnz4938tVnCuwxy0=; b=Dj8o0MzO6sgxmDUuflIh3q1XuIuq6EWSITxp1iFZKO9q5OL4tgq0tghssGxSoJLtNz 44yiF9nay0vSR9UyRczZBMDXey2xI8chEoupZzI8AFRA2QP6zUa190+xReWyqUwlqmXS uygF556u6bmJxrUL2B+30kp1/dw9fc+CS5ikc5tp+c3zzk5KSmOthldPI+FtDJ82fEmr v5dbutj/nCr2jooKnBrLKKJqARi1b2R4zSOLPMPxmCxrCsEYSu2ukfjs/Y8MivGwqbcq X7gIH58dcUpgrFMzbVdH/4lmF91+xvCoYDDzWEct2Fcqc0Pq71hHDZXXgZw99ZIJuLo1 c0wQ== X-Gm-Message-State: AC+VfDwD9oHj+eXKL1g6v8fDlPjPFBTVaL8oMEFX8hN1ZOZ16VV2w0Lv 8goodjLzi4VdO+Lj7MUE8fhi1Q== X-Google-Smtp-Source: ACHHUZ4FQ7JmqxI+YoYuBXCwpW4UP8TYDQSff2DdAMDuypxC1caOuVE2XCGI/Z0rJ4e0navjgsMuwg== X-Received: by 2002:a05:6402:1496:b0:51d:91ef:c836 with SMTP id e22-20020a056402149600b0051d91efc836mr6548808edv.32.1687957792701; Wed, 28 Jun 2023 06:09:52 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id s19-20020a056402165300b0051d9df5dd2fsm2609023edx.72.2023.06.28.06.09.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jun 2023 06:09:51 -0700 (PDT) Date: Wed, 28 Jun 2023 15:09:50 +0200 From: Jiri Pirko To: Vadim Fedorenko Cc: "Kubalewski, Arkadiusz" , "kuba@kernel.org" , "vadfed@meta.com" , "jonathan.lemon@gmail.com" , "pabeni@redhat.com" , "corbet@lwn.net" , "davem@davemloft.net" , "edumazet@google.com" , "vadfed@fb.com" , "Brandeburg, Jesse" , "Nguyen, Anthony L" , "M, Saeed" , "leon@kernel.org" , "richardcochran@gmail.com" , "sj@kernel.org" , "javierm@redhat.com" , "ricardo.canuelo@collabora.com" , "mst@redhat.com" , "tzimmermann@suse.de" , "Michalik, Michal" , "gregkh@linuxfoundation.org" , "jacek.lawrynowicz@linux.intel.com" , "airlied@redhat.com" , "ogabbay@kernel.org" , "arnd@arndb.de" , "nipun.gupta@amd.com" , "axboe@kernel.dk" , "linux@zary.sk" , "masahiroy@kernel.org" , "benjamin.tissoires@redhat.com" , "geert+renesas@glider.be" , "Olech, Milena" , "kuniyu@amazon.com" , "liuhangbin@gmail.com" , "hkallweit1@gmail.com" , "andy.ren@getcruise.com" , "razor@blackwall.org" , "idosch@nvidia.com" , "lucien.xin@gmail.com" , "nicolas.dichtel@6wind.com" , "phil@nwl.cc" , "claudiajkang@gmail.com" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" , "linux-rdma@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , poros , mschmidt , "linux-clk@vger.kernel.org" Subject: Re: [RFC PATCH v9 00/10] Create common DPLL configuration API Message-ID: References: <20230623123820.42850-1-arkadiusz.kubalewski@intel.com> <2e9ce197-2732-d061-b11d-4f4513af6abc@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2e9ce197-2732-d061-b11d-4f4513af6abc@linux.dev> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Wed, Jun 28, 2023 at 01:11:19PM CEST, vadim.fedorenko@linux.dev wrote: >On 28/06/2023 10:27, Kubalewski, Arkadiusz wrote: >> > From: Kubalewski, Arkadiusz >> > Sent: Wednesday, June 28, 2023 11:15 AM >> > >> > > From: Jiri Pirko >> > > Sent: Tuesday, June 27, 2023 12:18 PM >> > > >> > > Fri, Jun 23, 2023 at 02:38:10PM CEST, arkadiusz.kubalewski@intel.com >> > wrote: >> > > >> > > > v8 -> v9: >> > > >> > > Could you please address all the unresolved issues from v8 and send v10? >> > > I'm not reviewing this one. >> > > >> > > Thanks! >> > >> > Sure, will do, but first missing to-do/discuss list: >> > 1) remove mode_set as not used by any driver >> > 2) remove "no-added-value" static functions descriptions in >> > dpll_core/dpll_netlink >> > 3) merge patches [ 03/10, 04/10, 05/10 ] into patches that are compiling >> > after each patch apply >> > 4) remove function return values descriptions/lists >> > 5) Fix patch [05/10]: >> > - status Supported >> > - additional maintainers >> > - remove callback: >> > int (*source_pin_idx_get)(...) from `struct dpll_device_ops` >> > 6) Fix patch [08/10]: rethink ice mutex locking scheme >> > 7) Fix patch [09/10]: multiple comments on >> > https://lore.kernel.org/netdev/ZIQu+%2Fo4J0ZBspVg@nanopsycho/#t >> > 8) add PPS DPLL phase offset to the netlink get-device API >> > >> > Thank you! >> > Arkadiusz >> >> If someone has any objections please state them now, I will work on >> all above except 5) and 7). >> Vadim, could you take care of those 2 points? >> >Yeah, sure, I'll update 5 and 7. >I'm not sure about 8) - do we really need this info, I believe every >supported DPLL device exports PTP device as well. But I'm Ok to add this >feature too. Could you add the notification work while you are at it? I don't want that to be forgotten. Thanks! > >> Thank you! >> Arkadiusz >