Re: [PATCH v3 7/8] selftests/mm: refactor uffd_poll_thread to allow custom fault handlers

Axel Rasmussen
2023-07-07T17:04:45Z

On Fri, Jul 7, 2023 at 6:42 AM Peter Xu <peterx@redhat.com> wrote:
>
> On Thu, Jul 06, 2023 at 03:50:35PM -0700, Axel Rasmussen wrote:
> > @@ -247,9 +245,13 @@ static int userfaultfd_stress(void)
> > {
> > void *area;
> > unsigned long nr;
> > - struct uffd_args args[nr_cpus];
> > + struct uffd_args *args;
> > uint64_t mem_size = nr_pages * page_size;
> >
> > + args = calloc(nr_cpus, sizeof(struct uffd_args));
> > + if (!args)
> > + err("allocating args array failed");
>
> This is trivial, but I think I requested a "free" (or keep it allocate on
> stack) in previous version but it didn't get a response on why we cannot
> and it kept going.. could you help explain?

Oh, sorry! I had meant to change this after our discussion, and simply
overlooked it while reworking the patches.

I'll include this change in a v4 which also addresses e.g. the
comments on commit 1.

>
> --
> Peter Xu
>