From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26A40EB64DD for ; Sat, 8 Jul 2023 15:01:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231265AbjGHPBh (ORCPT ); Sat, 8 Jul 2023 11:01:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231150AbjGHPBa (ORCPT ); Sat, 8 Jul 2023 11:01:30 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E539E61 for ; Sat, 8 Jul 2023 08:00:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688828443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vo+xktwiVBdnYZNSkVaZ1jBQzqcsS/NnXCqSzqSIy/s=; b=BbqeYdLP1JwSGDVXcyeT8FjIPFD/H/5WWbz5nEhl5RF6/ApR0jqBp6Y4g5vjFugT+UfMSu kQUONUlivpD457kWkNEzv12zEJFKkA1qL1RJsKIfkusBV4bPv22hqmXG/mSmBUt2HWRBe5 vQakVt/su68/+Is7wnltkOE3SrQ/5Eo= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-575-Vuj6B5c5OPSW80FC_szzuw-1; Sat, 08 Jul 2023 11:00:42 -0400 X-MC-Unique: Vuj6B5c5OPSW80FC_szzuw-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-635e2618aaeso5973216d6.0 for ; Sat, 08 Jul 2023 08:00:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688828441; x=1691420441; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vo+xktwiVBdnYZNSkVaZ1jBQzqcsS/NnXCqSzqSIy/s=; b=YhOw3the2GsgQaRvd3D8y7D2BT7K6RLnhKmm7fiHA3NMUqNDCh3U7uungnpWV8tcof PEoMyNtkP8BpIVDRqvwxvAPrS93p1W4bNWk7z4alH8my1KVdkjin7Dd2EOvTwFgkuc+r GxjMX1V3BxIKgW0KFOmTdW179EOwuPC/aU/IDkl37WUtkwBKHEdAB1qrR2K0OcJlKPIL lGapiE8UlNsmlPqCtCcV4Qvb9cxFM6PNVffGUvbbMGu/Gfwg2AoC/K1I+Qqi83pwCah4 uDlPoz3XCkFN9PtMZFb3V9RxcdXXai+K1v2Yhm2mP1juqzUmynUweJ/bdD/2sc5Z1G6r auWA== X-Gm-Message-State: ABy/qLZWp5mWaH6xTYWmMJXeRdqNQbACv4tAxUcp6lahZuxrPqaE+SiU 57M5WUWhlI09zz/rgy5Ldz4lBrxjJ7/s94kPyOA+OiCGXuY9yMXwg4gnSHypconm+DMwSeoavGI AVr828LgnoT3KRwUcThXi X-Received: by 2002:a05:6214:20cc:b0:635:da19:a67f with SMTP id 12-20020a05621420cc00b00635da19a67fmr8751518qve.1.1688828441396; Sat, 08 Jul 2023 08:00:41 -0700 (PDT) X-Google-Smtp-Source: APBJJlFkX6m7GxhH9s94whBzq2AYzdzEBV2j5KQt1+Wi1Rfa+0O1g5J2LP1pKpldyxPAC+GVDL2kcA== X-Received: by 2002:a05:6214:20cc:b0:635:da19:a67f with SMTP id 12-20020a05621420cc00b00635da19a67fmr8751500qve.1.1688828441141; Sat, 08 Jul 2023 08:00:41 -0700 (PDT) Received: from xz-m1.local (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id e12-20020a0caa4c000000b0063627a022b0sm3467336qvb.49.2023.07.08.08.00.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Jul 2023 08:00:40 -0700 (PDT) Date: Sat, 8 Jul 2023 11:00:38 -0400 From: Peter Xu To: Axel Rasmussen Cc: Alexander Viro , Andrew Morton , Brian Geffon , Christian Brauner , David Hildenbrand , Gaosheng Cui , Huang Ying , Hugh Dickins , James Houghton , "Jan Alexander Steffens (heftig)" , Jiaqi Yan , Jonathan Corbet , Kefeng Wang , "Liam R. Howlett" , Miaohe Lin , Mike Kravetz , "Mike Rapoport (IBM)" , Muchun Song , Nadav Amit , Naoya Horiguchi , Ryan Roberts , Shuah Khan , Suleiman Souhlal , Suren Baghdasaryan , "T.J. Alumbaugh" , Yu Zhao , ZhangPeng , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v4 1/8] mm: make PTE_MARKER_SWAPIN_ERROR more general Message-ID: References: <20230707215540.2324998-1-axelrasmussen@google.com> <20230707215540.2324998-2-axelrasmussen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230707215540.2324998-2-axelrasmussen@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Fri, Jul 07, 2023 at 02:55:33PM -0700, Axel Rasmussen wrote: > -static inline swp_entry_t make_swapin_error_entry(void) > +static inline swp_entry_t make_poisoned_swp_entry(void) > { > - return make_pte_marker_entry(PTE_MARKER_SWAPIN_ERROR); > + return make_pte_marker_entry(PTE_MARKER_POISONED); > } > > -static inline int is_swapin_error_entry(swp_entry_t entry) > +static inline int is_poisoned_swp_entry(swp_entry_t entry) > { > return is_pte_marker_entry(entry) && > - (pte_marker_get(entry) & PTE_MARKER_SWAPIN_ERROR); > + (pte_marker_get(entry) & PTE_MARKER_POISONED); > } These two can be slightly confusing when put together with hwpoison entries, so maybe it'll be good to somehow attach a "marker" inside the names: make_poisoned_marker_entry() is_pointed_marker_entry() (the old helpers didn't attach a "marker" keyword because we started with consuming a swp entry type, I think) But we can still identify easily with "hw" prefix being there or not, so it's still pretty clear at least to me. I'd say not worth a repost, so your call to keep or change, just in case a new version for other reasons. All fine here now: Acked-by: Peter Xu Thanks, -- Peter Xu