From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1618EB64DC for ; Tue, 18 Jul 2023 23:05:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229570AbjGRXFd (ORCPT ); Tue, 18 Jul 2023 19:05:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230148AbjGRXFc (ORCPT ); Tue, 18 Jul 2023 19:05:32 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95D12A1; Tue, 18 Jul 2023 16:05:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689721528; x=1721257528; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=VhODeFD5Y7nvrP5kQrGvm1ObDGUld/Q0gKN5ouYFzwo=; b=EYf09KGQ1i2tr65SM3tQBrNtiTralvGQP7oeoarWNABXVcTXwv36eZyq +aQ1tdkaSRZT3lxwqA2y/3ZeimajPxePWPojDF322lKhHLFZngHxpTvdj sS93Pa5RSYoqoleMMharzewUYriW1sMaVQqHmIr/EczyghmMXdJYLyvvb 0PFrruiInCEC+WXwtBPYkJx/RqYXCCEc8Nx/d+JfGihWtExTjJNm7tcJ6 lXTwOCQlcwjii/bB4AzqH41D1CJ0IaF2tap6sEllRRB5g0T9fCo+cpJNh 91wc3NTcve3gs/s+wuix9/y06SSx6TThsQ5nbOfAC+tqLeAX8crv1BlJB w==; X-IronPort-AV: E=McAfee;i="6600,9927,10775"; a="363790161" X-IronPort-AV: E=Sophos;i="6.01,215,1684825200"; d="scan'208";a="363790161" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2023 16:05:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10775"; a="897711266" X-IronPort-AV: E=Sophos;i="6.01,215,1684825200"; d="scan'208";a="897711266" Received: from agluck-desk3.sc.intel.com (HELO agluck-desk3) ([172.25.222.74]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2023 16:05:27 -0700 Date: Tue, 18 Jul 2023 16:05:26 -0700 From: Tony Luck To: Reinette Chatre Cc: Fenghua Yu , Peter Newman , Jonathan Corbet , Shuah Khan , x86@kernel.org, Shaopeng Tan , James Morse , Jamie Iles , Babu Moger , Randy Dunlap , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, patches@lists.linux.dev Subject: Re: [PATCH v3 5/8] x86/resctrl: Add package scoped resource Message-ID: References: <20230713163207.219710-1-tony.luck@intel.com> <20230713163207.219710-6-tony.luck@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Tue, Jul 18, 2023 at 01:43:45PM -0700, Reinette Chatre wrote: > Hi Tony, > > On 7/13/2023 9:32 AM, Tony Luck wrote: > > Some Intel features require setting a package scoped model specific > > register. > > > > Add a new resource that builds domains for each package. > > If I understand correctly the only purpose of this new resource > is to know when the first CPU associated with a package > comes online. Am I not reading this right? Using a resctrl resource > for this purpose seems inappropriate and unnecessary while also > making the code very hard to follow. Reinette, Yes. You understand. I agree that this is blatant abuse of the resource structures. I can find another way to perform an action on the first CPU of a package online, and the last CPU of a package offline. -Tony