From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85A90C04A94 for ; Fri, 4 Aug 2023 08:23:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234492AbjHDIXp (ORCPT ); Fri, 4 Aug 2023 04:23:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234504AbjHDIXm (ORCPT ); Fri, 4 Aug 2023 04:23:42 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06EDA468A for ; Fri, 4 Aug 2023 01:23:39 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1bb893e6365so12706145ad.2 for ; Fri, 04 Aug 2023 01:23:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1691137419; x=1691742219; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=U1iCEOYYU/TuYkpsVb8VVtB172iQ0uWVvB+JeREIxpo=; b=mNBCtcy+pGxfsWGwe4DsVuDy0NZiV99ZQ4y9rP1aAfOeel/kt5pokMEdhS81rp7emX 4q6NJxqkNJzQZR5RnuPibbIx0v6AbybMa3VEwgggL6fAkUhefeZhI2/Gz4Q4xac1Hu6h 8MjfYa3JyEeMVEGBK5ZP+wO1LM8UPpCmHNXVAQxffB8VxXFoW2uSKKYQk2m9NR7CScok jix7R8iUOQ9P18rXExjcm9a74uPR2ME3+6gSWvBwejujKQMYqjSyJTaUsKXd3tTT7Ktp Ua49YNuBvi/++1M98fkf1zd8ApIbK50kwdYoWSkV7oJpm/agaVJjM+EgS7/TxqGrsKvq deDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691137419; x=1691742219; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=U1iCEOYYU/TuYkpsVb8VVtB172iQ0uWVvB+JeREIxpo=; b=jYliNhFxgHshriPKPb6uGC2NlCpGv4S3oC0H6r3xObf1OVV5b3z4060RHhbkGrS8bp Fv66o+e7btCE3298WtE/3dNor7bH/NF9fl7SNjUhiHdsYqP3rn7Bq397uW9pPtMCSOX2 r82JCbfE77rPs64C7jV1vUPMCSpihryB4qFyaeeSdAEFSZYlB7OG2TsPJsQsv0Be37OA +8lZTuBkSdTd4Qj0YKq0tagRqmubfJiEOVqIjbNBj/2elpgviQJig+rlTsMv3JFKSoXY Ir1NFc1+pBtWFGG5f7O3cXUdEtUBacAHuFGnPBpPB2X0kdnhvBZRylS8lOwJu0AqAVGn LpdQ== X-Gm-Message-State: AOJu0YzpwH5zwbWALGJlN9S2JrOYHPu6dJulXjNSG7o7c640GKi5wMSo +idAeWelrnPMPHLwlKEranMCIg== X-Google-Smtp-Source: AGHT+IErTrIrbgFzVl3JfKafZGO1uGvh7W7gOxEf+8QZhTVoODvh18JAAUR9r8v3VTYouOFQkb7gqw== X-Received: by 2002:a17:902:e5cb:b0:1bb:5b88:73da with SMTP id u11-20020a170902e5cb00b001bb5b8873damr906032plf.61.1691137419493; Fri, 04 Aug 2023 01:23:39 -0700 (PDT) Received: from sunil-laptop ([106.51.190.143]) by smtp.gmail.com with ESMTPSA id s13-20020a170902b18d00b001ac6b926621sm1138810plr.292.2023.08.04.01.23.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Aug 2023 01:23:39 -0700 (PDT) Date: Fri, 4 Aug 2023 13:53:26 +0530 From: Sunil V L To: Andy Shevchenko Cc: linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, Jonathan Corbet , Paul Walmsley , Palmer Dabbelt , Albert Ou , Catalin Marinas , Will Deacon , "Rafael J . Wysocki" , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , Daniel Lezcano , Thomas Gleixner , Anup Patel , Marc Zyngier , Bjorn Helgaas , Robert Moore , Haibo Xu , Andrew Jones , Conor Dooley , Atish Kumar Patra Subject: Re: [RFC PATCH v1 05/21] arm64: PCI: Migrate ACPI related functions to pci-acpi.c Message-ID: References: <20230803175916.3174453-1-sunilvl@ventanamicro.com> <20230803175916.3174453-6-sunilvl@ventanamicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Fri, Aug 04, 2023 at 08:53:14AM +0300, Andy Shevchenko wrote: > On Thu, Aug 03, 2023 at 11:29:00PM +0530, Sunil V L wrote: > > The functions defined in arm64 for ACPI support are required > > for RISC-V also. To avoid duplication, copy these functions > > to common location. > > ... > > > } > > + > > Stray change. > Let me remove this in next version. > > arch_initcall(acpi_pci_init); > > + > > +#if defined(CONFIG_ARM64) > > ... > > > + cfg = pci_ecam_create(dev, &cfgres, bus_res, ecam_ops); > > + if (IS_ERR(cfg)) { > > + dev_err(dev, "%04x:%pR error %ld mapping ECAM\n", seg, bus_res, > > + PTR_ERR(cfg)); > > + return NULL; > > + } > > + > > + return cfg; > > Can be > > cfg = pci_ecam_create(dev, &cfgres, bus_res, ecam_ops); > ret = PTR_ERR_OR_ZERO(cfg); > if (ret) { > dev_err(dev, "%04x:%pR error %d mapping ECAM\n", seg, bus_res, ret); > > but as far as I understand this is in the original code like this, so consider > as a suggestion for further cleanups. > Good suggestion!. Sure, we can cleanup as a follow on patch. Thanks, Sunil