From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32773C001DB for ; Fri, 4 Aug 2023 05:53:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231501AbjHDFx1 (ORCPT ); Fri, 4 Aug 2023 01:53:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229907AbjHDFx0 (ORCPT ); Fri, 4 Aug 2023 01:53:26 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27B841AB; Thu, 3 Aug 2023 22:53:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691128405; x=1722664405; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=4GC04UQtSW++hkGap/aB0IJ6PsV2/5cD7Mz2fax7+c4=; b=gCUEgQ+T5B+QtlodNByxErn0XNwZfl2Mxn4xRJeIqxzNMp7AWV1WkZg4 pTyO518E2E4gfiK7vUrgZJK/GhHO7qF2a/drWzLOHP9P6lIQPxH6GOIfX 7A9YBknPmoT4YDmmgKki6TuZliz//EdwgBTx424DGMaZTkbqCTzxgvo9B O0RT9hEQhB2yIAyYqC4NvumkEi3TBPSshmyni4usC6zEci6jYKfcFzJMD fcjQt9A72ABOhEUAh+ic7E/7AQMjrqeYn9/ZcQw3sVbcsEaLNjS9I3738 QyCv51GCIywNs5qGD60aZ6zf3mhwpqRvHY+L3Rka9qSuxWxXWnOiYRzkq g==; X-IronPort-AV: E=McAfee;i="6600,9927,10791"; a="368977378" X-IronPort-AV: E=Sophos;i="6.01,254,1684825200"; d="scan'208";a="368977378" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2023 22:53:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10791"; a="819973553" X-IronPort-AV: E=Sophos;i="6.01,254,1684825200"; d="scan'208";a="819973553" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP; 03 Aug 2023 22:53:18 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qRnkQ-00CPJc-2v; Fri, 04 Aug 2023 08:53:14 +0300 Date: Fri, 4 Aug 2023 08:53:14 +0300 From: Andy Shevchenko To: Sunil V L Cc: linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, Jonathan Corbet , Paul Walmsley , Palmer Dabbelt , Albert Ou , Catalin Marinas , Will Deacon , "Rafael J . Wysocki" , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , Daniel Lezcano , Thomas Gleixner , Anup Patel , Marc Zyngier , Bjorn Helgaas , Robert Moore , Haibo Xu , Andrew Jones , Conor Dooley , Atish Kumar Patra Subject: Re: [RFC PATCH v1 05/21] arm64: PCI: Migrate ACPI related functions to pci-acpi.c Message-ID: References: <20230803175916.3174453-1-sunilvl@ventanamicro.com> <20230803175916.3174453-6-sunilvl@ventanamicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230803175916.3174453-6-sunilvl@ventanamicro.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Thu, Aug 03, 2023 at 11:29:00PM +0530, Sunil V L wrote: > The functions defined in arm64 for ACPI support are required > for RISC-V also. To avoid duplication, copy these functions > to common location. ... > } > + Stray change. > arch_initcall(acpi_pci_init); > + > +#if defined(CONFIG_ARM64) ... > + cfg = pci_ecam_create(dev, &cfgres, bus_res, ecam_ops); > + if (IS_ERR(cfg)) { > + dev_err(dev, "%04x:%pR error %ld mapping ECAM\n", seg, bus_res, > + PTR_ERR(cfg)); > + return NULL; > + } > + > + return cfg; Can be cfg = pci_ecam_create(dev, &cfgres, bus_res, ecam_ops); ret = PTR_ERR_OR_ZERO(cfg); if (ret) { dev_err(dev, "%04x:%pR error %d mapping ECAM\n", seg, bus_res, ret); but as far as I understand this is in the original code like this, so consider as a suggestion for further cleanups. -- With Best Regards, Andy Shevchenko