From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: "Alexandre Ghiti" <alexghiti@rivosinc.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Atish Patra" <atishp@atishpatra.org>,
"Anup Patel" <anup@brainfault.org>,
"Will Deacon" <will@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Andrew Jones" <ajones@ventanamicro.com>,
"Rémi Denis-Courmont" <remi@remlab.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org,
linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
"Atish Patra" <atishp@rivosinc.com>
Subject: Re: [PATCH v6 10/10] perf: tests: Adapt mmap-basic.c for riscv
Date: Tue, 15 Aug 2023 15:26:47 -0300 [thread overview]
Message-ID: <ZNvDZxIS1OhXGqg0@kernel.org> (raw)
In-Reply-To: <CAP-5=fVcMg7TL6W_jH61PW6dYMobuTs13d4JDuTAx=mxJ+PNtQ@mail.gmail.com>
Em Mon, Aug 14, 2023 at 09:44:58AM -0700, Ian Rogers escreveu:
> On Wed, Aug 2, 2023 at 1:14 AM Alexandre Ghiti <alexghiti@rivosinc.com> wrote:
> >
> > riscv now supports mmaping hardware counters to userspace so adapt the test
> > to run on this architecture.
> >
> > Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com>
> > Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
> > Reviewed-by: Atish Patra <atishp@rivosinc.com>
>
> Reviewed-by: Ian Rogers <irogers@google.com>
Thanks, applied.
- Arnaldo
> Thanks,
> Ian
>
> > ---
> > tools/perf/tests/mmap-basic.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/perf/tests/mmap-basic.c b/tools/perf/tests/mmap-basic.c
> > index e68ca6229756..886a13a77a16 100644
> > --- a/tools/perf/tests/mmap-basic.c
> > +++ b/tools/perf/tests/mmap-basic.c
> > @@ -284,7 +284,8 @@ static struct test_case tests__basic_mmap[] = {
> > "permissions"),
> > TEST_CASE_REASON("User space counter reading of instructions",
> > mmap_user_read_instr,
> > -#if defined(__i386__) || defined(__x86_64__) || defined(__aarch64__)
> > +#if defined(__i386__) || defined(__x86_64__) || defined(__aarch64__) || \
> > + (defined(__riscv) && __riscv_xlen == 64)
> > "permissions"
> > #else
> > "unsupported"
> > @@ -292,7 +293,8 @@ static struct test_case tests__basic_mmap[] = {
> > ),
> > TEST_CASE_REASON("User space counter reading of cycles",
> > mmap_user_read_cycles,
> > -#if defined(__i386__) || defined(__x86_64__) || defined(__aarch64__)
> > +#if defined(__i386__) || defined(__x86_64__) || defined(__aarch64__) || \
> > + (defined(__riscv) && __riscv_xlen == 64)
> > "permissions"
> > #else
> > "unsupported"
> > --
> > 2.39.2
> >
--
- Arnaldo
next prev parent reply other threads:[~2023-08-15 18:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 8:03 [PATCH v6 00/10] riscv: Allow userspace to directly access perf counters Alexandre Ghiti
2023-08-02 8:03 ` [PATCH v6 01/10] perf: Fix wrong comment about default event_idx Alexandre Ghiti
2023-08-02 8:03 ` [PATCH v6 02/10] include: riscv: Fix wrong include guard in riscv_pmu.h Alexandre Ghiti
2023-08-02 8:03 ` [PATCH v6 03/10] riscv: Make legacy counter enum match the HW numbering Alexandre Ghiti
2023-08-02 8:03 ` [PATCH v6 04/10] drivers: perf: Rename riscv pmu sbi driver Alexandre Ghiti
2023-08-02 8:03 ` [PATCH v6 05/10] riscv: Prepare for user-space perf event mmap support Alexandre Ghiti
2023-08-02 8:03 ` [PATCH v6 06/10] drivers: perf: Implement perf event mmap support in the legacy backend Alexandre Ghiti
2023-08-02 8:03 ` [PATCH v6 07/10] drivers: perf: Implement perf event mmap support in the SBI backend Alexandre Ghiti
2023-08-02 8:03 ` [PATCH v6 08/10] Documentation: admin-guide: Add riscv sysctl_perf_user_access Alexandre Ghiti
2023-08-02 8:03 ` [PATCH v6 09/10] tools: lib: perf: Implement riscv mmap support Alexandre Ghiti
2023-08-02 9:29 ` Andrew Jones
2023-08-02 9:32 ` Andrew Jones
2023-08-11 15:19 ` Alexandre Ghiti
2023-08-14 16:44 ` Ian Rogers
2023-08-15 18:28 ` Arnaldo Carvalho de Melo
2023-08-02 8:03 ` [PATCH v6 10/10] perf: tests: Adapt mmap-basic.c for riscv Alexandre Ghiti
2023-08-14 16:44 ` Ian Rogers
2023-08-15 18:26 ` Arnaldo Carvalho de Melo [this message]
2023-08-30 13:20 ` [PATCH v6 00/10] riscv: Allow userspace to directly access perf counters patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNvDZxIS1OhXGqg0@kernel.org \
--to=acme@kernel.org \
--cc=ajones@ventanamicro.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexghiti@rivosinc.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atishp@atishpatra.org \
--cc=atishp@rivosinc.com \
--cc=corbet@lwn.net \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=remi@remlab.net \
--cc=robh@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).