From: Matthew Wilcox <willy@infradead.org>
To: Carlos Bilbao <carlos.bilbao@amd.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Avadhut Naik <Avadhut.Naik@amd.com>,
Miguel Ojeda <ojeda@kernel.org>,
Akira Yokosawa <akiyks@gmail.com>
Subject: Re: [RFC] Proposal to relax warnings of htmldocs
Date: Wed, 16 Aug 2023 16:15:29 +0100 [thread overview]
Message-ID: <ZNzoEVYE1dTOnni4@casper.infradead.org> (raw)
In-Reply-To: <f7d0e554-b6ac-49ee-4caf-640967bc1053@amd.com>
On Wed, Aug 16, 2023 at 10:12:56AM -0500, Carlos Bilbao wrote:
> On 8/16/23 06:01, Jani Nikula wrote:
> > What I'd hope for is build system support to enable W=1
> > compiler/kernel-doc warnings for a subdir with a few lines at most,
> > instead of duplicating and copy-pasting tens of lines from
> > scripts/Makefile.extrawarn like we have to do now.
>
> That sounds feasible but, well, I actually proposed the opposite approach.
> I wanted to "relax" the warnings (see RFC Subject) rather than making them
> more strict by default.
>
> My concern is that W=1 (by default) may theoretically result in a clean
> `make htmldocs` but it won't in practice. Not all developers prioritize
> good documentation like the folks from i915, and that may lead to
> unaddressed warnings or worst, less interest in documenting the code. Isn't
> it the case that some of these higher-control warnings don't really have
> much effect in real life? And shoukd W=1 become the default, are we going
> to be able to enforce that level of control?
I wasn't proposing making W=1 builds the default; I was proposing
running kernel-doc -none at all levels.
next prev parent reply other threads:[~2023-08-16 15:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 18:15 [RFC] Proposal to relax warnings of htmldocs Carlos Bilbao
2023-08-15 18:23 ` Jonathan Corbet
2023-08-15 18:35 ` Miguel Ojeda
2023-08-15 18:41 ` Matthew Wilcox
2023-08-15 18:48 ` Carlos Bilbao
2023-08-16 11:01 ` Jani Nikula
2023-08-16 15:12 ` Carlos Bilbao
2023-08-16 15:15 ` Matthew Wilcox [this message]
2023-08-16 15:21 ` Carlos Bilbao
2023-08-16 15:57 ` Matthew Wilcox
2023-08-16 16:47 ` Carlos Bilbao
2023-08-16 14:54 ` Carlos Bilbao
2023-08-16 15:04 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNzoEVYE1dTOnni4@casper.infradead.org \
--to=willy@infradead.org \
--cc=Avadhut.Naik@amd.com \
--cc=akiyks@gmail.com \
--cc=carlos.bilbao@amd.com \
--cc=corbet@lwn.net \
--cc=jani.nikula@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).