From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3283E95A61 for ; Sat, 7 Oct 2023 10:29:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343765AbjJGK34 (ORCPT ); Sat, 7 Oct 2023 06:29:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343795AbjJGK3z (ORCPT ); Sat, 7 Oct 2023 06:29:55 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9F47A2 for ; Sat, 7 Oct 2023 03:29:50 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-406618d0992so28949045e9.0 for ; Sat, 07 Oct 2023 03:29:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1696674589; x=1697279389; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UG+hsX9hPN3W+5HioqXm2wenW+sadTD1b3Qm+tfgnSY=; b=UZLIuUjx2ohTWM34V0I/Cnoc/Afxt3WHKQTsdU1wrIE3NYsB2ZOCMsNFwpocype4J7 kgkMaTVvryEVvWpoWC1ck+YgH3dFzXC1rZjglZF9PD1KO7JzWiB9x0pZEFLa+Yebakwj GkW1I/+JzAc1qNPtaBJgfQFXwJBW/IcNGgRmWFuBtp3pWlgxl1QXkk30wF7fuCFWRWBV buawxCW+8pX5Ld0rdCjMv/lqMH7nISjJhZG8u0IKvEXlK9sVybhAKxhnpOy8w89pt6YK jRuYZZs93cjSUc4Cki2yE0e4s/IkSq5se/Blu88AZ94ltq0xHJgbDPPNgRCgb7utb/s+ 6W5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696674589; x=1697279389; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UG+hsX9hPN3W+5HioqXm2wenW+sadTD1b3Qm+tfgnSY=; b=DIMoSRoryLtPRZ4lqe+Er80PJlfkOuLo+Xgz/eUMM1ezAFh5RcfswoKfy+OvK27guP ym/RYIUAOX3sg1PfbyKh+/x5FzZTogZYpeHOCo1Vl12JhUWdLaovaKkPL1KM1xCzsJV7 lOMYDs6MfAjTKiHrxwckqRNz2CJdWs0SxDqj71DkkeyIv0+Ge/hAoDHQODmo9r5v/+tb rkV+FZuqxfqhM5J6EmvaYBs/wgjKAkBiuokvCpOU+ODKdyz27JTzeH35QiHYcYdAjIKb Z0URM912wSqPz9k8W6x8ZfmOJ/rLmmtqJ/S25+S3LJGt+yGVKttumosRThc/wMHEHo0/ 69fw== X-Gm-Message-State: AOJu0Yz1tuixzIG2mRFqv6m40l7pFvduqxmiLJXN2JRA7I8p6BXavB5l bfSAN21Ugc660y87V+j3G68kXA== X-Google-Smtp-Source: AGHT+IFCuMFxbiqcnF20Qq6FWZXXKcM304kVgx1Fkg5wNG86dJ8nKaYsW62Ajy0W8xgkaauUSCLIfA== X-Received: by 2002:a5d:6450:0:b0:315:ad1a:5abc with SMTP id d16-20020a5d6450000000b00315ad1a5abcmr9606048wrw.5.1696674589035; Sat, 07 Oct 2023 03:29:49 -0700 (PDT) Received: from localhost ([91.218.191.82]) by smtp.gmail.com with ESMTPSA id c6-20020adfed86000000b003279518f51dsm3920808wro.2.2023.10.07.03.29.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Oct 2023 03:29:48 -0700 (PDT) Date: Sat, 7 Oct 2023 12:29:47 +0200 From: Jiri Pirko To: Kuba Kicinski Cc: Arkadiusz Kubalewski , netdev@vger.kernel.org, vadim.fedorenko@linux.dev, corbet@lwn.net, davem@davemloft.net, pabeni@redhat.com, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, linux-doc@vger.kernel.org, intel-wired-lan@lists.osuosl.org Subject: Re: [PATCH net-next v3 2/5] dpll: spec: add support for pin-dpll signal phase offset/adjust Message-ID: References: <20231006114101.1608796-1-arkadiusz.kubalewski@intel.com> <20231006114101.1608796-3-arkadiusz.kubalewski@intel.com> <20231006075536.3b21582e@kernel.org> <20231006124457.26417f37@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231006124457.26417f37@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Fri, Oct 06, 2023 at 09:44:57PM CEST, kuba@kernel.org wrote: >On Fri, 6 Oct 2023 18:53:04 +0200 Jiri Pirko wrote: >> Fri, Oct 06, 2023 at 04:55:36PM CEST, kuba@kernel.org wrote: >> >> I'm confused. Didn't you say you'll remove this? If not, my question >> >> from v1 still stands. >> > >> >Perhaps we should dis-allow setting version in non-genetlink-legacy >> >specs? I thought it may be a useful thing to someone, at some point, >> >but so far the scoreboard is: legit uses: 0, confused uses: 1 :S >> > >> >Thoughts? >> >> I don't know what the meaning of version is. I just never saw that being >> touched. Is there any semantics documented for it? >> >> Kuba, any opinion? > >/me switches the first name in From :P I messed up a bit. Kuba* confusion, sorry :) > >I think it basically predates the op / policy introspection, >and allows people to break backward compat. > >drop_monitor bumped to 2 in 2009: > > 683703a26e46 ("drop_monitor: Update netlink protocol to include >netlink attribute header in alert message") > >which breaks backward compat. > >genetlink ctrl went to 2 in 2006: > > 334c29a64507 ("[GENETLINK]: Move command capabilities to flags.") > >which moves some info around in attrs, also breaks backward compat >if someone depended on the old placement. > >ovs did it in 2013: > > 44da5ae5fbea ("openvswitch: Drop user features if old user space >attempted to create datapath") > >again, breaks backwards compat. > > >I guess it may still make one day to bump the version for some proto >which has very tight control over the user space. But it hasn't >happened for 10 years. But since by the policy we cannot break uapi compat, version should be never bumped. I wonder howcome it is legit in the examples you listed above... Let's forbid that in genetlink.yaml. I have a patch ready, please ack this approach. Thx!