From: Frank Li <Frank.li@nxp.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: miquel.raynal@bootlin.com, conor.culhane@silvaco.com,
alexandre.belloni@bootlin.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
corbet@lwn.net, joe@perches.com, linux-i3c@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, gregkh@linuxfoundation.org,
imx@lists.linux.dev, jirislaby@kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH 1/5] i3c: add slave mode support
Date: Thu, 19 Oct 2023 11:02:10 -0400 [thread overview]
Message-ID: <ZTFE8hrRgPBrb7e3@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <dd06c2d3-e273-4356-835b-42619543dfab@linaro.org>
On Thu, Oct 19, 2023 at 09:00:05AM +0200, Krzysztof Kozlowski wrote:
> On 18/10/2023 23:58, Frank Li wrote:
> > Introduce a new slave core layer in order to support slave functions in
> > linux kernel. This comprises the controller library and function library.
> > Controller library implements functions specific to an slave controller
> > and function library implements functions specific to an slave function.
> >
> > Introduce a new configfs entry to configure the slave function configuring
> > and bind the slave function with slave controller.
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > drivers/i3c/Kconfig | 26 ++
> > drivers/i3c/Makefile | 2 +
> > drivers/i3c/i3c-cfs.c | 389 +++++++++++++++++++++++++++++
> > drivers/i3c/slave.c | 453 ++++++++++++++++++++++++++++++++++
> > include/linux/i3c/slave.h | 503 ++++++++++++++++++++++++++++++++++++++
> > 5 files changed, 1373 insertions(+)
> > create mode 100644 drivers/i3c/i3c-cfs.c
> > create mode 100644 drivers/i3c/slave.c
> > create mode 100644 include/linux/i3c/slave.h
> >
> > diff --git a/drivers/i3c/Kconfig b/drivers/i3c/Kconfig
> > index 30a441506f61c..d5f5ca7cd6a56 100644
> > --- a/drivers/i3c/Kconfig
> > +++ b/drivers/i3c/Kconfig
> > @@ -22,3 +22,29 @@ menuconfig I3C
> > if I3C
> > source "drivers/i3c/master/Kconfig"
> > endif # I3C
> > +
> > +config I3C_SLAVE
>
> It doesn't look like you follow Kernel naming convention (see coding style).
I checked I3C spec. It use words 'target'.
Is it okay using I3C_TARGET?
>
> > + bool "I3C Slave Support"
> > + help
> > + Support I3C Slave Mode.
> > +
>
>
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-10-19 15:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 21:58 [PATCH 0/5] I3C slave mode support Frank Li
2023-10-18 21:58 ` [PATCH 1/5] i3c: add " Frank Li
2023-10-19 7:00 ` Krzysztof Kozlowski
2023-10-19 15:02 ` Frank Li [this message]
2023-10-19 15:46 ` Greg KH
2023-10-19 17:06 ` Greg KH
2023-10-23 1:11 ` kernel test robot
2023-10-23 1:20 ` kernel test robot
2023-10-18 21:58 ` [PATCH 2/5] dt-bindings: i3c: svc: add compatible string i3c: silvaco,i3c-slave Frank Li
2023-10-19 7:00 ` Krzysztof Kozlowski
2023-10-19 12:07 ` Rob Herring
2023-10-18 21:58 ` [PATCH 3/5] i3c: slave: add svc slave controller support Frank Li
2023-10-23 1:29 ` kernel test robot
2023-10-18 21:58 ` [PATCH 4/5] i3c: slave: func: add tty driver Frank Li
2023-10-19 7:21 ` Jiri Slaby
2023-10-18 21:58 ` [PATCH 5/5] Documentation: i3c: Add I3C slave mode controller and function Frank Li
2023-10-18 22:07 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTFE8hrRgPBrb7e3@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=conor.culhane@silvaco.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=jirislaby@kernel.org \
--cc=joe@perches.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox